From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/4] tools/fuzz: add AFL stub program for x86 insn emulator fuzzer
Date: Tue, 24 Jan 2017 17:18:20 +0000 [thread overview]
Message-ID: <20170124171820.usctmtp3q6roxgnf@citrix.com> (raw)
In-Reply-To: <22663.35148.446698.237437@mariner.uk.xensource.com>
On Tue, Jan 24, 2017 at 05:05:16PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH 2/4] tools/fuzz: add AFL stub program for x86 insn emulator fuzzer"):
> > This is a basic program to call into the unified fuzzing function.
> ...
> > + fd = open(argv[1], O_RDONLY, 0);
> > + assert(fd != -1);
> > + size = read(fd, input, sizeof(input));
>
> Why do you use open and read here rather than fopen and fread ?
>
No particular reason.
> If you use read you ought to put it in a loop to cope with potential
> partial reads.
>
Does fread have better properties than read? I think to deal with short
read we would need to stat the file to get actual size for both fread
and read, right? If so I will just stick with read and put that in a
loop.
Wei.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-24 17:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 12:11 [PATCH 0/4] fuzz: basic AFL support Wei Liu
2017-01-20 12:11 ` [PATCH 1/4] tools/fuzz: add missing dependency in x86 insn fuzzer build rule Wei Liu
2017-01-20 12:11 ` [PATCH 2/4] tools/fuzz: add AFL stub program for x86 insn emulator fuzzer Wei Liu
2017-01-24 10:09 ` Jan Beulich
2017-01-24 16:43 ` Wei Liu
2017-01-24 17:05 ` Ian Jackson
2017-01-24 17:18 ` Wei Liu [this message]
2017-01-24 17:22 ` Ian Jackson
2017-01-24 17:25 ` Andrew Cooper
2017-01-24 17:27 ` Wei Liu
2017-01-24 17:30 ` Ian Jackson
2017-01-24 17:37 ` Wei Liu
2017-01-24 17:46 ` Ian Jackson
2017-01-24 17:28 ` Wei Liu
2017-01-20 12:11 ` [PATCH 3/4] tools/fuzz: add AFL stub program for libefl fuzzer Wei Liu
2017-01-24 10:10 ` Jan Beulich
2017-01-20 12:11 ` [PATCH 4/4] tools/fuzz: add README.afl Wei Liu
2017-01-24 19:27 ` Andrew Cooper
2017-01-25 9:49 ` Wei Liu
2017-01-25 9:51 ` George Dunlap
2017-01-25 9:54 ` Wei Liu
2017-01-24 18:18 ` [PATCH 0/4] fuzz: basic AFL support Julien Grall
2017-01-24 18:56 ` Wei Liu
2017-01-24 19:00 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124171820.usctmtp3q6roxgnf@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).