From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC XEN PATCH 12/16] tools/libxl: build qemu options from xl vNVDIMM configs Date: Fri, 27 Jan 2017 16:47:52 -0500 Message-ID: <20170127214751.GG18581@localhost.localdomain> References: <20161010003235.4213-1-haozhong.zhang@intel.com> <20161010003235.4213-13-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161010003235.4213-13-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Xiao Guangrong , Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBPY3QgMTAsIDIwMTYgYXQgMDg6MzI6MzFBTSArMDgwMCwgSGFvemhvbmcgWmhhbmcg d3JvdGU6Cj4gRm9yIHhsIHZOVkRJTU0gY29uZmlncwo+ICAgdm52ZGltbXMgPSBbICcvcGF0aC90 by9wbWVtMCcsICcvcGF0aC90by9wbWVtMScsIC4uLiBdCj4gCj4gdGhlIGZvbGxvd2luZyBxZW11 IG9wdGlvbnMgYXJlIGJ1aWx0Cj4gICAtbWFjaGluZSA8ZXhpc3Rpbmcgb3B0aW9ucz4sbnZkaW1t Cj4gICAtbSA8ZXhpc3Rpbmcgb3B0aW9ucz4sc2xvdHM9JE5SX1NMT1RTLG1heG1lbT0kTUVNX1NJ WkUKPiAgIC1vYmplY3QgbWVtb3J5LWJhY2tlbmQteGVuLGlkPW1lbTEsc2l6ZT0kUE1FTTBfU0la RSxtZW0tcGF0aD0vcGF0aC90by9wbWVtMAo+ICAgLWRldmljZSBudmRpbW0saWQ9bnZkaW1tMSxt ZW1kZXY9bWVtMQo+ICAgLW9iamVjdCBtZW1vcnktYmFja2VuZC14ZW4saWQ9bWVtMixzaXplPSRQ TUVNMV9TSVpFLG1lbS1wYXRoPS9wYXRoL3RvL3BtZW0xCj4gICAtZGV2aWNlIG52ZGltbSxpZD1u dmRpbW0yLG1lbWRldj1tZW0yCj4gICAuLi4KPiB3aGVyZQo+ICogTlJfU0xPVFMgaXMgdGhlIG51 bWJlciBvZiBlbnRyaWVzIGluIHZudmRpbW1zICsgMSwKPiAqIE1FTV9TSVpFIGlzIHRoZSB0b3Rh bCBzaXplIG9mIGFsbCBSQU0gYW5kIE5WRElNTSBkZXZpY2VzLAo+ICogUE1FTSNfU0laRSBpcyB0 aGUgc2l6ZSBvZiB0aGUgaG9zdCBwbWVtIGRldmljZS9maWxlICcvcGF0aC90by9wbWVtIycuCj4g Cj4gU2lnbmVkLW9mZi1ieTogSGFvemhvbmcgWmhhbmcgPGhhb3pob25nLnpoYW5nQGludGVsLmNv bT4KPiAtLS0KPiBDYzogSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4g Q2M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHRvb2xzL2xpYnhsL2xp YnhsX2RtLmMgICAgICB8IDExMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLQo+ICB0b29scy9saWJ4bC9saWJ4bF90eXBlcy5pZGwgfCAgIDggKysrKwo+ICB0b29s cy9saWJ4bC94bF9jbWRpbXBsLmMgICAgfCAgMTYgKysrKysrKwoKWW91IHByb2JhYmx5IGFsc28g d2FudCB0aGlzIG5ldyBwYXJhbWV0ZXIgaW4gdGhlIHhsIG1hbnBhZ2UuCgo+ICAzIGZpbGVzIGNo YW5nZWQsIDEzNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS90b29scy9saWJ4bC9saWJ4bF9kbS5jIGIvdG9vbHMvbGlieGwvbGlieGxfZG0uYwo+IGluZGV4 IGFkMzY2YTguLjZiOGMwMTkgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG0uYwo+ ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2RtLmMKPiBAQCAtMjQsNiArMjQsMTAgQEAKPiAgI2lu Y2x1ZGUgPHN5cy90eXBlcy5oPgo+ICAjaW5jbHVkZSA8cHdkLmg+Cj4gIAo+ICsjaWYgZGVmaW5l ZChfX2xpbnV4X18pCj4gKyNpbmNsdWRlIDxsaW51eC9mcy5oPgo+ICsjZW5kaWYKPiArCj4gIHN0 YXRpYyBjb25zdCBjaGFyICpsaWJ4bF90YXBpZl9zY3JpcHQobGlieGxfX2djICpnYykKPiAgewo+ ICAjaWYgZGVmaW5lZChfX2xpbnV4X18pIHx8IGRlZmluZWQoX19GcmVlQlNEX18pCj4gQEAgLTkw NSw2ICs5MDksODYgQEAgc3RhdGljIGNoYXIgKnFlbXVfZGlza19pZGVfZHJpdmVfc3RyaW5nKGxp YnhsX19nYyAqZ2MsIGNvbnN0IGNoYXIgKnRhcmdldF9wYXRoLAo+ICAgICAgcmV0dXJuIGRyaXZl Owo+ICB9Cj4gIAo+ICsjaWYgZGVmaW5lZChfX2xpbnV4X18pCj4gKwo+ICtzdGF0aWMgdWludDY0 X3QgbGlieGxfX2J1aWxkX2RtX3ZudmRpbW1fYXJncyhsaWJ4bF9fZ2MgKmdjLCBmbGV4YXJyYXlf dCAqZG1fYXJncywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3RydWN0IGxpYnhsX2RldmljZV92bnZkaW1tICpkZXYsCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBkZXZfbm8pCj4gK3sKPiArICAgIGludCBm ZCwgcmM7Cj4gKyAgICBzdHJ1Y3Qgc3RhdCBzdDsKPiArICAgIHVpbnQ2NF90IHNpemUgPSAwOwo+ ICsgICAgY2hhciAqYXJnOwo+ICsKPiArICAgIGZkID0gb3BlbihkZXYtPmZpbGUsIE9fUkRPTkxZ KTsKPiArICAgIGlmIChmZCA8IDApIHsKPiArICAgICAgICBMT0coRVJST1IsICJmYWlsZWQgdG8g b3BlbiBmaWxlICVzOiAlcyIsCj4gKyAgICAgICAgICAgIGRldi0+ZmlsZSwgc3RyZXJyb3IoZXJy bm8pKTsKPiArICAgICAgICBnb3RvIG91dDsKPiArICAgIH0KPiArCj4gKyAgICBpZiAoc3RhdChk ZXYtPmZpbGUsICZzdCkpIHsKPiArICAgICAgICBMT0coRVJST1IsICJmYWlsZWQgdG8gZ2V0IHN0 YXR1cyBvZiBmaWxlICVzOiAlcyIsCj4gKyAgICAgICAgICAgIGRldi0+ZmlsZSwgc3RyZXJyb3Io ZXJybm8pKTsKPiArICAgICAgICBnb3RvIG91dF9mY2xvc2U7Cj4gKyAgICB9Cj4gKwo+ICsgICAg c3dpdGNoIChzdC5zdF9tb2RlICYgU19JRk1UKSB7Cj4gKyAgICBjYXNlIFNfSUZCTEs6Cj4gKyAg ICAgICAgcmMgPSBpb2N0bChmZCwgQkxLR0VUU0laRTY0LCAmc2l6ZSk7Cj4gKyAgICAgICAgaWYg KHJjID09IC0xKSB7Cj4gKyAgICAgICAgICAgIExPRyhFUlJPUiwgImZhaWxlZCB0byBnZXQgc2l6 ZSBvZiBibG9jayBkZXZpY2UgJXM6ICVzIiwKPiArICAgICAgICAgICAgICAgIGRldi0+ZmlsZSwg c3RyZXJyb3IoZXJybm8pKTsKPiArICAgICAgICAgICAgc2l6ZSA9IDA7Cj4gKyAgICAgICAgfQo+ ICsgICAgICAgIGJyZWFrOwo+ICsKPiArICAgIGNhc2UgU19JRlJFRzoKPiArICAgICAgICBzaXpl ID0gc3Quc3Rfc2l6ZTsKPiArICAgICAgICBicmVhazsKPiArCj4gKyAgICBkZWZhdWx0Ogo+ICsg ICAgICAgIExPRyhFUlJPUiwgIiVzIGlzIG5vdCBhIGJsb2NrIGRldmljZSBvciByZWd1bGFyIGZp bGUiLCBkZXYtPmZpbGUpOwo+ICsgICAgICAgIGJyZWFrOwo+ICsgICAgfQo+ICsKPiArICAgIGlm ICghc2l6ZSkKPiArICAgICAgICBnb3RvIG91dF9mY2xvc2U7Cj4gKwo+ICsgICAgZmxleGFycmF5 X2FwcGVuZChkbV9hcmdzLCAiLW9iamVjdCIpOwo+ICsgICAgYXJnID0gR0NTUFJJTlRGKCJtZW1v cnktYmFja2VuZC14ZW4saWQ9bWVtJWQsc2l6ZT0lIlBSSXU2NCIsbWVtLXBhdGg9JXMiLAo+ICsg ICAgICAgICAgICAgICAgICAgIGRldl9ubyArIDEsIHNpemUsIGRldi0+ZmlsZSk7Cj4gKyAgICBm bGV4YXJyYXlfYXBwZW5kKGRtX2FyZ3MsIGFyZyk7Cj4gKwo+ICsgICAgZmxleGFycmF5X2FwcGVu ZChkbV9hcmdzLCAiLWRldmljZSIpOwo+ICsgICAgYXJnID0gR0NTUFJJTlRGKCJudmRpbW0saWQ9 bnZkaW1tJWQsbWVtZGV2PW1lbSVkIiwgZGV2X25vICsgMSwgZGV2X25vICsgMSk7Cj4gKyAgICBm bGV4YXJyYXlfYXBwZW5kKGRtX2FyZ3MsIGFyZyk7Cj4gKwo+ICsgb3V0X2ZjbG9zZToKPiArICAg IGNsb3NlKGZkKTsKPiArIG91dDoKPiArICAgIHJldHVybiBzaXplOwo+ICt9Cj4gKwo+ICtzdGF0 aWMgdWludDY0X3QgbGlieGxfX2J1aWxkX2RtX3ZudmRpbW1zX2FyZ3MoCj4gKyAgICBsaWJ4bF9f Z2MgKmdjLCBmbGV4YXJyYXlfdCAqZG1fYXJncywKPiArICAgIHN0cnVjdCBsaWJ4bF9kZXZpY2Vf dm52ZGltbSAqdm52ZGltbXMsIGludCBudW1fdm52ZGltbXMpCj4gK3sKPiArICAgIHVpbnQ2NF90 IHRvdGFsX3NpemUgPSAwLCBzaXplOwo+ICsgICAgaW50IGk7Cgp1bnNpZ25lZCBpbnQKPiArCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK