From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [RFC XEN PATCH 15/16] tools/libxl: handle return code of libxl__qmp_initializations()
Date: Fri, 27 Jan 2017 17:11:23 -0500 [thread overview]
Message-ID: <20170127221122.GK18581@localhost.localdomain> (raw)
In-Reply-To: <20161010003235.4213-16-haozhong.zhang@intel.com>
On Mon, Oct 10, 2016 at 08:32:34AM +0800, Haozhong Zhang wrote:
> If any error code is returned when creating a domain, stop the domain
> creation.
This looks like it is a bug-fix that can be spun off from this
patchset?
>
> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libxl/libxl_create.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index d986cd2..24e8368 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -1499,7 +1499,9 @@ static void domcreate_devmodel_started(libxl__egc *egc,
> if (dcs->sdss.dm.guest_domid) {
> if (d_config->b_info.device_model_version
> == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
> - libxl__qmp_initializations(gc, domid, d_config);
> + ret = libxl__qmp_initializations(gc, domid, d_config);
> + if (ret)
> + goto error_out;
> }
> }
>
> --
> 2.10.1
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-27 22:11 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 0:32 [RFC XEN PATCH 00/16] Add vNVDIMM support to HVM domains Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 01/16] x86_64/mm: explicitly specify the location to place the frame table Haozhong Zhang
2016-12-09 21:35 ` Konrad Rzeszutek Wilk
2016-12-12 2:27 ` Haozhong Zhang
2016-12-12 8:25 ` Jan Beulich
2016-10-10 0:32 ` [RFC XEN PATCH 02/16] x86_64/mm: explicitly specify the location to place the M2P table Haozhong Zhang
2016-12-09 21:38 ` Konrad Rzeszutek Wilk
2016-12-12 2:31 ` Haozhong Zhang
2016-12-12 8:26 ` Jan Beulich
2016-12-12 8:35 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 03/16] xen/x86: add a hypercall XENPF_pmem_add to report host pmem regions Haozhong Zhang
2016-10-11 19:13 ` Andrew Cooper
2016-12-09 22:02 ` Konrad Rzeszutek Wilk
2016-12-12 4:16 ` Haozhong Zhang
2016-12-12 8:30 ` Jan Beulich
2016-12-12 8:38 ` Haozhong Zhang
2016-12-12 14:44 ` Konrad Rzeszutek Wilk
2016-12-13 1:08 ` Haozhong Zhang
2016-12-22 11:58 ` Jan Beulich
2016-10-10 0:32 ` [RFC XEN PATCH 04/16] xen/x86: add XENMEM_populate_pmemmap to map host pmem pages to guest Haozhong Zhang
2016-12-09 22:22 ` Konrad Rzeszutek Wilk
2016-12-12 4:38 ` Haozhong Zhang
2016-12-22 12:19 ` Jan Beulich
2016-10-10 0:32 ` [RFC XEN PATCH 05/16] xen/x86: release pmem pages at domain destroy Haozhong Zhang
2016-12-09 22:27 ` Konrad Rzeszutek Wilk
2016-12-12 4:47 ` Haozhong Zhang
2016-12-22 12:22 ` Jan Beulich
2016-10-10 0:32 ` [RFC XEN PATCH 06/16] tools: reserve guest memory for ACPI from device model Haozhong Zhang
2017-01-27 20:44 ` Konrad Rzeszutek Wilk
2017-02-08 1:39 ` Haozhong Zhang
2017-02-08 14:31 ` Konrad Rzeszutek Wilk
2016-10-10 0:32 ` [RFC XEN PATCH 07/16] tools/libacpi: add callback acpi_ctxt.p2v to get a pointer from physical address Haozhong Zhang
2017-01-27 20:46 ` Konrad Rzeszutek Wilk
2017-02-08 1:42 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 08/16] tools/libacpi: expose details of memory allocation callback Haozhong Zhang
2017-01-27 20:58 ` Konrad Rzeszutek Wilk
2017-02-08 2:12 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 09/16] tools/libacpi: add callbacks to access XenStore Haozhong Zhang
2017-01-27 21:10 ` Konrad Rzeszutek Wilk
2017-02-08 2:19 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 10/16] tools/libacpi: add a simple AML builder Haozhong Zhang
2017-01-27 21:19 ` Konrad Rzeszutek Wilk
2017-02-08 2:33 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 11/16] tools/libacpi: load ACPI built by the device model Haozhong Zhang
2017-01-27 21:40 ` Konrad Rzeszutek Wilk
2017-02-08 5:38 ` Haozhong Zhang
2017-02-08 14:35 ` Konrad Rzeszutek Wilk
2016-10-10 0:32 ` [RFC XEN PATCH 12/16] tools/libxl: build qemu options from xl vNVDIMM configs Haozhong Zhang
2017-01-27 21:47 ` Konrad Rzeszutek Wilk
2017-02-08 5:42 ` Haozhong Zhang
2017-01-27 21:48 ` Konrad Rzeszutek Wilk
2017-02-08 5:47 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 13/16] tools/libxl: add support to map host pmem device to guests Haozhong Zhang
2017-01-27 22:06 ` Konrad Rzeszutek Wilk
2017-01-27 22:09 ` Konrad Rzeszutek Wilk
2017-02-08 5:59 ` Haozhong Zhang
2017-02-08 14:37 ` Konrad Rzeszutek Wilk
2016-10-10 0:32 ` [RFC XEN PATCH 14/16] tools/libxl: add support to map files on pmem devices " Haozhong Zhang
2017-01-27 22:10 ` Konrad Rzeszutek Wilk
2017-02-08 6:03 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 15/16] tools/libxl: handle return code of libxl__qmp_initializations() Haozhong Zhang
2017-01-27 22:11 ` Konrad Rzeszutek Wilk [this message]
2017-02-08 6:07 ` Haozhong Zhang
2017-02-08 10:31 ` Wei Liu
2017-02-09 2:47 ` Haozhong Zhang
2017-02-09 10:13 ` Wei Liu
2017-02-09 10:16 ` Wei Liu
2017-02-10 2:37 ` Haozhong Zhang
2017-02-10 8:11 ` Wei Liu
2017-02-10 8:23 ` Wei Liu
2017-02-10 8:24 ` Haozhong Zhang
2016-10-10 0:32 ` [RFC XEN PATCH 16/16] tools/libxl: initiate pmem mapping via qmp callback Haozhong Zhang
2017-01-27 22:13 ` Konrad Rzeszutek Wilk
2017-02-08 6:08 ` Haozhong Zhang
2016-10-24 16:37 ` [RFC XEN PATCH 00/16] Add vNVDIMM support to HVM domains Wei Liu
2016-10-25 6:55 ` Haozhong Zhang
2016-10-25 11:28 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127221122.GK18581@localhost.localdomain \
--to=konrad@darnok.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=haozhong.zhang@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).