From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC XEN PATCH 16/16] tools/libxl: initiate pmem mapping via qmp callback Date: Fri, 27 Jan 2017 17:13:23 -0500 Message-ID: <20170127221322.GL18581@localhost.localdomain> References: <20161010003235.4213-1-haozhong.zhang@intel.com> <20161010003235.4213-17-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161010003235.4213-17-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Xiao Guangrong , Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBPY3QgMTAsIDIwMTYgYXQgMDg6MzI6MzVBTSArMDgwMCwgSGFvemhvbmcgWmhhbmcg d3JvdGU6Cj4gUU1QIGNvbW1hbmQgJ3F1ZXJ5LW52ZGltbXMnIGlzIHVzZWQgYnkgbGlieGwgdG8g Z2V0IHRoZSBiYWNrZW5kLCB0aGUKPiBndWVzdCBTUEEgYW5kIHNpemUgb2YgZWFjaCB2TlZESU1N IGRldmljZSwgYW5kIHRoZW4gbGlieGwgc3RhcnRzIG1hcHBpbmcKPiBiYWNrZW5kIHRvIGd1ZXN0 IGZvciBlYWNoIHZOVkRJTU0gZGV2aWNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEhhb3pob25nIFpo YW5nIDxoYW96aG9uZy56aGFuZ0BpbnRlbC5jb20+Cj4gLS0tCj4gQ2M6IElhbiBKYWNrc29uIDxp YW4uamFja3NvbkBldS5jaXRyaXguY29tPgo+IENjOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXgu Y29tPgo+IC0tLQo+ICB0b29scy9saWJ4bC9saWJ4bF9xbXAuYyB8IDY0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDY0 IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMg Yi90b29scy9saWJ4bC9saWJ4bF9xbXAuYwo+IGluZGV4IGY4YWRkZjkuLjAyZWRkMDkgMTAwNjQ0 Cj4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMKPiArKysgYi90b29scy9saWJ4bC9saWJ4 bF9xbXAuYwo+IEBAIC0yNiw2ICsyNiw3IEBACj4gIAo+ICAjaW5jbHVkZSAiX2xpYnhsX2xpc3Qu aCIKPiAgI2luY2x1ZGUgImxpYnhsX2ludGVybmFsLmgiCj4gKyNpbmNsdWRlICJsaWJ4bF9udmRp bW0uaCIKPiAgCj4gIC8qICNkZWZpbmUgREVCVUdfUkVDRUlWRUQgKi8KPiAgCj4gQEAgLTExNDYs NiArMTE0Nyw2NiBAQCBvdXQ6Cj4gICAgICByZXR1cm4gcmM7Cj4gIH0KPiAgCj4gK3N0YXRpYyBp bnQgcW1wX3JlZ2lzdGVyX252ZGltbV9jYWxsYmFjayhsaWJ4bF9fcW1wX2hhbmRsZXIgKnFtcCwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX19q c29uX29iamVjdCAqbywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHZvaWQgKnVudXNlZCkKPiArewo+ICsgICAgR0NfSU5JVChxbXAtPmN0eCk7Cj4gKyAgICBjb25z dCBsaWJ4bF9fanNvbl9vYmplY3QgKm9iaiA9IE5VTEw7Cj4gKyAgICBjb25zdCBsaWJ4bF9fanNv bl9vYmplY3QgKnN1Yl9vYmogPSBOVUxMOwo+ICsgICAgaW50IGkgPSAwOwoKdW5zaWduZWQgaW50 Lgo+ICsgICAgY29uc3QgY2hhciAqbWVtX3BhdGg7Cj4gKyAgICB1aW50NjRfdCBzbG90LCBzcGEs IGxlbmd0aDsKPiArICAgIGludCByZXQgPSAwOwo+ICsKPiArICAgIGZvciAoaSA9IDA7IChvYmog PSBsaWJ4bF9fanNvbl9hcnJheV9nZXQobywgaSkpOyBpKyspIHsKPiArICAgICAgICBpZiAoIWxp YnhsX19qc29uX29iamVjdF9pc19tYXAob2JqKSkKPiArICAgICAgICAgICAgY29udGludWU7Cj4g Kwo+ICsgICAgICAgIHN1Yl9vYmogPSBsaWJ4bF9fanNvbl9tYXBfZ2V0KCJzbG90Iiwgb2JqLCBK U09OX0lOVEVHRVIpOwo+ICsgICAgICAgIHNsb3QgPSBsaWJ4bF9fanNvbl9vYmplY3RfZ2V0X2lu dGVnZXIoc3ViX29iaik7Cj4gKwo+ICsgICAgICAgIHN1Yl9vYmogPSBsaWJ4bF9fanNvbl9tYXBf Z2V0KCJtZW0tcGF0aCIsIG9iaiwgSlNPTl9TVFJJTkcpOwo+ICsgICAgICAgIG1lbV9wYXRoID0g bGlieGxfX2pzb25fb2JqZWN0X2dldF9zdHJpbmcoc3ViX29iaik7Cj4gKyAgICAgICAgaWYgKCFt ZW1fcGF0aCkgewo+ICsgICAgICAgICAgICBMT0coRVJST1IsICJObyBtZW0tcGF0aCBpcyBzcGVj aWZpZWQgZm9yIE5WRElNTSAjJSIgUFJJZDY0LCBzbG90KTsKPiArICAgICAgICAgICAgcmV0ID0g LUVJTlZBTDsKPiArICAgICAgICAgICAgZ290byBvdXQ7Cj4gKyAgICAgICAgfQo+ICsKPiArICAg ICAgICBzdWJfb2JqID0gbGlieGxfX2pzb25fbWFwX2dldCgic3BhIiwgb2JqLCBKU09OX0lOVEVH RVIpOwo+ICsgICAgICAgIHNwYSA9IGxpYnhsX19qc29uX29iamVjdF9nZXRfaW50ZWdlcihzdWJf b2JqKTsKPiArCj4gKyAgICAgICAgc3ViX29iaiA9IGxpYnhsX19qc29uX21hcF9nZXQoImxlbmd0 aCIsIG9iaiwgSlNPTl9JTlRFR0VSKTsKPiArICAgICAgICBsZW5ndGggPSBsaWJ4bF9fanNvbl9v YmplY3RfZ2V0X2ludGVnZXIoc3ViX29iaik7Cj4gKwo+ICsgICAgICAgIExPRyhERUJVRywKPiAr ICAgICAgICAgICAgInZOVkRJTU0gIyUiIFBSSWQ2NCAiOiAlcywgc3BhIDB4JSIgUFJJeDY0ICIs IGxlbmd0aCAweCUiIFBSSXg2NCwKPiArICAgICAgICAgICAgc2xvdCwgbWVtX3BhdGgsIHNwYSwg bGVuZ3RoKTsKPiArCj4gKyAgICAgICAgcmV0ID0gbGlieGxfbnZkaW1tX2FkZF9kZXZpY2UoZ2Ms IHFtcC0+ZG9taWQsIG1lbV9wYXRoLCBzcGEsIGxlbmd0aCk7Cj4gKyAgICAgICAgaWYgKHJldCkg ewo+ICsgICAgICAgICAgICBMT0coRVJST1IsCj4gKyAgICAgICAgICAgICAgICAiRmFpbGVkIHRv IGFkZCBOVkRJTU0gIyUiIFBSSWQ2NAo+ICsgICAgICAgICAgICAgICAgIihtZW1fcGF0aCAlcywg c3BhIDB4JSIgUFJJeDY0ICIsIGxlbmd0aCAweCUiIFBSSXg2NCAiKSAiCj4gKyAgICAgICAgICAg ICAgICAidG8gZG9tYWluICVkIChlcnIgPSAlZCkiLAo+ICsgICAgICAgICAgICAgICAgc2xvdCwg bWVtX3BhdGgsIHNwYSwgbGVuZ3RoLCBxbXAtPmRvbWlkLCByZXQpOwo+ICsgICAgICAgICAgICBn b3RvIG91dDsKPiArICAgICAgICB9Cj4gKyAgICB9Cj4gKwo+ICsgb3V0Ogo+ICsgICAgR0NfRlJF RTsKPiArICAgIHJldHVybiByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgbGlieGxfX3FtcF9x dWVyeV9udmRpbW1zKGxpYnhsX19xbXBfaGFuZGxlciAqcW1wKQo+ICt7Cj4gKyAgICByZXR1cm4g cW1wX3N5bmNocm9ub3VzX3NlbmQocW1wLCAicXVlcnktbnZkaW1tcyIsIE5VTEwsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcW1wX3JlZ2lzdGVyX252ZGltbV9jYWxsYmFjaywK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBxbXAtPnRpbWVvdXQpOwo+ ICt9Cj4gKwo+ICBpbnQgbGlieGxfX3FtcF9obXAobGlieGxfX2djICpnYywgaW50IGRvbWlkLCBj b25zdCBjaGFyICpjb21tYW5kX2xpbmUsCj4gICAgICAgICAgICAgICAgICAgICBjaGFyICoqb3V0 cHV0KQo+ICB7Cj4gQEAgLTExODcsNiArMTI0OCw5IEBAIGludCBsaWJ4bF9fcW1wX2luaXRpYWxp emF0aW9ucyhsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKPiAgICAgIGlmICghcmV0KSB7 Cj4gICAgICAgICAgcmV0ID0gcW1wX3F1ZXJ5X3ZuYyhxbXApOwo+ICAgICAgfQo+ICsgICAgaWYg KCFyZXQgJiYgZ3Vlc3RfY29uZmlnLT5udW1fdm52ZGltbXMpIHsKPiArICAgICAgICByZXQgPSBs aWJ4bF9fcW1wX3F1ZXJ5X252ZGltbXMocW1wKTsKPiArICAgIH0KPiAgICAgIGxpYnhsX19xbXBf Y2xvc2UocW1wKTsKPiAgICAgIHJldHVybiByZXQ7Cj4gIH0KPiAtLSAKPiAyLjEwLjEKPiAKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IFhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwo+IGh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5v cmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=