xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: edgar.iglesias@xilinx.com, sstabellini@kernel.org,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/3] Revert "xen/arm: Map mmio-sram nodes as un-cached memory"
Date: Tue, 31 Jan 2017 20:15:58 +0100	[thread overview]
Message-ID: <20170131191558.GM9606@toto> (raw)
In-Reply-To: <b8cfb710-ac6a-b60d-b848-90b4a876459e@arm.com>

On Tue, Jan 31, 2017 at 04:35:09PM +0000, Julien Grall wrote:
> Hi Edgar,
> 
> On 26/01/17 13:16, Edgar E. Iglesias wrote:
> >From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> >This reverts commit 1e75ed8b64bc1a9b47e540e6f100f17ec6d97f1b.
> 
> I would add a word explain why it is reverted. Something like: "The default
> attribute mapping for MMIO as been relaxed and now rely on the hardware
> domain to set the correct memory attribute".
> 
> Also, your signed-off is missing.

Thanks Julien,

I've fixed this and will send out a v3 shortly.

Best regards,
Edgar


> 
> Cheers,
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-01-31 19:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 13:15 [PATCH v2 0/3] xen/arm: Relax hw domain mapping attributes to p2m_mmio_direct_c Edgar E. Iglesias
2017-01-26 13:16 ` [PATCH v2 1/3] xen/arm: dt: " Edgar E. Iglesias
2017-01-31 16:32   ` Julien Grall
2017-01-26 13:16 ` [PATCH v2 2/3] Revert "xen/arm: Map mmio-sram nodes as un-cached memory" Edgar E. Iglesias
2017-01-31 16:35   ` Julien Grall
2017-01-31 19:15     ` Edgar E. Iglesias [this message]
2017-01-31 22:18     ` Stefano Stabellini
2017-01-31 22:20       ` Edgar E. Iglesias
2017-01-26 13:16 ` [PATCH v2 3/3] xen/arm: acpi: Relax hw domain mapping attributes to p2m_mmio_direct_c Edgar E. Iglesias
2017-01-31 16:36   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170131191558.GM9606@toto \
    --to=edgar.iglesias@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).