From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Andrii Anisov <andrii_anisov@epam.com>,
Andrii Anisov <andrii.anisov@gmail.com>
Subject: Re: [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback
Date: Wed, 1 Feb 2017 10:11:02 -0500 [thread overview]
Message-ID: <20170201151102.GL20958@char.us.ORACLE.com> (raw)
In-Reply-To: <31bd03c7-0b5b-71bd-ef9c-e200121e34da@arm.com>
On Wed, Feb 01, 2017 at 02:30:53PM +0000, Julien Grall wrote:
> Hi Konrad,
>
> On 01/02/2017 14:25, Konrad Rzeszutek Wilk wrote:
> > On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote:
> > > Yup,
> > >
> > > Following is wrong:
> > > > DEBUG macro could be globally across drivers defined by
> > > > CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile.
> > > DEBUG is not defined globally. And there is no debug option to enable
> > > DEBUG in drivers/xen/Makefile.
> > > Should it be added?
> >
> > I am not exactly sure why you guys insist on having this, but
> > the lets leave it as #if 0 along with a comment saying why and what
> > the purpose of this is.
>
> From my understanding, the function has been implemented with the assumption
> of the page will always belongs to the domain and not foreign.
>
> A user will unlikely know that it needs to remove #if 0 in order to check
> the driver is doing the right thing. So I think we should have an easy way
> to enable this code in kernel build.
>
> If you are not happy with the Kconfig, what would be the other way to have
> this enabled without requiring the user to modify the code?
Just leave the #if 0 in the code and add a comment explaining why it is
there.
>
> Cheers,
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-02-01 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:30 [PATCH v3 0/2] XEN SWIOTLB dma operations extension Andrii Anisov
2017-01-31 18:30 ` [PATCH v3 1/2] swiotlb-xen: implement xen_swiotlb_dma_mmap callback Andrii Anisov
2017-01-31 18:39 ` Konrad Rzeszutek Wilk
2017-01-31 19:10 ` Stefano Stabellini
2017-02-01 11:46 ` Andrii Anisov
2017-02-01 14:24 ` Konrad Rzeszutek Wilk
2017-01-31 18:30 ` [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback Andrii Anisov
2017-01-31 18:37 ` Konrad Rzeszutek Wilk
2017-01-31 19:15 ` Stefano Stabellini
2017-01-31 19:17 ` Konrad Rzeszutek Wilk
2017-01-31 19:21 ` Stefano Stabellini
2017-02-01 10:42 ` Andrii Anisov
2017-02-01 10:57 ` Julien Grall
2017-02-01 10:58 ` Julien Grall
2017-02-01 10:19 ` Andrii Anisov
2017-02-01 10:46 ` Andrii Anisov
2017-02-01 14:25 ` Konrad Rzeszutek Wilk
2017-02-01 14:30 ` Julien Grall
2017-02-01 15:11 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201151102.GL20958@char.us.ORACLE.com \
--to=konrad.wilk@oracle.com \
--cc=andrii.anisov@gmail.com \
--cc=andrii_anisov@epam.com \
--cc=julien.grall@arm.com \
--cc=oleksandr.dmytryshyn@globallogic.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).