From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Fatih Acar <fatih.acar@gandi.net>
Subject: [PATCH 1/2] xl: free event in DOMAIN_RESTART_RENAME error path
Date: Thu, 2 Feb 2017 15:46:36 +0000 [thread overview]
Message-ID: <20170202154637.1478-2-wei.liu2@citrix.com> (raw)
In-Reply-To: <20170202154637.1478-1-wei.liu2@citrix.com>
Otherwise it is leaked. Found by code inspection.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Fatih Acar <fatih.acar@gandi.net>
Backport candidate.
---
tools/libxl/xl_cmdimpl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 7e8a8ae5c4..9bf10dfcb2 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -3145,6 +3145,7 @@ start:
case DOMAIN_RESTART_RENAME:
if (domid_soft_reset == INVALID_DOMID &&
!preserve_domain(&domid, event, &d_config)) {
+ libxl_event_free(event);
/* If we fail then exit leaving the old domain in place. */
ret = -1;
goto out;
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-02 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 15:46 [PATCH 0/2] xl: event machinery fixes Wei Liu
2017-02-02 15:46 ` Wei Liu [this message]
2017-02-02 16:22 ` [PATCH 1/2] xl: free event in DOMAIN_RESTART_RENAME error path Wei Liu
2017-02-03 11:57 ` Ian Jackson
2017-02-02 15:46 ` [PATCH 2/2] xl: disable events earlier for shutdown event Wei Liu
2017-02-02 15:52 ` Ian Jackson
2017-02-02 16:00 ` Wei Liu
2017-02-02 16:05 ` Ian Jackson
2017-02-02 16:22 ` Wei Liu
2017-02-02 16:24 ` Ian Jackson
2017-02-03 9:46 ` Fatih Acar
2017-02-03 11:08 ` Wei Liu
2017-02-03 12:06 ` [PATCH 0/2] xl: event machinery fixes Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202154637.1478-2-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=fatih.acar@gandi.net \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).