From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: [PATCH v2] libxl: don't segfault when creating domain with invalid pvusb device Date: Wed, 8 Feb 2017 08:04:04 +0100 Message-ID: <20170208070404.6379-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbMIT-0007cw-6v for xen-devel@lists.xenproject.org; Wed, 08 Feb 2017 07:04:09 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Juergen Gross , wei.liu2@citrix.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Q3JlYXRpbmcgYSBkb21haW4gd2l0aCBhbiBpbnZhbGlkIGNvbnRyb2xsZXIgc3BlY2lmaWNhdGlv biBmb3IgYSBwdnVzYgpkZXZpY2Ugd2lsbCBjdXJyZW50bHkgc2VnZmF1bHQuCgpBdm9pZCB0aGlz IGJ5IGJhaWxpbmcgb3V0IGVhcmx5IGluIGNhc2Ugb2YgYSBtYW5kYXRvcnkgeGVuc3RvcmUgcGF0 aApub3QgZXhpc3RpbmcuCgpTaWduZWQtb2YtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNl LmNvbT4KLS0tClRoaXMgcGF0Y2ggaXMgYSBiYWNrcG9ydCBjYW5kaWRhdGUgZm9yIDQuOAoKVjI6 IGludHJvZHVjZSBsaWJ4bF9feHNfcmVhZF9tYW5kYXRvcnkoKSBhcyBzdWdnZXN0ZWQgYnkgSWFu IEphY2tzb24KLS0tCiB0b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5oIHwgIDYgKysrKysrCiB0 b29scy9saWJ4bC9saWJ4bF91c2IuYyAgICAgIHwgIDYgKysrLS0tCiB0b29scy9saWJ4bC9saWJ4 bF94c2hlbHAuYyAgIHwgMTIgKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDIxIGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxf aW50ZXJuYWwuaCBiL3Rvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFsLmgKaW5kZXggNWY0NjU3OC4u ZDU5MWI3OSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfaW50ZXJuYWwuaAorKysgYi90 b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5oCkBAIC03MzgsNiArNzM4LDEyIEBAIGludCBsaWJ4 bF9feHNfbWtub2QobGlieGxfX2djICpnYywgeHNfdHJhbnNhY3Rpb25fdCB0LAogCiAvKiBPbiBz dWNjZXNzLCAqcmVzdWx0X291dCBjYW1lIGZyb20gdGhlIGdjLgogICogT24gZXJyb3IsICpyZXN1 bHRfb3V0IGlzIHVuZGVmaW5lZC4KKyAqLworaW50IGxpYnhsX194c19yZWFkX21hbmRhdG9yeShs aWJ4bF9fZ2MgKmdjLCB4c190cmFuc2FjdGlvbl90IHQsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKipyZXN1bHRfb3V0KTsKKworLyog T24gc3VjY2VzcywgKnJlc3VsdF9vdXQgY2FtZSBmcm9tIHRoZSBnYy4KKyAqIE9uIGVycm9yLCAq cmVzdWx0X291dCBpcyB1bmRlZmluZWQuCiAgKiBFTk9FTlQgY291bnRzIGFzIHN1Y2Nlc3MgYnV0 IHNldHMgKnJlc3VsdF9vdXQ9MAogICovCiBpbnQgbGlieGxfX3hzX3JlYWRfY2hlY2tlZChsaWJ4 bF9fZ2MgKmdjLCB4c190cmFuc2FjdGlvbl90IHQsCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9s aWJ4bF91c2IuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3VzYi5jCmluZGV4IGVhN2EyYWIuLmQ4OTQ4 ZDUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX3VzYi5jCisrKyBiL3Rvb2xzL2xpYnhs L2xpYnhsX3VzYi5jCkBAIC02NTIsOSArNjUyLDkgQEAgaW50IGxpYnhsX2RldmljZV91c2JjdHJs X2dldGluZm8obGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLAogICAgIHVzYmN0cmxpbmZv LT5kZXZpZCA9IHVzYmN0cmwtPmRldmlkOwogCiAjZGVmaW5lIFJFQURfU1VCUEFUSChwYXRoLCBz dWJwYXRoKSAoeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgIHJj ID0gbGlieGxfX3hzX3JlYWRfY2hlY2tlZChnYywgWEJUX05VTEwsICAgICAgICAgICAgICAgICAg ICAgICBcCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHQ1NQUklOVEYoIiVz LyIgc3VicGF0aCwgcGF0aCksICAgICBcCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAmdG1wKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgICAgIHJjID0g bGlieGxfX3hzX3JlYWRfbWFuZGF0b3J5KGdjLCBYQlRfTlVMTCwgICAgICAgICAgICAgICAgICAg ICBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDU1BSSU5URigiJXMv IiBzdWJwYXRoLCBwYXRoKSwgICBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICZ0bXApOyAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgIGlmIChyYykg Z290byBvdXQ7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc CiAgICAgICAgIChjaGFyICopdG1wOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCiAgICAgfSkKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhs X3hzaGVscC5jIGIvdG9vbHMvbGlieGwvbGlieGxfeHNoZWxwLmMKaW5kZXggYTUwODA1Zi4uYzRh MThkZiAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfeHNoZWxwLmMKKysrIGIvdG9vbHMv bGlieGwvbGlieGxfeHNoZWxwLmMKQEAgLTE5Myw2ICsxOTMsMTggQEAgY2hhciAqbGlieGxfX3hz X2xpYnhsX3BhdGgobGlieGxfX2djICpnYywgdWludDMyX3QgZG9taWQpCiAgICAgcmV0dXJuIHM7 CiB9CiAKK2ludCBsaWJ4bF9feHNfcmVhZF9tYW5kYXRvcnkobGlieGxfX2djICpnYywgeHNfdHJh bnNhY3Rpb25fdCB0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpw YXRoLCBjb25zdCBjaGFyICoqcmVzdWx0X291dCkKK3sKKyAgICBjaGFyICpyZXN1bHQgPSBsaWJ4 bF9feHNfcmVhZChnYywgdCwgcGF0aCk7CisgICAgaWYgKCFyZXN1bHQpIHsKKyAgICAgICAgTE9H RShFUlJPUiwgInhlbnN0b3JlIHJlYWQgZmFpbGVkOiBgJXMnIiwgcGF0aCk7CisgICAgICAgIHJl dHVybiBFUlJPUl9GQUlMOworICAgIH0KKyAgICAqcmVzdWx0X291dCA9IHJlc3VsdDsKKyAgICBy ZXR1cm4gMDsKK30KKwogaW50IGxpYnhsX194c19yZWFkX2NoZWNrZWQobGlieGxfX2djICpnYywg eHNfdHJhbnNhY3Rpb25fdCB0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hh ciAqcGF0aCwgY29uc3QgY2hhciAqKnJlc3VsdF9vdXQpCiB7Ci0tIAoyLjEwLjIKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK