From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/VMX: sanitize VM86 TSS handling
Date: Wed, 15 Feb 2017 10:54:55 +0000 [thread overview]
Message-ID: <20170215105455.GA7967@deinos.phlegethon.org> (raw)
In-Reply-To: <58A41BCF0200007800139F3F@prv-mh.provo.novell.com>
At 01:13 -0700 on 15 Feb (1487121231), Jan Beulich wrote:
> >>> On 14.02.17 at 18:35, <tim@xen.org> wrote:
> > At 06:37 -0700 on 13 Feb (1486967832), Jan Beulich wrote:
> >> >>> On 13.02.17 at 14:19, <JBeulich@suse.com> wrote:
> >> > - tss = mem_alloc(128, 128);
> >> > - memset(tss, 0, 128);
> >> > + tss = mem_alloc(TSS_SIZE, TSS_SIZE);
> >>
> >> tss = mem_alloc(TSS_SIZE, 128);
> >>
> >> is sufficient here, as I've noticed (only) while reviewing Roger's
> >> series v4 of which did trigger the creation of this patch. I've made
> >> the change locally for now.
> >
> > Should Xen check the alignment when the param gets written?
>
> I did think about this too, but then decided not to, since the guest
> would only shoot itself in the foot (the more that in non-root mode
> no actual task switching by the hardware occurs, so the alignment
> requirement is pretty theoretical anyway).
Righto.
Tim.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-15 10:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 13:19 [PATCH] x86/VMX: sanitize VM86 TSS handling Jan Beulich
2017-02-13 13:37 ` Jan Beulich
2017-02-13 13:45 ` Jan Beulich
2017-02-14 17:35 ` Tim Deegan
2017-02-15 8:13 ` Jan Beulich
2017-02-15 10:54 ` Tim Deegan [this message]
2017-02-13 18:26 ` Andrew Cooper
2017-02-14 8:55 ` Jan Beulich
2017-02-14 15:48 ` Andrew Cooper
2017-02-15 8:24 ` Jan Beulich
2017-02-14 17:33 ` Tim Deegan
2017-02-15 8:18 ` Jan Beulich
2017-02-15 11:21 ` Tim Deegan
2017-02-15 11:35 ` Jan Beulich
2017-02-16 11:14 ` Jan Beulich
2017-02-16 11:49 ` Jan Beulich
2017-02-17 10:40 ` Roger Pau Monne
2017-02-20 10:40 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215105455.GA7967@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).