From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 1/3] fuzz/x86emul: avoid race in link farm rune
Date: Thu, 16 Feb 2017 18:56:49 +0000 [thread overview]
Message-ID: <20170216185651.30110-2-wei.liu2@citrix.com> (raw)
In-Reply-To: <20170216185651.30110-1-wei.liu2@citrix.com>
Several `ln -sf` can race with each other and cause error like:
14:43:56 00:07:06 O: ln: cannot remove 'asm': No such file or directory
Provide dedicated targets for soft-linking directories.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/fuzz/x86_instruction_emulator/Makefile | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/fuzz/x86_instruction_emulator/Makefile b/tools/fuzz/x86_instruction_emulator/Makefile
index fede7e9afd..0cd49753cf 100644
--- a/tools/fuzz/x86_instruction_emulator/Makefile
+++ b/tools/fuzz/x86_instruction_emulator/Makefile
@@ -8,12 +8,16 @@ else
x86-instruction-emulator-fuzzer-all:
endif
-x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
+x86_emulate:
[ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .
-asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h:
+x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: x86_emulate
+
+asm:
[ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm
+asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h: asm
+
x86_emulate.c x86_emulate.h: %:
[ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-16 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 18:56 [PATCH 0/3] Fuzz/x86emual and x86emul/test fixes Wei Liu
2017-02-16 18:56 ` Wei Liu [this message]
2017-02-16 19:10 ` [PATCH 1/3] fuzz/x86emul: avoid race in link farm rune Andrew Cooper
2017-02-17 10:12 ` Wei Liu
2017-02-17 10:33 ` Jan Beulich
2017-02-17 11:36 ` Wei Liu
2017-02-17 11:44 ` Jan Beulich
2017-02-20 12:03 ` Wei Liu
2017-02-17 9:24 ` Jan Beulich
2017-02-17 10:12 ` Wei Liu
2017-02-16 18:56 ` [PATCH 2/3] x86emul/test: " Wei Liu
2017-02-16 18:56 ` [PATCH 3/3] gitignore: ignore asm soft link in fuzz and x86emul test Wei Liu
2017-02-17 9:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216185651.30110-2-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).