xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Venu Busireddy <venu.busireddy@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] iommu: Elaborate the usage of RMRR specification on the command line.
Date: Thu, 23 Feb 2017 11:03:30 -0600	[thread overview]
Message-ID: <20170223170329.GA3704@vbusired-lt> (raw)
In-Reply-To: <58AD5F42020000780013CA01@prv-mh.provo.novell.com>

On Wed, Feb 22, 2017 at 01:52:02AM -0700, Jan Beulich wrote:
> >>> On 21.02.17 at 21:42, <venu.busireddy@oracle.com> wrote:
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -1406,6 +1406,15 @@ If segment of the first device is not specified, segment zero will be used.
> >  If other segments are not specified, first device segment will be used.
> >  If a segment is specified for other than the first device and it does not match
> >  the one specified for the first one, an error will be reported.
> > +
> > +'start' and 'end' values are page numbers (not full physical addresses).
> > +If the values are not preceded by "0x", they are treated as decimal.
> 
> Actually I think we should fix the code. I can't see how decimal
> numbers can be useful here, and it is actively confusing with ...

Fixed. I will post v2 for review.

> > +Usage example: If there are two devices 0:0:1d.0 and 0:0:1a.0 that require
> > +pages 0xd5d45 and 0xd5d46 to be reserved respectively, use:
> > +
> > +rmrr=0xd5d45=0:0:1d.0;0xd5d46=0:0:1a.0
> 
> ... the PCI device being specified without 0x prefixes.
> 
> Also can one of the two parts of the example be a range, please?

This too is done. v2 will be posted for review.

Venu


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-02-23 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 20:42 [PATCH] iommu: Elaborate the usage of RMRR specification on the command line Venu Busireddy
2017-02-22  8:52 ` Jan Beulich
2017-02-23 17:03   ` Venu Busireddy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223170329.GA3704@vbusired-lt \
    --to=venu.busireddy@oracle.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).