* [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device
@ 2017-02-23 23:12 Chao Gao
2017-02-24 11:09 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Chao Gao @ 2017-02-23 23:12 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu
Commit 20b75251d97 ("libxl/libxl_pci.c: used LOG*D functions") reverses the
logic to call xc_deassign_device(). It makes the device unusable.
Signed-off-by: Chao Gao <chao.gao@intel.com>
---
tools/libxl/libxl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 8395352..b14df16 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1370,7 +1370,7 @@ static int do_pci_remove(libxl__gc *gc, uint32_t domid,
int hvm = 0, rc, num;
int stubdomid = 0;
uint32_t domainid = domid;
- bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
+ bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
assigned = libxl_device_pci_list(ctx, domid, &num);
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device
2017-02-23 23:12 [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device Chao Gao
@ 2017-02-24 11:09 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2017-02-24 11:09 UTC (permalink / raw)
To: xen-devel, Wei Liu, Ian Jackson
On Fri, Feb 24, 2017 at 07:12:10AM +0800, Chao Gao wrote:
> Commit 20b75251d97 ("libxl/libxl_pci.c: used LOG*D functions") reverses the
> logic to call xc_deassign_device(). It makes the device unusable.
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
Acked + applied.
> ---
> tools/libxl/libxl_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 8395352..b14df16 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1370,7 +1370,7 @@ static int do_pci_remove(libxl__gc *gc, uint32_t domid,
> int hvm = 0, rc, num;
> int stubdomid = 0;
> uint32_t domainid = domid;
> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>
>
> assigned = libxl_device_pci_list(ctx, domid, &num);
> --
> 1.8.3.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-24 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 23:12 [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device Chao Gao
2017-02-24 11:09 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).