From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device
Date: Fri, 24 Feb 2017 11:09:51 +0000 [thread overview]
Message-ID: <20170224110951.io2kk32jt7dei5to@citrix.com> (raw)
In-Reply-To: <20170223231208.GA18953@skl-2s3.sh.intel.com>
On Fri, Feb 24, 2017 at 07:12:10AM +0800, Chao Gao wrote:
> Commit 20b75251d97 ("libxl/libxl_pci.c: used LOG*D functions") reverses the
> logic to call xc_deassign_device(). It makes the device unusable.
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
Acked + applied.
> ---
> tools/libxl/libxl_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 8395352..b14df16 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1370,7 +1370,7 @@ static int do_pci_remove(libxl__gc *gc, uint32_t domid,
> int hvm = 0, rc, num;
> int stubdomid = 0;
> uint32_t domainid = domid;
> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>
>
> assigned = libxl_device_pci_list(ctx, domid, &num);
> --
> 1.8.3.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-02-24 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 23:12 [PATCH] libxl/libxl_pci.c: Fix reverse logic when detaching device Chao Gao
2017-02-24 11:09 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224110951.io2kk32jt7dei5to@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).