From: Wei Liu <wei.liu2@citrix.com>
To: Yi Sun <yi.y.sun@linux.intel.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
he.chen@linux.intel.com, ian.jackson@eu.citrix.com,
mengxu@cis.upenn.edu, jbeulich@suse.com,
chao.p.peng@linux.intel.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v8 06/24] x86: refactor psr: implement get hw info flow.
Date: Sun, 26 Feb 2017 17:41:35 +0000 [thread overview]
Message-ID: <20170226174135.35cmsw6bfrz32vxb@citrix.com> (raw)
In-Reply-To: <1487148579-7243-7-git-send-email-yi.y.sun@linux.intel.com>
On Wed, Feb 15, 2017 at 04:49:21PM +0800, Yi Sun wrote:
[...]
> /* L3 CAT functions implementation. */
> static void l3_cat_init_feature(struct cpuid_leaf regs,
> struct feat_node *feat,
> @@ -225,8 +247,22 @@ static unsigned int l3_cat_get_cos_max(const struct feat_node *feat)
> return feat->info.l3_cat_info.cos_max;
> }
>
> +static bool l3_cat_get_feat_info(const struct feat_node *feat,
> + uint32_t data[], unsigned int array_len)
> +{
> + if ( !data || 3 > array_len )
I don't think this is documented, but this is the first time I see the
constant on the left. Maybe considering swapping it to array_len < 3?
Other than this:
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-26 17:41 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 8:49 [PATCH v8 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c Yi Sun
2017-02-15 8:49 ` [PATCH v8 01/24] docs: create Cache Allocation Technology (CAT) and Code and Data Prioritization (CDP) feature document Yi Sun
2017-02-15 16:49 ` Konrad Rzeszutek Wilk
2017-02-26 17:40 ` Wei Liu
2017-02-15 8:49 ` [PATCH v8 02/24] x86: refactor psr: remove L3 CAT/CDP codes Yi Sun
2017-02-26 17:40 ` Wei Liu
2017-02-15 8:49 ` [PATCH v8 03/24] x86: refactor psr: implement main data structures Yi Sun
2017-02-28 11:58 ` Roger Pau Monné
2017-03-01 5:10 ` Yi Sun
2017-03-01 8:17 ` Jan Beulich
2017-03-01 8:28 ` Yi Sun
2017-03-01 8:39 ` Jan Beulich
2017-03-01 8:49 ` Roger Pau Monn�
2017-03-01 8:54 ` Jan Beulich
2017-03-01 9:00 ` Roger Pau Monn�
2017-02-15 8:49 ` [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow Yi Sun
2017-02-26 17:41 ` Wei Liu
2017-02-27 6:42 ` Yi Sun
2017-02-27 11:45 ` Wei Liu
2017-02-27 8:41 ` Jan Beulich
2017-03-08 14:56 ` Jan Beulich
2017-03-10 1:32 ` Yi Sun
2017-03-10 8:56 ` Jan Beulich
2017-03-13 2:18 ` Yi Sun
2017-02-15 8:49 ` [PATCH v8 05/24] x86: refactor psr: implement Domain init/free and schedule flows Yi Sun
2017-02-26 17:41 ` Wei Liu
2017-03-08 15:04 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 06/24] x86: refactor psr: implement get hw info flow Yi Sun
2017-02-26 17:41 ` Wei Liu [this message]
2017-02-28 12:34 ` Roger Pau Monné
2017-03-08 15:15 ` Jan Beulich
2017-03-10 1:43 ` Yi Sun
2017-03-10 8:57 ` Jan Beulich
2017-03-10 9:01 ` Yi Sun
2017-02-15 8:49 ` [PATCH v8 07/24] x86: refactor psr: implement get value flow Yi Sun
2017-02-28 12:44 ` Roger Pau Monné
2017-03-01 5:21 ` Yi Sun
2017-03-08 15:35 ` Jan Beulich
2017-03-10 1:50 ` Yi Sun
2017-03-10 9:05 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 08/24] x86: refactor psr: set value: implement framework Yi Sun
2017-02-26 17:41 ` Wei Liu
2017-02-27 7:06 ` Yi Sun
2017-02-27 10:55 ` Jan Beulich
2017-02-28 13:58 ` Roger Pau Monné
2017-03-01 6:23 ` Yi Sun
2017-03-08 16:07 ` Jan Beulich
2017-03-10 2:54 ` Yi Sun
2017-03-10 9:09 ` Jan Beulich
2017-03-13 2:36 ` Yi Sun
2017-03-13 12:35 ` Jan Beulich
2017-03-14 2:43 ` Yi Sun
2017-03-14 6:29 ` Jan Beulich
2017-03-14 9:21 ` Yi Sun
2017-03-14 10:24 ` Jan Beulich
2017-03-15 2:52 ` Yi Sun
2017-03-15 7:40 ` Jan Beulich
2017-03-15 8:18 ` Yi Sun
2017-03-15 8:32 ` Jan Beulich
2017-03-10 7:46 ` Yi Sun
2017-03-10 9:10 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 09/24] x86: refactor psr: set value: assemble features value array Yi Sun
2017-02-26 17:43 ` Wei Liu
2017-02-27 7:11 ` Yi Sun
2017-02-27 11:45 ` Wei Liu
2017-03-08 16:54 ` Jan Beulich
2017-03-10 3:21 ` Yi Sun
2017-03-10 9:15 ` Jan Beulich
2017-03-13 2:43 ` Yi Sun
2017-03-13 12:37 ` Jan Beulich
2017-03-14 2:20 ` Yi Sun
2017-03-14 6:32 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 10/24] x86: refactor psr: set value: implement cos finding flow Yi Sun
2017-02-26 17:43 ` Wei Liu
2017-02-27 7:16 ` Yi Sun
2017-03-08 17:03 ` Jan Beulich
2017-03-10 5:35 ` Yi Sun
2017-03-10 9:21 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 11/24] x86: refactor psr: set value: implement cos id picking flow Yi Sun
2017-02-26 17:43 ` Wei Liu
2017-03-09 14:10 ` Jan Beulich
2017-03-10 5:40 ` Yi Sun
2017-03-10 9:24 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 12/24] x86: refactor psr: set value: implement write msr flow Yi Sun
2017-02-15 8:49 ` [PATCH v8 13/24] x86: refactor psr: implement CPU init and free flow for CDP Yi Sun
2017-02-28 14:52 ` Roger Pau Monné
2017-03-09 14:53 ` Jan Beulich
2017-03-10 5:50 ` Yi Sun
2017-02-15 8:49 ` [PATCH v8 14/24] x86: refactor psr: implement get hw info " Yi Sun
2017-02-26 17:43 ` Wei Liu
2017-02-28 14:54 ` Roger Pau Monné
2017-02-15 8:49 ` [PATCH v8 15/24] x86: refactor psr: implement get value " Yi Sun
2017-02-28 14:59 ` Roger Pau Monné
2017-02-15 8:49 ` [PATCH v8 16/24] x86: refactor psr: implement set value callback functions " Yi Sun
2017-02-26 17:43 ` Wei Liu
2017-02-27 7:19 ` Yi Sun
2017-02-15 8:49 ` [PATCH v8 17/24] x86: L2 CAT: implement CPU init and free flow Yi Sun
2017-02-28 15:15 ` Roger Pau Monné
2017-03-01 6:35 ` Yi Sun
2017-03-09 15:04 ` Jan Beulich
2017-03-10 5:52 ` Yi Sun
2017-02-15 8:49 ` [PATCH v8 18/24] x86: L2 CAT: implement get hw info flow Yi Sun
2017-02-28 15:18 ` Roger Pau Monné
2017-03-09 15:13 ` Jan Beulich
2017-03-10 5:57 ` Yi Sun
2017-03-10 9:26 ` Jan Beulich
2017-02-15 8:49 ` [PATCH v8 19/24] x86: L2 CAT: implement get value flow Yi Sun
2017-02-28 15:20 ` Roger Pau Monné
2017-02-15 8:49 ` [PATCH v8 20/24] x86: L2 CAT: implement set " Yi Sun
2017-02-28 15:25 ` Roger Pau Monné
2017-03-01 6:59 ` Yi Sun
2017-03-01 11:31 ` Dario Faggioli
2017-02-15 8:49 ` [PATCH v8 21/24] tools: L2 CAT: support get HW info for L2 CAT Yi Sun
2017-02-15 8:49 ` [PATCH v8 22/24] tools: L2 CAT: support show cbm " Yi Sun
2017-02-15 8:49 ` [PATCH v8 23/24] tools: L2 CAT: support set " Yi Sun
2017-02-15 8:49 ` [PATCH v8 24/24] docs: add L2 CAT description in docs Yi Sun
2017-02-15 16:14 ` [PATCH v8 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c Konrad Rzeszutek Wilk
2017-02-26 18:00 ` Wei Liu
2017-02-28 11:02 ` Roger Pau Monné
2017-03-01 4:54 ` Yi Sun
2017-03-01 8:35 ` Roger Pau Monn�
2017-03-01 8:40 ` Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226174135.35cmsw6bfrz32vxb@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=he.chen@linux.intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).