From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
Christoph Egger <chegger@amazon.de>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 6/7] xen/mce: remove ASSERT's about mce_dhandler_num in mce_action()
Date: Mon, 27 Feb 2017 13:09:11 +0800 [thread overview]
Message-ID: <20170227050912.28824-7-haozhong.zhang@intel.com> (raw)
In-Reply-To: <20170227050912.28824-1-haozhong.zhang@intel.com>
The current production build works fine even though those ASSERT's are
violated. Remove them to make the debug build work as well.
Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
---
Cc: Christoph Egger <chegger@amazon.de>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Changes since v1:
* Remove those ASSERT's rather than making them Intel-only.
---
xen/arch/x86/cpu/mcheck/mce.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 5a7e2ba..a42cabd 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1621,9 +1621,6 @@ static enum mce_result mce_action(const struct cpu_user_regs *regs,
handlers = mce_uhandlers;
}
- /* At least a default handler should be registerd */
- ASSERT(handler_num);
-
local_mi = (struct mc_info*)mctelem_dataptr(mctc);
x86_mcinfo_lookup(mic, local_mi, MC_TYPE_GLOBAL);
if (mic == NULL) {
@@ -1656,7 +1653,6 @@ static enum mce_result mce_action(const struct cpu_user_regs *regs,
break;
}
}
- ASSERT(i != handler_num);
}
return worst_result;
--
2.10.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-27 5:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 5:09 [PATCH v2 0/7] MCE code cleanup and bugfix Haozhong Zhang
2017-02-27 5:09 ` [PATCH v2 1/7] xen/mce: adjust comment of callback register functions Haozhong Zhang
2017-03-01 22:10 ` Konrad Rzeszutek Wilk
2017-02-27 5:09 ` [PATCH v2 2/7] xen/mce: remove unused x86_mcinfo_add() Haozhong Zhang
2017-02-27 5:09 ` [PATCH v2 3/7] x86/mce: set mcinfo_comm.type and .size in x86_mcinfo_reserve() Haozhong Zhang
2017-02-27 5:09 ` [PATCH v2 4/7] x86/vmce: fill MSR_IA32_MCG_STATUS on all vcpus in broadcast case Haozhong Zhang
2017-02-27 5:09 ` [PATCH v2 5/7] x86/mce: clear MSR_IA32_MCG_STATUS by writing 0 Haozhong Zhang
2017-02-27 5:09 ` Haozhong Zhang [this message]
2017-02-28 15:10 ` [PATCH v2 6/7] xen/mce: remove ASSERT's about mce_dhandler_num in mce_action() Jan Beulich
2017-03-08 1:58 ` [PATCH v3 6/7] xen/mce: remove ASSERT's about mce_[u|d]handler_num " Haozhong Zhang
2017-03-08 8:25 ` Jan Beulich
2017-02-27 5:09 ` [PATCH v2 7/7] tools/xen-mceinj: fix the type of cpu number Haozhong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227050912.28824-7-haozhong.zhang@intel.com \
--to=haozhong.zhang@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chegger@amazon.de \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).