xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH 1/3] xl: rename cpurange_parse to parse_cpurange
Date: Mon, 27 Feb 2017 17:47:19 +0000	[thread overview]
Message-ID: <20170227174721.15957-1-wei.liu2@citrix.com> (raw)
In-Reply-To: <22708.19545.469240.122558@mariner.uk.xensource.com>

We want to consistently prefix functions to parse input with "parse_".

No functional change.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 tools/xl/xl_cmdimpl.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/xl/xl_cmdimpl.c b/tools/xl/xl_cmdimpl.c
index 2721af317b..86c70f5a22 100644
--- a/tools/xl/xl_cmdimpl.c
+++ b/tools/xl/xl_cmdimpl.c
@@ -697,7 +697,7 @@ static int update_cpumap_range(const char *str, libxl_bitmap *cpumap)
  * single cpus or as eintire NUMA nodes) and turns it into the
  * corresponding libxl_bitmap (in cpumap).
  */
-static int cpurange_parse(const char *cpu, libxl_bitmap *cpumap)
+static int parse_cpurange(const char *cpu, libxl_bitmap *cpumap)
 {
     char *ptr, *saveptr = NULL, *buf = xstrdup(cpu);
     int rc = 0;
@@ -808,7 +808,7 @@ static void parse_vcpu_affinity(libxl_domain_build_info *b_info,
                 exit(EXIT_FAILURE);
             }
 
-            if (cpurange_parse(buf, &vcpu_affinity_array[j]))
+            if (parse_cpurange(buf, &vcpu_affinity_array[j]))
                 exit(EXIT_FAILURE);
 
             j++;
@@ -825,7 +825,7 @@ static void parse_vcpu_affinity(libxl_domain_build_info *b_info,
             exit(EXIT_FAILURE);
         }
 
-        if (cpurange_parse(buf, &vcpu_affinity_array[0]))
+        if (parse_cpurange(buf, &vcpu_affinity_array[0]))
             exit(EXIT_FAILURE);
 
         for (i = 1; i < b_info->max_vcpus; i++) {
@@ -5522,7 +5522,7 @@ int main_vcpupin(int argc, char **argv)
      */
     if (!strcmp(hard_str, "-"))
         hard = NULL;
-    else if (cpurange_parse(hard_str, hard))
+    else if (parse_cpurange(hard_str, hard))
         goto out;
     /*
      * Soft affinity is handled similarly. Only difference: we also want
@@ -5530,7 +5530,7 @@ int main_vcpupin(int argc, char **argv)
      */
     if (argc <= optind+3 || !strcmp(soft_str, "-"))
         soft = NULL;
-    else if (cpurange_parse(soft_str, soft))
+    else if (parse_cpurange(soft_str, soft))
         goto out;
 
     if (dryrun_only) {
@@ -7793,7 +7793,7 @@ int main_cpupoolcreate(int argc, char **argv)
             n_cpus++;
         }
     } else if (!xlu_cfg_get_string(config, "cpus", &buf, 0)) {
-        if (cpurange_parse(buf, &cpumap))
+        if (parse_cpurange(buf, &cpumap))
             goto out_cfg;
 
         n_cpus = 0;
@@ -7974,7 +7974,7 @@ int main_cpupoolcpuadd(int argc, char **argv)
     }
 
     pool = argv[optind++];
-    if (cpurange_parse(argv[optind], &cpumap))
+    if (parse_cpurange(argv[optind], &cpumap))
         goto out;
 
     if (libxl_cpupool_qualifier_to_cpupoolid(ctx, pool, &poolid, NULL) ||
@@ -8012,7 +8012,7 @@ int main_cpupoolcpuremove(int argc, char **argv)
     }
 
     pool = argv[optind++];
-    if (cpurange_parse(argv[optind], &cpumap))
+    if (parse_cpurange(argv[optind], &cpumap))
         goto out;
 
     if (libxl_cpupool_qualifier_to_cpupoolid(ctx, pool, &poolid, NULL) ||
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-27 17:49 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 16:12 [PATCH 00/29] Refactor xl code Wei Liu
2017-02-24 16:12 ` [PATCH 01/29] xl: remove accidentally committed hunk from Makefile Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 02/29] xl: update copyright information Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 03/29] xl: remove inclusion of libxl_osdeps.h Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 04/29] xl: use <> variant to include Xen tools library headers Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 05/29] xl: generate _paths.h Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 06/29] xl: remove trailing spaces in xl_cmdimpl.c Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 07/29] xl: lift a bunch of macros to xl_utils.h Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 08/29] xl: move some helper functions to xl_utils.c Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-27 17:44     ` [PATCH] " Wei Liu
2017-02-28 10:32       ` Ian Jackson
2017-02-24 16:12 ` [PATCH 09/29] xl: split out tmem related code to xl_tmem.c Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 10/29] xl: split out xl_parse.[ch] Wei Liu
2017-02-27 15:57   ` Ian Jackson
2017-02-27 17:47     ` Wei Liu [this message]
2017-02-27 17:47       ` [PATCH 2/3] xl: introduce a function to get shutdown action name Wei Liu
2017-02-27 18:11         ` Ian Jackson
2017-02-27 17:47       ` [PATCH 3/3] xl: split out xl_parse.[ch] Wei Liu
2017-02-27 18:11         ` Ian Jackson
2017-02-27 18:11       ` [PATCH 1/3] xl: rename cpurange_parse to parse_cpurange Ian Jackson
2017-02-24 16:12 ` [PATCH 11/29] xl: split out cpupool related code Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 12/29] xl: split out flask " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 13/29] xl: split out vtpm " Wei Liu
2017-02-27 15:55   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 14/29] xl: split out block " Wei Liu
2017-02-27 15:58   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 15/29] xl: split out network " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 16/29] xl: split out usb " Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 17/29] xl: split out scheduler " Wei Liu
2017-02-27 15:57   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 18/29] xl: split out pci " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 19/29] xl: split out vcpu " Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 20/29] xl: split out cd " Wei Liu
2017-02-27 15:56   ` Ian Jackson
2017-02-27 16:23     ` Wei Liu
2017-02-27 16:36       ` Ian Jackson
2017-02-27 16:38         ` Wei Liu
2017-02-27 16:44           ` Ian Jackson
2017-02-27 16:45             ` Wei Liu
2017-02-24 16:13 ` [PATCH 21/29] xl: split out memory " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 22/29] xl: split out psr " Wei Liu
2017-02-27 15:55   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 23/29] xl: split out functions to print out information Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 24/29] xl: split out vnc and console related code Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-27 17:48     ` [PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer Wei Liu
2017-02-27 17:48       ` [PATCH 2/2] xl: split out vnc and console related code Wei Liu
2017-02-27 18:13         ` Ian Jackson
2017-02-27 18:12       ` [PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer Ian Jackson
2017-02-24 16:13 ` [PATCH 25/29] xl: split out miscellaneous functions Wei Liu
2017-02-27 15:58   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 26/29] xl: split out vm lifecycle control functions Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 27/29] xl: split out save/restore related code Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 28/29] xl: split out migration " Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 29/29] xl: merge xl_cmdimpl.c into xl.c Wei Liu
2017-02-27 15:58   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227174721.15957-1-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).