xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Cc: xen-devel@lists.xenproject.org,
	Julien Grall <julien.grall@arm.com>,
	nd@arm.com, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/1] xen/arm: Add pl011 uart support in Xen for guest domains
Date: Tue, 28 Feb 2017 16:21:43 -0500	[thread overview]
Message-ID: <20170228212143.GC25998@char.us.oracle.com> (raw)
In-Reply-To: <CACtJ1JQxWG90+9jUbXzeHK_+6tBpp70qDKyxGB_8B+DyofUgDw@mail.gmail.com>

On Mon, Feb 20, 2017 at 08:53:50PM +0530, Bhupinder Thakur wrote:
> Hi,
> 
> 
> On 17 February 2017 at 20:59, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >> >>>>    Should vpl011.h be in include/xen/public/ ? If so you need
> >> >>>>    a different license for that file.
> >> >>>>
> >> I have moved the file from the public folder and keeping it in xen/arch/arm/
> >
> > Huh? But if this is a ring protocol that is used by an OS that is not
> > part of of Xen tree it needs to be in public/io/ location.
> >
> > Otherwise you may run in problems with different licenses (public/io
> > has BSD license while arch/arm is GPL) - and it may be that your
> > 'console backend' is proprietary.
> 
> xen/include/public/console/io.h contains the definition of the ring
> structure (xencons_interface) which is used by the xenconsoled running
> on the dom0 OS. The definitions in vpl011.h are used locally by the

..and also in the Linux code - as the PV frontend.

> emulation code in Xen including one ring structure which is defined
> same as the one defined in the public folder.

.. Aaah. Then it should still be accessible from the xenconsold and to
be in the common code.
> 
> Regards,
> Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-28 21:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 18:09 [PATCH 0/1] xen/arm: Add pl011 uart support in Xen for guest domains Bhupinder Thakur
2017-02-06 18:09 ` [PATCH 1/1] " Bhupinder Thakur
2017-02-06 18:30   ` Julien Grall
2017-02-06 18:35   ` Konrad Rzeszutek Wilk
2017-02-15  7:23     ` Bhupinder Thakur
2017-02-15 15:38       ` Konrad Rzeszutek Wilk
2017-02-16 14:34         ` Julien Grall
2017-02-17 12:35           ` Bhupinder Thakur
2017-02-17 15:29             ` Konrad Rzeszutek Wilk
2017-02-20 15:23               ` Bhupinder Thakur
2017-02-28 21:21                 ` Konrad Rzeszutek Wilk [this message]
2017-02-17 15:27           ` Konrad Rzeszutek Wilk
2017-02-26 20:50             ` Julien Grall
2017-02-28 21:22               ` Konrad Rzeszutek Wilk
2017-03-01 10:51                 ` Bhupinder Thakur
2017-03-01 16:44                   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228212143.GC25998@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=bhupinder.thakur@linaro.org \
    --cc=julien.grall@arm.com \
    --cc=nd@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).