From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH 4/5] xl: lift common_domname declaration to xl.h
Date: Wed, 1 Mar 2017 10:24:54 +0000 [thread overview]
Message-ID: <20170301102455.2224-5-wei.liu2@citrix.com> (raw)
In-Reply-To: <20170301102455.2224-1-wei.liu2@citrix.com>
No functional change.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/xl/xl.h | 1 +
tools/xl/xl_migrate.c | 2 --
tools/xl/xl_misc.c | 2 --
tools/xl/xl_utils.c | 1 -
tools/xl/xl_vmcontrol.c | 1 -
5 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 65b89ce717..3869776395 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -210,6 +210,7 @@ int main_qemu_monitor_command(int argc, char **argv);
void help(const char *command);
+extern const char *common_domname;
extern struct cmd_spec cmd_table[];
extern int cmdtable_len;
/* Look up a command in the table, allowing unambiguous truncation */
diff --git a/tools/xl/xl_migrate.c b/tools/xl/xl_migrate.c
index 28fb8230b6..065bd66aea 100644
--- a/tools/xl/xl_migrate.c
+++ b/tools/xl/xl_migrate.c
@@ -30,8 +30,6 @@
#include "xl_utils.h"
#include "xl_parse.h"
-extern const char *common_domname;
-
#ifndef LIBXL_HAVE_NO_SUSPEND_RESUME
static pid_t create_migration_child(const char *rune, int *send_fd,
diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
index 70fcc3026b..9037e2b2f0 100644
--- a/tools/xl/xl_misc.c
+++ b/tools/xl/xl_misc.c
@@ -23,8 +23,6 @@
#include "xl_utils.h"
#include "xl_parse.h"
-extern const char *common_domname;
-
static void button_press(uint32_t domid, const char *b)
{
libxl_trigger trigger;
diff --git a/tools/xl/xl_utils.c b/tools/xl/xl_utils.c
index 481b7bb50f..f79f08029f 100644
--- a/tools/xl/xl_utils.c
+++ b/tools/xl/xl_utils.c
@@ -28,7 +28,6 @@
#include "xl_utils.h"
extern int logfile;
-extern const char *common_domname;
void dolog(const char *file, int line, const char *func, char *fmt, ...)
{
diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index a3f27ad786..81a9af7705 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -31,7 +31,6 @@
#include "xl_parse.h"
extern int logfile;
-extern const char *common_domname;
static int fd_lock = -1;
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-01 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 10:24 [PATCH 0/5] xl cleanup and docs Wei Liu
2017-03-01 10:24 ` [PATCH 1/5] CONTRIBUTING: list xl in inbound license section Wei Liu
2017-03-01 10:24 ` [PATCH 2/5] xl: add CODING_STYLE Wei Liu
2017-03-01 10:24 ` [PATCH 3/5] xl: remove declaration of ctx in c files Wei Liu
2017-03-01 10:24 ` Wei Liu [this message]
2017-03-01 10:24 ` [PATCH 5/5] xl: lift logfile declaration to xl.h Wei Liu
2017-03-02 12:56 ` [PATCH 0/5] xl cleanup and docs Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301102455.2224-5-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).