* [PATCH] tools/libxendevicemodel: define O_CLOEXEC
@ 2017-03-01 12:27 Olaf Hering
2017-03-01 12:37 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2017-03-01 12:27 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Olaf Hering, Ian Jackson
Similar defines are already used elsewhere.
Fixes e7745d8ef5 ("tools/libxendevicemodel: introduce a Linux-specific
implementation")
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/libs/devicemodel/linux.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/libs/devicemodel/linux.c b/tools/libs/devicemodel/linux.c
index 438c55bf2c..0fdc7121f1 100644
--- a/tools/libs/devicemodel/linux.c
+++ b/tools/libs/devicemodel/linux.c
@@ -31,6 +31,10 @@
#include "private.h"
+#ifndef O_CLOEXEC
+#define O_CLOEXEC 0
+#endif
+
int osdep_xendevicemodel_open(xendevicemodel_handle *dmod)
{
int fd = open("/dev/xen/privcmd", O_RDWR | O_CLOEXEC);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools/libxendevicemodel: define O_CLOEXEC
2017-03-01 12:27 [PATCH] tools/libxendevicemodel: define O_CLOEXEC Olaf Hering
@ 2017-03-01 12:37 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2017-03-01 12:37 UTC (permalink / raw)
To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, xen-devel
On Wed, Mar 01, 2017 at 12:27:08PM +0000, Olaf Hering wrote:
> Similar defines are already used elsewhere.
I think I would like to change this a bit to be more explicit:
Some libc headers don't have O_CLOEXEC, we need to take care of it by
defining to 0 (on the ground that such glibc might barf on O_CLOEXEC).
If you don't object, I will use the above paragraph.
> Fixes e7745d8ef5 ("tools/libxendevicemodel: introduce a Linux-specific
> implementation")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libs/devicemodel/linux.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/libs/devicemodel/linux.c b/tools/libs/devicemodel/linux.c
> index 438c55bf2c..0fdc7121f1 100644
> --- a/tools/libs/devicemodel/linux.c
> +++ b/tools/libs/devicemodel/linux.c
> @@ -31,6 +31,10 @@
>
> #include "private.h"
>
> +#ifndef O_CLOEXEC
> +#define O_CLOEXEC 0
> +#endif
> +
> int osdep_xendevicemodel_open(xendevicemodel_handle *dmod)
> {
> int fd = open("/dev/xen/privcmd", O_RDWR | O_CLOEXEC);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-01 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-01 12:27 [PATCH] tools/libxendevicemodel: define O_CLOEXEC Olaf Hering
2017-03-01 12:37 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).