Re: [PATCH RFC 4/5] x86: split PVH dom0 builder to domain_build_pv.c

[Wei Liu <wei.liu2@citrix.com>]

On Fri, Mar 03, 2017 at 11:16:39AM +0000, Roger Pau Monné wrote:
> On Fri, Mar 03, 2017 at 09:41:10AM +0000, Wei Liu wrote:
> > Long term we want to be able to disentangle PV and HVM code. Move the
> > PVH domain builder to a dedicated file. It will later depends on
> > CONFIG_HVM or CONFIG_PVH.
> > 
> > This in turn requires exposing a few functions and variables via
> > domain_build.h.
> 
> Again I would add something along the lines: "No functional changes expected".
> 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  xen/arch/x86/Makefile           |    1 +
> >  xen/arch/x86/domain_build.c     | 1068 +------------------------------------
> >  xen/arch/x86/domain_build.h     |    8 +
> >  xen/arch/x86/domain_build_pvh.c | 1097 +++++++++++++++++++++++++++++++++++++++
> 
> I would prefer that to be in arch/x86/hvm/.
> 
> > diff --git a/xen/arch/x86/domain_build_pvh.c b/xen/arch/x86/domain_build_pvh.c
> > new file mode 100644
> > index 0000000000..6cd3ff2ef2
> > --- /dev/null
> > +++ b/xen/arch/x86/domain_build_pvh.c
> > @@ -0,0 +1,1097 @@
> > +/******************************************************************************
> > + * domain_build_pvh.c
> > + */
> 
> Since you are already touching this, and it's mostly my code, I would rather
> prefer that you add the following header:
> 
> /******************************************************************************
>  * arch/x86/hvm/domain_build.c
>  *
>  * PVH domain builder
>  *
>  * This program is free software; you can redistribute it and/or modify
>  * it under the terms of the GNU General Public License as published by
>  * the Free Software Foundation; either version 2 of the License, or
>  * (at your option) any later version.

I suggest we use the inbound licence listed in CONTRIBUTING. I think it
is GPL v2 only, without the any later version part.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel