From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
roger.pau@citrix.com
Subject: Re: [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c
Date: Fri, 3 Mar 2017 14:45:22 +0000 [thread overview]
Message-ID: <20170303144522.c64q4psmfstbbzi7@citrix.com> (raw)
In-Reply-To: <58B98CCF020000780013FD77@prv-mh.provo.novell.com>
On Fri, Mar 03, 2017 at 07:33:35AM -0700, Jan Beulich wrote:
> >>> On 03.03.17 at 14:35, <wei.liu2@citrix.com> wrote:
> > On Fri, Mar 03, 2017 at 04:15:19AM -0700, Jan Beulich wrote:
> >> >>> On 03.03.17 at 12:06, <roger.pau@citrix.com> wrote:
> >> > On Fri, Mar 03, 2017 at 09:41:09AM +0000, Wei Liu wrote:
> >> However, with ...
> >>
> >> >> diff --git a/xen/arch/x86/domain_build_pv.c b/xen/arch/x86/domain_build_pv.c
> >> >
> >> > I would place this in arch/xen/x86/pv/domain_build.c
> >>
> >> ... this the case becomes less clear: Personally I'm not a fan of
> >> #include "../file.h", so I wouldn't be certain which of the two is
> >> the less undesirable place for the header.
> >>
> >
> > But in this case I would prefer to move the to xen/include/xen and named
> > in dom0_build.h.
>
> Well, it's x86_specific, so if anything include/asm-x86/.
>
OK.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-03 14:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 9:41 [PATCH RFC 0/5] Refactor x86 domain builder Wei Liu
2017-03-03 9:41 ` [PATCH RFC 1/5] xen: move round_pg{up,down} to pfn.h Wei Liu
2017-03-03 10:05 ` [PATCH RFC 1/5] xen: move round_pg{up, down} " Jan Beulich
2017-03-03 10:15 ` Wei Liu
2017-03-03 9:41 ` [PATCH RFC 2/5] xen: include xen/types.h in domain.h Wei Liu
2017-03-03 10:05 ` Jan Beulich
2017-03-03 9:41 ` [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c Wei Liu
2017-03-03 11:06 ` Roger Pau Monné
2017-03-03 11:15 ` Jan Beulich
2017-03-03 13:35 ` Wei Liu
2017-03-03 14:33 ` Jan Beulich
2017-03-03 14:45 ` Wei Liu [this message]
2017-03-03 14:49 ` Andrew Cooper
2017-03-03 15:15 ` Jan Beulich
2017-03-03 17:08 ` Wei Liu
2017-03-03 16:16 ` Jan Beulich
2017-03-03 9:41 ` [PATCH RFC 4/5] x86: split PVH " Wei Liu
2017-03-03 11:16 ` Roger Pau Monné
2017-03-03 13:39 ` Wei Liu
2017-03-03 15:38 ` Roger Pau Monné
2017-03-03 16:18 ` Jan Beulich
2017-03-03 9:41 ` [PATCH RFC 5/5] x86: clean up header files in domain_build.c Wei Liu
2017-03-03 16:18 ` Jan Beulich
2017-03-03 10:02 ` [PATCH RFC 0/5] Refactor x86 domain builder Jan Beulich
2017-03-03 10:56 ` Andrew Cooper
2017-03-03 11:06 ` Jan Beulich
2017-03-03 13:41 ` Wei Liu
2017-03-03 14:34 ` Jan Beulich
2017-03-03 14:45 ` Wei Liu
2017-03-03 11:06 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303144522.c64q4psmfstbbzi7@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).