Re: [PATCH 05/11] xen/arm: vpl011: Initialize nr_spis in vgic_init in Xen to atleast 1

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Feb 21, 2017 at 04:56:02PM +0530, Bhupinder Thakur wrote:
> Ensure that nr_spis intialized in in vgic_init is atleast 1 to allow allocation of

s/atleast/at least/

> pl011 spi virq.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
> ---
>  xen/arch/arm/vgic.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 364d5f0..614b3ec 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -121,6 +121,11 @@ int domain_vgic_init(struct domain *d, unsigned int nr_spis)
>      /* Limit the number of virtual SPIs supported to (1020 - 32) = 988  */
>      if ( nr_spis > (1020 - NR_LOCAL_IRQS) )
>          return -EINVAL;
> +#ifdef CONFIG_VPL011_CONSOLE
> +    /* Atleast 1 spi should be available for assigning to vpl011 */

Add period at the end please.

> +    else if ( nr_spis < (1020 - NR_LOCAL_IRQS) )
> +        nr_spis += 1;

So say the nr_spis is 988, you increase it to 989 but that means
the first check which checked against that is not being enforced.

Is that OK? Should it be reflected somewhere in a documentation?
Perhaps in the xen_arch_domainconfig structure to mention this?

> +#endif
>  
>      d->arch.vgic.nr_spis = nr_spis;
>  
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel