xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path
Date: Fri, 17 Mar 2017 11:02:22 +0000	[thread overview]
Message-ID: <20170317110223.25130-4-wei.liu2@citrix.com> (raw)
In-Reply-To: <20170317110223.25130-1-wei.liu2@citrix.com>

A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest.
Now that PVHv1 is gone, undo that bodge and remove the fixme.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 0d54baf20e..c785b3f353 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -3537,7 +3537,7 @@ static void nmi_hwdom_report(unsigned int reason_idx)
 {
     struct domain *d = hardware_domain;
 
-    if ( !d || !d->vcpu || !d->vcpu[0] || !is_pv_domain(d) /* PVH fixme */ )
+    if ( !d || !d->vcpu || !d->vcpu[0] )
         return;
 
     set_bit(reason_idx, nmi_reason(d));
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-03-17 11:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 11:02 [PATCH 0/4] Remove PVHv1 residuals Wei Liu
2017-03-17 11:02 ` [PATCH 1/4] docs: update dmop.markdown Wei Liu
2017-03-17 11:30   ` Paul Durrant
2017-03-17 11:32     ` Andrew Cooper
2017-03-17 11:40       ` Paul Durrant
2017-03-17 11:02 ` [PATCH 2/4] sched.h: remove stale PVHv1 comment Wei Liu
2017-03-17 11:02 ` Wei Liu [this message]
2017-03-17 11:06   ` [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path Andrew Cooper
2017-03-17 11:10     ` Wei Liu
2017-03-17 11:11       ` Andrew Cooper
2017-03-17 11:14         ` Wei Liu
2017-03-17 11:26           ` Jan Beulich
2017-03-17 11:29             ` Wei Liu
2017-03-17 11:31               ` Andrew Cooper
2017-03-17 11:34                 ` Wei Liu
2017-03-17 11:35               ` Roger Pau Monné
2017-03-17 11:22       ` Roger Pau Monné
2017-03-17 11:02 ` [PATCH 4/4] x86: remove stale PVHv1 comment from PV domain builder Wei Liu
2017-03-17 11:05 ` [PATCH 0/4] Remove PVHv1 residuals Jan Beulich
2017-03-17 11:07   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317110223.25130-4-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).