From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 2/5] x86: modify setup_dom0_vcpu to use dom0_cpus internally
Date: Mon, 20 Mar 2017 15:20:47 +0000 [thread overview]
Message-ID: <20170320152046.yxi7qdcscftpfbdg@citrix.com> (raw)
In-Reply-To: <58D0011F0200007800145340@prv-mh.provo.novell.com>
On Mon, Mar 20, 2017 at 09:19:43AM -0600, Jan Beulich wrote:
> >>> On 20.03.17 at 15:14, <wei.liu2@citrix.com> wrote:
> > @@ -1155,8 +1157,10 @@ static int __init construct_dom0_pv(
> > cpu = v->processor;
> > for ( i = 1; i < d->max_vcpus; i++ )
> > {
> > - cpu = cpumask_cycle(cpu, &dom0_cpus);
> > - setup_dom0_vcpu(d, i, cpu);
> > + struct vcpu *p = setup_dom0_vcpu(d, i, cpu);
>
> While not a big deal, as said, this would better be const. With
> that
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
Sorry I missed that. I will make the changes while I commit these
patches.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-20 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 14:14 [PATCH v3 0/5] Refactor x86 dom0 builder Wei Liu
2017-03-20 14:14 ` [PATCH v3 1/5] x86: rename domain_build.c to dom0_build.c Wei Liu
2017-03-20 14:14 ` [PATCH v3 2/5] x86: modify setup_dom0_vcpu to use dom0_cpus internally Wei Liu
2017-03-20 14:21 ` Andrew Cooper
2017-03-20 15:19 ` Jan Beulich
2017-03-20 15:20 ` Wei Liu [this message]
2017-03-20 14:14 ` [PATCH v3 3/5] x86: split PV dom0 builder to pv/dom0_builder.c Wei Liu
2017-03-20 14:43 ` Andrew Cooper
2017-03-20 14:14 ` [PATCH v3 4/5] x86: split PVH dom0 builder to hvm/dom0_build.c Wei Liu
2017-03-20 14:51 ` Andrew Cooper
2017-03-20 14:14 ` [PATCH v3 5/5] x86: clean up header files in dom0_build.c Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320152046.yxi7qdcscftpfbdg@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).