From: Haozhong Zhang <haozhong.zhang@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 09/12] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP
Date: Tue, 21 Mar 2017 15:14:36 +0800 [thread overview]
Message-ID: <20170321071436.43zykjoitt24ejii@hz-desktop> (raw)
In-Reply-To: <58D0125F0200007800145479@prv-mh.provo.novell.com>
On 03/20/17 10:33 -0600, Jan Beulich wrote:
> >>> On 17.03.17 at 07:46, <haozhong.zhang@intel.com> wrote:
> > --- a/xen/include/public/hvm/params.h
> > +++ b/xen/include/public/hvm/params.h
> > @@ -259,6 +259,11 @@
> > */
> > #define HVM_PARAM_VM86_TSS_SIZED 37
> >
> > -#define HVM_NR_PARAMS 38
> > +/* Enable MCA capabilities. */
> > +#define HVM_PARAM_MCA_CAP 38
> > +#define HVMMCA_CAP_LMCE (1UL << 27)
>
> How come this is bit 27 rather than bit 0? Further, to match up with
> other, future definitions here, I think you mean 1ULL (or, to be
> precise, xen_mk_ullong()).
>
I intended to use the same bit in MSR_IA32_MCG_CAP to clarify its
semantic, but I realize it's unnecessary as I still need to introduce
HVMMCA_CAP_* for each bit.
Thanks,
Haozhong
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-21 7:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 6:46 [PATCH v2 00/12] Add LMCE support Haozhong Zhang
2017-03-17 6:46 ` [PATCH v2 01/12] xen/mce: switch bool_t/1/0 to bool/true/false Haozhong Zhang
2017-03-20 13:04 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 02/12] x86/mce_intel: refine messages of MCA capabilities Haozhong Zhang
2017-03-20 13:10 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 03/12] xen/mce: add blank lines between non-fall-through switch case blocks Haozhong Zhang
2017-03-20 13:12 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 04/12] x86/mce: handle LMCE locally Haozhong Zhang
2017-03-20 14:24 ` Jan Beulich
2017-03-21 7:04 ` Haozhong Zhang
2017-03-17 6:46 ` [PATCH v2 05/12] x86/mce_intel: detect and enable LMCE on Intel host Haozhong Zhang
2017-03-20 14:30 ` Jan Beulich
2017-03-21 7:06 ` Haozhong Zhang
2017-03-21 8:05 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 06/12] x86/vmx: expose LMCE feature via guest MSR_IA32_FEATURE_CONTROL Haozhong Zhang
2017-03-20 16:10 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 07/12] x86/vmce: emulate MSR_IA32_MCG_EXT_CTL Haozhong Zhang
2017-03-20 16:17 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 08/12] x86/vmce: enable injecting LMCE to guest on Intel host Haozhong Zhang
2017-03-20 16:25 ` Jan Beulich
2017-03-22 9:19 ` Haozhong Zhang
2017-03-17 6:46 ` [PATCH v2 09/12] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP Haozhong Zhang
2017-03-20 16:33 ` Jan Beulich
2017-03-21 7:14 ` Haozhong Zhang [this message]
2017-03-20 18:27 ` Ian Jackson
2017-03-21 7:29 ` Haozhong Zhang
2017-03-21 7:35 ` Haozhong Zhang
2017-03-21 9:30 ` Jan Beulich
2017-03-27 15:34 ` Wei Liu
2017-03-17 6:46 ` [PATCH v2 10/12] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2 Haozhong Zhang
2017-03-20 16:37 ` Jan Beulich
2017-03-17 6:46 ` [PATCH v2 11/12] tools/libxc: add support of injecting MC# to specified CPUs Haozhong Zhang
2017-03-28 14:07 ` Wei Liu
2017-03-17 6:46 ` [PATCH v2 12/12] tools/xen-mceinj: add support of injecting LMCE Haozhong Zhang
2017-03-28 14:08 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321071436.43zykjoitt24ejii@hz-desktop \
--to=haozhong.zhang@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).