From: Ingo Molnar <mingo@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Juergen Gross <jgross@suse.com>, Len Brown <len.brown@intel.com>,
hpa@zytor.com, linux-pm@vger.kernel.org, x86@kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
jpoimboe@redhat.com, xen-devel@lists.xenproject.org,
tglx@linutronix.de, Jiri Slaby <jslaby@suse.cz>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data
Date: Wed, 22 Mar 2017 08:25:57 +0100 [thread overview]
Message-ID: <20170322072557.GA13904__23859.8170727075$1490167622$gmane$org@gmail.com> (raw)
In-Reply-To: <20170321140840.GA23311@amd>
* Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> > -ENTRY(saved_rbp) .quad 0
> > -ENTRY(saved_rsi) .quad 0
> > -ENTRY(saved_rdi) .quad 0
> > -ENTRY(saved_rbx) .quad 0
> > +SYM_DATA_START(saved_rbp) .quad 0
> > +SYM_DATA_START(saved_rsi) .quad 0
> > +SYM_DATA_START(saved_rdi) .quad 0
> > +SYM_DATA_START(saved_rbx) .quad 0
>
> Does it make sense to call it SYM_DATA_*START* when there's no
> corresponding end?
That looks like a bug - I think we should strive for them to always be in pairs.
Jiri, Josh, could objtool help here perhaps, to detect 'non-terminated'
SYM_*_START() uses? This could be done by emitting debug data into a special
section and then analyzing that section for unpaired entries. The section can be
discarded in the final link, it won't show up in the kernel image.
We don't ever nest symbols, right?
> Plus... it looks like saved_rsi (and friends) are only used inside
> wakeup_64.S. Could we just delete the "ENTRY" annotations?
That appears to make sense as well.
Thanks,
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-22 7:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9ea5e137-61f9-dccc-bb9d-ac3ff86e5867@suse.cz>
2017-03-20 12:32 ` [PATCH v2 01/10] linkage: new macros for assembler symbols Jiri Slaby
[not found] ` <20170320123222.15453-1-jslaby@suse.cz>
2017-03-20 12:32 ` [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data Jiri Slaby
2017-03-20 13:32 ` Josh Poimboeuf
2017-03-20 15:32 ` Jiri Slaby
2017-03-20 16:07 ` Josh Poimboeuf
2017-03-21 14:08 ` Pavel Machek
2017-03-22 7:25 ` Ingo Molnar [this message]
[not found] ` <20170322072557.GA13904@gmail.com>
2017-03-22 7:39 ` Jiri Slaby
[not found] ` <ee3242f9-1fab-f3a8-947d-85fc1a660a49@suse.cz>
2017-03-22 7:46 ` Ingo Molnar
[not found] ` <20170322074616.GA10809@gmail.com>
2017-03-22 14:11 ` Josh Poimboeuf
[not found] ` <20170322141123.opss3u4gpupqgl2q@treble>
2017-03-22 15:01 ` Jiri Slaby
[not found] ` <049e6c03-8d7d-e869-96bd-0a98e6471227@suse.cz>
2017-03-22 15:33 ` Josh Poimboeuf
2017-03-23 7:38 ` Ingo Molnar
[not found] ` <20170323073819.GA14258@gmail.com>
2017-03-23 13:24 ` Josh Poimboeuf
2017-03-22 12:06 ` Jiri Slaby
[not found] ` <fd0cb783-b07f-f636-04a8-d8a115de1a17@suse.cz>
2017-03-22 15:52 ` Pavel Machek
2017-03-20 12:32 ` [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Jiri Slaby
2017-03-20 12:32 ` [PATCH v2 07/10] x86: assembly, annotate aliases Jiri Slaby
[not found] ` <20170320123222.15453-3-jslaby@suse.cz>
2017-03-21 14:48 ` [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Josh Poimboeuf
[not found] ` <20170321144841.oeaqqarhgzyhehth@treble>
2017-03-22 7:29 ` Ingo Molnar
2017-03-22 14:26 ` Josh Poimboeuf
[not found] ` <20170322142610.bo5c6wzlbqnxrgt3@treble>
2017-03-22 15:44 ` Jiri Slaby
2017-04-10 11:23 ` Jiri Slaby
[not found] ` <b7800998-2a60-b967-10fc-482ebd6fadf0@suse.cz>
2017-04-10 19:35 ` Josh Poimboeuf
[not found] ` <20170410193512.d67vefxedoockybg@treble>
2017-04-12 6:24 ` Jiri Slaby
[not found] ` <e79c90da-6785-e888-2f77-a5f2083698e0@suse.cz>
2017-04-12 6:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20170322072557.GA13904__23859.8170727075$1490167622$gmane$org@gmail.com' \
--to=mingo@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).