From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kurz Subject: Re: [Qemu-devel] [PATCH v4 0/8] xen/9pfs: introduce the Xen 9pfs backend Date: Wed, 22 Mar 2017 09:47:24 +0100 Message-ID: <20170322094724.5f1f5cf9@bahia.lan> References: <20170321112000.56a9737f@bahia.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7864158591107570944==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqbvc-00030r-OF for xen-devel@lists.xenproject.org; Wed, 22 Mar 2017 08:47:36 +0000 Received: from player787.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id E6CF6B9516 for ; Wed, 22 Mar 2017 09:47:34 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org, jgross@suse.com, aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org --===============7864158591107570944== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/PZrGvFJArs_+YGbOXix+9b."; protocol="application/pgp-signature" --Sig_/PZrGvFJArs_+YGbOXix+9b. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 21 Mar 2017 13:14:02 -0700 (PDT) Stefano Stabellini wrote: > On Tue, 21 Mar 2017, Greg Kurz wrote: > > On Mon, 20 Mar 2017 11:18:46 -0700 (PDT) > > Stefano Stabellini wrote: > > =20 > > > Hi all, > > >=20 > > > This patch series implements a new transport for 9pfs, aimed at Xen > > > systems. > > >=20 > > > The transport is based on a traditional Xen frontend and backend driv= ers > > > pair. This patch series implements the backend, which typically runs = in > > > Dom0. I sent another series to implement the frontend in Linux > > > (http://marc.info/?l=3Dlinux-kernel&m=3D148883047125960&w=3D2). > > >=20 > > > The backend complies to the Xen transport for 9pfs specification > > > version 1, available here: > > >=20 > > > https://xenbits.xen.org/docs/unstable/misc/9pfs.html > > >=20 > > >=20 > > > Changes in v4: > > > - add reviewed-bys > > > - remove useless if(NULL) checks around g_free > > > - g_free g_malloc'ed sgs > > > - remove XEN_9PFS_RING_ORDER, make the ring order dynamic per ring, > > > reading the ring_order field in xen_9pfs_data_intf > > > - remove patch not to build Xen backends on non-Xen capable targets > > > because it is already upstream > > > =20 > >=20 > > Hi Stefano, > >=20 > > This looks good to me. Do you want these patches to go through my 9p > > tree or through your xen tree ? =20 >=20 > Thanks Greg! It can work both ways. If you have any changes in your queue > that could conflict with this, it's best to go via your tree. >=20 > Otherwise, I'll merge it in mine, so that I can keep an eye on the > correspondent Xen changes to the header files and make sure they are in > sync (specifically http://marc.info/?l=3Dqemu-devel&m=3D149003412910278). >=20 I don't have any conflicting patches on my side. Please merge this in your tree (as well as the MAINTAINERS patch). Cheers, -- Greg >=20 > > Also, I guess you may want to add > > F: hw/9pfs/xen-9p-backend.c to the Xen section in MAINTAINERS. =20 >=20 > I'll send a patch to be applied on top of the series >=20 >=20 > > -- > > Greg > > =20 > > > Changes in v3: > > > - do not build backends for targets that do not support xen > > > - remove xen_9pfs.h, merge its content into xen-9p-backend.c > > > - remove xen_9pfs_header, introduce P9MsgHeader > > > - use le32_to_cpu to access P9MsgHeader fields > > > - many coding style fixes > > > - run checkpatch on all patches > > > - add check if num_rings < 1 > > > - use g_strdup_printf > > > - free fsdev_id in xen_9pfs_free > > > - add comments > > >=20 > > > Changes in v2: > > > - fix coding style > > > - compile xen-9p-backend.c if CONFIG_XEN_BACKEND > > > - add patch to set CONFIG_XEN_BACKEND only for the right targets > > > - add review-bys > > >=20 > > >=20 > > > Stefano Stabellini (8): > > > xen: import ring.h from xen > > > 9p: introduce a type for the 9p header > > > xen/9pfs: introduce Xen 9pfs backend > > > xen/9pfs: connect to the frontend > > > xen/9pfs: receive requests from the frontend > > > xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal > > > xen/9pfs: send responses back to the frontend > > > xen/9pfs: build and register Xen 9pfs backend > > >=20 > > > hw/9pfs/9p.h | 6 + > > > hw/9pfs/Makefile.objs | 1 + > > > hw/9pfs/virtio-9p-device.c | 6 +- > > > hw/9pfs/xen-9p-backend.c | 444 +++++++++++++++++++++++++++++++++= ++++++++ > > > hw/block/xen_blkif.h | 2 +- > > > hw/usb/xen-usb.c | 2 +- > > > hw/xen/xen_backend.c | 3 + > > > include/hw/xen/io/ring.h | 455 +++++++++++++++++++++++++++++++++= ++++++++++ > > > include/hw/xen/xen_backend.h | 3 + > > > 9 files changed, 915 insertions(+), 7 deletions(-) > > > create mode 100644 hw/9pfs/xen-9p-backend.c > > > create mode 100644 include/hw/xen/io/ring.h =20 > >=20 > > =20 --Sig_/PZrGvFJArs_+YGbOXix+9b. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAljSOhwACgkQAvw66wEB28JKCQCcCAKM8hUf7mj5QQYy4wOwQN02 xSIAnRt2KgITjNW7k4AoIMAaFUSKvf4n =yn9N -----END PGP SIGNATURE----- --Sig_/PZrGvFJArs_+YGbOXix+9b.-- --===============7864158591107570944== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7864158591107570944==--