Re: [PATCH] tools/firmware: use a canned config for seabios

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Mar 29, 2017 at 11:28:15AM +0100, Paul Durrant wrote:
> > -----Original Message-----
> [snip]
> > > > > This patch adds the canned configuration into tools/firmware and
> > modifies
> > > > > the Makefile rule to copy it into place.
> > > > >
> > > >
> > > > I think at some point someone (you?) tried to change the default
> > > > upstream, what was the outcome?
> > > >
> > >
> > > Yes I tried that. The maintainers nacked the patch.
> > >
> > > > I'm not against shipping a default config, but that wouldn't benefit all
> > > > the distros that use their own seabios packages.
> > > >
> > >
> > > No, but the status quo sucks. One hopes distros building their own Xen
> > packages already choose a better firmware config. This patch makes the
> > config for those rolling their own firmware better (and I suspect that's quite a
> > few folks).
> > >
> > 
> > I forgot to ask: what exactly in this config file is different from the
> > default one?
> > 
> 
> The commit message tells you... It turns on wide PIO and DMA for interaction with the emulated IDE controller.
> 

Oops, yes. Sorry for the noise.

Acked-by: Wei Liu <wei.liu2@citrix.com>

I will leave this patch float for a while so other people can comment.

>   Paul
> 
> > Wei.
> > 
> > >   Paul
> > >
> > > > Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel