From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Otto Subject: Re: [PATCH RFC 05/20] libxc/xc_sr: factor out filter_pages() Date: Thu, 30 Mar 2017 00:42:18 -0400 Message-ID: <20170330044203.GA5346@eagle> References: <1490605592-12189-1-git-send-email-jtotto@uwaterloo.ca> <1490605592-12189-6-git-send-email-jtotto@uwaterloo.ca> <5b010d08-7e47-0e96-6711-c405030555cc@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctRus-00025d-P9 for xen-devel@lists.xenproject.org; Thu, 30 Mar 2017 04:42:34 +0000 Content-Disposition: inline In-Reply-To: <5b010d08-7e47-0e96-6711-c405030555cc@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: ian.jackson@eu.citrix.com, hjarmstr@uwaterloo.ca, wei.liu2@citrix.com, czylin@uwaterloo.ca, imhy.yang@gmail.com List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjgsIDIwMTcgYXQgMDg6Mjc6NDhQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAyNy8wMy8xNyAxMDowNiwgSm9zaHVhIE90dG8gd3JvdGU6Cj4gPiBkaWZmIC0t Z2l0IGEvdG9vbHMvbGlieGMveGNfc3JfcmVzdG9yZS5jIGIvdG9vbHMvbGlieGMveGNfc3JfcmVz dG9yZS5jCj4gPiBpbmRleCA0ODFhOTA0Li44NTc0ZWU4IDEwMDY0NAo+ID4gLS0tIGEvdG9vbHMv bGlieGMveGNfc3JfcmVzdG9yZS5jCj4gPiArKysgYi90b29scy9saWJ4Yy94Y19zcl9yZXN0b3Jl LmMKPiA+IEBAIC0xOTQsNiArMTk0LDY4IEBAIGludCBwb3B1bGF0ZV9wZm5zKHN0cnVjdCB4Y19z cl9jb250ZXh0ICpjdHgsIHVuc2lnbmVkIGNvdW50LAo+ID4gICAgICByZXR1cm4gcmM7Cj4gPiAg fQo+ID4gIAo+ID4gK3N0YXRpYyB2b2lkIHNldF9wYWdlX3R5cGVzKHN0cnVjdCB4Y19zcl9jb250 ZXh0ICpjdHgsIHVuc2lnbmVkIGNvdW50LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg IHhlbl9wZm5fdCAqcGZucywgdWludDMyX3QgKnR5cGVzKQo+ID4gK3sKPiA+ICsgICAgdW5zaWdu ZWQgaTsKPiAKPiBQbGVhc2UgdXNlIHVuc2lnbmVkIGludCByYXRoZXIgdGhhbiBqdXN0ICJ1bnNp Z25lZCIgdGhyb3VnaG91dC4KCk9rYXkuICAoRm9yIHdoYXQgaXQncyB3b3J0aCwgSSBjaG9zZSBw bGFpbiAidW5zaWduZWQiIGhlcmUgZm9yIGNvbnNpc3RlbmN5IHdpdGgKdGhlIHJlc3Qgb2YgeGNf c3Jfc2F2ZS94Y19zcl9yZXN0b3JlKQoKPiA+ICsKPiA+ICsgICAgZm9yICggaSA9IDA7IGkgPCBj b3VudDsgKytpICkKPiA+ICsgICAgICAgIGN0eC0+cmVzdG9yZS5vcHMuc2V0X3BhZ2VfdHlwZShj dHgsIHBmbnNbaV0sIHR5cGVzW2ldKTsKPiA+ICt9Cj4gPiArCj4gPiArLyoKPiA+ICsgKiBHaXZl biBjb3VudCBwZm5zIGFuZCB0aGVpciB0eXBlcywgYWxsb2NhdGUgYW5kIGZpbGwgaW4gYnVmZmVy IGJwZm5zIHdpdGggb25seQo+ID4gKyAqIHRob3NlIHBmbnMgdGhhdCBhcmUgJ2JhY2tlZCcgYnkg cmVhbCBwYWdlIGRhdGEgdGhhdCBuZWVkcyB0byBiZSBtaWdyYXRlZC4KPiA+ICsgKiBUaGUgY2Fs bGVyIG11c3QgbGF0ZXIgZnJlZSgpICpicGZucy4KPiA+ICsgKgo+ID4gKyAqIFJldHVybnMgMCBv biBzdWNjZXNzIGFuZCBub24tMCBvbiBmYWlsdXJlLiAgKmJwZm5zIGNhbiBiZSBmcmVlKCllZCBl dmVuIGFmdGVyCj4gPiArICogZmFpbHVyZS4KPiA+ICsgKi8KPiA+ICtzdGF0aWMgaW50IGZpbHRl cl9wYWdlcyhzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4LAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGNvdW50LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgIHhlbl9w Zm5fdCAqcGZucywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCAqdHlwZXMs Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgLyogT1VUICovIHVuc2lnbmVkICpucl9wYWdl cywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAvKiBPVVQgKi8geGVuX3Bmbl90ICoqYnBm bnMpCj4gPiArewo+ID4gKyAgICB4Y19pbnRlcmZhY2UgKnhjaCA9IGN0eC0+eGNoOwo+IAo+IFBv aW50ZXJzIHRvIGFycmF5cyBhcmUgdmVyeSBlYXN5IHRvIGdldCB3cm9uZyBpbiBDLiAgVGhpcyBj b2RlIHdpbGwgYmUKPiBsZXNzIGVycm9yIGlmIHlvdSB1c2UKPiAKPiB4ZW5fcGZuX3QgKl9wZm5z OyAgKHZhcmlhYmxlIG5hbWUgc3ViamVjdCB0byBpbXByb3ZlbWVudCkKPiAKPiA+ICsgICAgdW5z aWduZWQgaTsKPiA+ICsKPiA+ICsgICAgKm5yX3BhZ2VzID0gMDsKPiA+ICsgICAgKmJwZm5zID0g bWFsbG9jKGNvdW50ICogc2l6ZW9mKCpicGZucykpOwo+IAo+IF9wZm5zID0gKmJmbnMgPSBtYWxs b2MoLi4uKS4KPiAKPiBUaGVuIHVzZSBfcGZucyBpbiBwbGFjZSBvZiAoKmJwZm5zKSBldmVyeXdo ZXJlIGVsc2UuCj4gCj4gSG93ZXZlciwgIHlvdXIgc2l6ZW9mIGhhcyB0aGUgd3JvbmcgaW5kaXJl Y3Rpb24uICBJdCB3b3JrcyBvbiB4ODYKPiBiZWNhdXNlIHhlbl9wZm5fdCBpcyB0aGUgc2FtZSBz aXplIGFzIGEgcG9pbnRlciwgYnV0IGl0IHdpbGwgYmxvdyB1cCBvbgo+IDMyYml0IEFSTSwgd2hl cmUgYSBwb2ludGVyIGlzIDQgYnl0ZXMgYnV0IHhlbl9wZm5fdCBpcyA4IGJ5dGVzLgoKQWdoISAg T2ggZGVhci4KCj4gPiArICAgIGlmICggISgqYnBmbnMpICkKPiA+ICsgICAgewo+ID4gKyAgICAg ICAgRVJST1IoIkZhaWxlZCB0byBhbGxvY2F0ZSAlenUgYnl0ZXMgdG8gcHJvY2VzcyBwYWdlIGRh dGEiLAo+ID4gKyAgICAgICAgICAgICAgY291bnQgKiAoc2l6ZW9mKCpicGZucykpKTsKPiA+ICsg ICAgICAgIHJldHVybiAtMTsKPiA+ICsgICAgfQo+ID4gKwo+ID4gKyAgICBmb3IgKCBpID0gMDsg aSA8IGNvdW50OyArK2kgKQo+ID4gKyAgICB7Cj4gPiArICAgICAgICBzd2l0Y2ggKCB0eXBlc1tp XSApCj4gPiArICAgICAgICB7Cj4gPiArICAgICAgICBjYXNlIFhFTl9ET01DVExfUEZJTkZPX05P VEFCOgo+ID4gKwo+ID4gKyAgICAgICAgY2FzZSBYRU5fRE9NQ1RMX1BGSU5GT19MMVRBQjoKPiA+ ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDFUQUIgfCBYRU5fRE9NQ1RMX1BGSU5G T19MUElOVEFCOgo+ID4gKwo+ID4gKyAgICAgICAgY2FzZSBYRU5fRE9NQ1RMX1BGSU5GT19MMlRB QjoKPiA+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDJUQUIgfCBYRU5fRE9NQ1RM X1BGSU5GT19MUElOVEFCOgo+ID4gKwo+ID4gKyAgICAgICAgY2FzZSBYRU5fRE9NQ1RMX1BGSU5G T19MM1RBQjoKPiA+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDNUQUIgfCBYRU5f RE9NQ1RMX1BGSU5GT19MUElOVEFCOgo+ID4gKwo+ID4gKyAgICAgICAgY2FzZSBYRU5fRE9NQ1RM X1BGSU5GT19MNFRBQjoKPiA+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDRUQUIg fCBYRU5fRE9NQ1RMX1BGSU5GT19MUElOVEFCOgo+ID4gKwo+ID4gKyAgICAgICAgICAgICgqYnBm bnMpWygqbnJfcGFnZXMpKytdID0gcGZuc1tpXTsKPiA+ICsgICAgICAgICAgICBicmVhazsKPiA+ ICsgICAgICAgIH0KPiA+ICsgICAgfQo+ID4gKwo+ID4gKyAgICByZXR1cm4gMDsKPiA+ICt9Cj4g PiArCj4gPiAgLyoKPiA+ICAgKiBHaXZlbiBhIGxpc3Qgb2YgcGZucywgdGhlaXIgdHlwZXMsIGFu ZCBhIGJsb2NrIG9mIHBhZ2UgZGF0YSBmcm9tIHRoZQo+ID4gICAqIHN0cmVhbSwgcG9wdWxhdGUg YW5kIHJlY29yZCB0aGVpciB0eXBlcywgbWFwIHRoZSByZWxldmFudCBzdWJzZXQgYW5kIGNvcHkK PiA+IEBAIC0yMDMsNyArMjY1LDcgQEAgc3RhdGljIGludCBwcm9jZXNzX3BhZ2VfZGF0YShzdHJ1 Y3QgeGNfc3JfY29udGV4dCAqY3R4LCB1bnNpZ25lZCBjb3VudCwKPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHhlbl9wZm5fdCAqcGZucywgdWludDMyX3QgKnR5cGVzLCB2b2lkICpw YWdlX2RhdGEpCj4gPiAgewo+ID4gICAgICB4Y19pbnRlcmZhY2UgKnhjaCA9IGN0eC0+eGNoOwo+ ID4gLSAgICB4ZW5fcGZuX3QgKm1mbnMgPSBtYWxsb2MoY291bnQgKiBzaXplb2YoKm1mbnMpKTsK PiA+ICsgICAgeGVuX3Bmbl90ICptZm5zID0gTlVMTDsKPiAKPiBUaGlzIHNob3dzIGEgbmFtaW5n IGJ1Zywgd2hpY2ggaXMgbXkgZmF1bHQuICBUaGlzIHNob3VsZCBiZSBuYW1lZCBnZm5zLAo+IG5v dCBtZm5zLiAgKEl0IGluaGVyaXRzIGl0cyBuYW1lIGZyb20gdGhlIGxlZ2FjeSBtaWdyYXRpb24g Y29kZSwgYnV0Cj4gdGhhdCB3YXMgYWxzbyB3cm9uZy4pCj4gCj4gUGxlYXNlIGNvcnJlY3QgaXQs IGVpdGhlciBpbiB0aGlzIHBhdGNoIG9yIGFub3RoZXI7IHRoZSBtZW1vcnkKPiBtYW5hZ2VtZW50 IHRlcm1zIGFyZSBoYXJkIGVub3VnaCwgZXZlbiB3aGVuIGFsbCB0aGUgY29kZSBpcyBjb3JyZWN0 LgoKQWhoaGhoaGggLSBJIGFjdHVhbGx5IGZvdW5kIHRoaXMgZGVzcGVyYXRlbHkgY29uZnVzaW5n IHdoZW4gdHJ5aW5nIHRvIGdyb2sgdGhlCmNvZGUgb3JpZ2luYWxseS4gIFRoYW5rcyBmb3IgY2xl YXJpbmcgdGhhdCB1cCEKCkpvc2gKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5v cmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=