xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 7/9] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2
Date: Thu, 30 Mar 2017 14:20:01 +0800	[thread overview]
Message-ID: <20170330062003.9119-8-haozhong.zhang@intel.com> (raw)
In-Reply-To: <20170330062003.9119-1-haozhong.zhang@intel.com>

Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>

Changes in v3:
 * Add a check to avoid XEN_MC_INJECT_CPU_BROADCAST being used
   with XEN_MC_INJECT_TYPE_LMCE.
---
 xen/arch/x86/cpu/mcheck/mce.c         | 25 ++++++++++++++++++++++++-
 xen/include/public/arch-x86/xen-mca.h |  1 +
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index c1a59bf..0de19ae 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1521,11 +1521,12 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
     {
         const cpumask_t *cpumap;
         cpumask_var_t cmv;
+        bool broadcast = op->u.mc_inject_v2.flags & XEN_MC_INJECT_CPU_BROADCAST;
 
         if (nr_mce_banks == 0)
             return x86_mcerr("do_mca #MC", -ENODEV);
 
-        if ( op->u.mc_inject_v2.flags & XEN_MC_INJECT_CPU_BROADCAST )
+        if ( broadcast )
             cpumap = &cpu_online_map;
         else
         {
@@ -1565,6 +1566,28 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
             }
             break;
 
+        case XEN_MC_INJECT_TYPE_LMCE:
+            if ( !lmce_support )
+            {
+                ret = x86_mcerr("No LMCE support in platform", -EINVAL);
+                break;
+            }
+            if ( broadcast )
+            {
+                ret = x86_mcerr("XEN_MC_INJECT_CPU_BROADCAST cannot be used "
+                                "with XEN_MC_INJECT_TYPE_LMCE",
+                                -EINVAL);
+                break;
+            }
+            /* Ensure at most one CPU is specified. */
+            if ( nr_cpu_ids > cpumask_next(cpumask_first(cpumap), cpumap) )
+            {
+                ret = x86_mcerr("More than one CPU specified", -EINVAL);
+                break;
+            }
+            on_selected_cpus(cpumap, x86_mc_mceinject, NULL, 1);
+            break;
+
         default:
             ret = x86_mcerr("Wrong mca type\n", -EINVAL);
             break;
diff --git a/xen/include/public/arch-x86/xen-mca.h b/xen/include/public/arch-x86/xen-mca.h
index 7db9907..dc35267 100644
--- a/xen/include/public/arch-x86/xen-mca.h
+++ b/xen/include/public/arch-x86/xen-mca.h
@@ -414,6 +414,7 @@ struct xen_mc_mceinject {
 #define XEN_MC_INJECT_TYPE_MASK     0x7
 #define XEN_MC_INJECT_TYPE_MCE      0x0
 #define XEN_MC_INJECT_TYPE_CMCI     0x1
+#define XEN_MC_INJECT_TYPE_LMCE     0x2
 
 #define XEN_MC_INJECT_CPU_BROADCAST 0x8
 
-- 
2.10.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-03-30  6:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  6:19 [PATCH v3 0/9] Add LMCE support Haozhong Zhang
2017-03-30  6:19 ` [PATCH v3 1/9] x86/mce: handle LMCE locally Haozhong Zhang
2017-03-30 14:35   ` Jan Beulich
2017-03-31  2:34     ` Haozhong Zhang
2017-03-31  7:24       ` Jan Beulich
2017-04-06  4:50         ` Haozhong Zhang
2017-03-30  6:19 ` [PATCH v3 2/9] x86/mce_intel: detect and enable LMCE on Intel host Haozhong Zhang
2017-03-30  6:19 ` [PATCH v3 3/9] x86/vmx: expose LMCE feature via guest MSR_IA32_FEATURE_CONTROL Haozhong Zhang
2017-03-30 14:36   ` Jan Beulich
2017-03-31  5:11   ` Tian, Kevin
2017-03-30  6:19 ` [PATCH v3 4/9] x86/vmce: emulate MSR_IA32_MCG_EXT_CTL Haozhong Zhang
2017-03-30 14:41   ` Jan Beulich
2017-03-30  6:19 ` [PATCH v3 5/9] x86/vmce: enable injecting LMCE to guest on Intel host Haozhong Zhang
2017-03-30 14:51   ` Jan Beulich
2017-03-30  6:20 ` [PATCH v3 6/9] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP Haozhong Zhang
2017-03-30 14:57   ` Jan Beulich
2017-03-30 16:34     ` Wei Liu
2017-03-30  6:20 ` Haozhong Zhang [this message]
2017-03-30 15:01   ` [PATCH v3 7/9] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2 Jan Beulich
2017-03-30  6:20 ` [PATCH v3 8/9] tools/libxc: add support of injecting MC# to specified CPUs Haozhong Zhang
2017-03-31 11:14   ` Wei Liu
2017-03-30  6:20 ` [PATCH v3 9/9] tools/xen-mceinj: add support of injecting LMCE Haozhong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330062003.9119-8-haozhong.zhang@intel.com \
    --to=haozhong.zhang@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).