From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com
Subject: Re: [PATCH v3 3/4] xenstore: rework of transaction handling
Date: Thu, 30 Mar 2017 12:17:00 +0100 [thread overview]
Message-ID: <20170330111700.kvssrw3nhk5bhttx@citrix.com> (raw)
In-Reply-To: <20170328162615.16857-4-jgross@suse.com>
On Tue, Mar 28, 2017 at 06:26:14PM +0200, Juergen Gross wrote:
[...]
> +
> +static char *transaction_get_node_name(void *ctx, struct transaction *trans,
> + const char *name)
> +{
> + return talloc_asprintf(ctx, "%"PRIu64"/%s", trans->generation, name);
> +}
> +
> +/*
> + * Prepend the transaction to name if appropriate.
> + * In a transaction the transaction will be prepended for:
> + * - write accesses
> + * - read accesses of a node which has been written already in
> + * the same transaction
> + */
> +int transaction_prepend(struct connection *conn, const char *name,
> + enum node_access_type type, TDB_DATA *key)
In the code this function is only ever called with type==READ, so either
you miss one callsite for write access or the comment is wrong.
I would like to hear from you before continuing.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-30 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 16:26 [PATCH v3 0/4] xenstore: rework of transaction handling Juergen Gross
2017-03-28 16:26 ` [PATCH v3 1/4] xenstore: let write_node() and some callers return errno Juergen Gross
2017-03-28 16:26 ` [PATCH v3 2/4] xenstore: undo function rename Juergen Gross
2017-03-28 16:26 ` [PATCH v3 3/4] xenstore: rework of transaction handling Juergen Gross
2017-03-30 11:17 ` Wei Liu [this message]
2017-03-30 12:36 ` Juergen Gross
2017-03-30 13:00 ` Wei Liu
2017-03-28 16:26 ` [PATCH v3 4/4] xenstore: cleanup tdb.c Juergen Gross
2017-03-29 14:10 ` [PATCH v3 0/4] xenstore: rework of transaction handling Juergen Gross
2017-03-30 10:50 ` Julien Grall
2017-04-03 13:53 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330111700.kvssrw3nhk5bhttx@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).