From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [RFC PATCH 3/4] xen-pt: bind/unbind interrupt remapping format MSI Date: Thu, 30 Mar 2017 17:51:45 +0100 Message-ID: <20170330165145.GC1864@perard.uk.xensource.com> References: <1489750157-17401-1-git-send-email-tianyu.lan@intel.com> <1489750157-17401-4-git-send-email-tianyu.lan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1489750157-17401-4-git-send-email-tianyu.lan@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Lan Tianyu Cc: kevin.tian@intel.com, xen-devel@lists.xensource.com, mst@redhat.com, qemu-devel@nongnu.org, sstabellini@kernel.org, chao.gao@intel.com List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBNYXIgMTcsIDIwMTcgYXQgMDc6Mjk6MTZQTSArMDgwMCwgTGFuIFRpYW55dSB3cm90 ZToKPiBGcm9tOiBDaGFvIEdhbyA8Y2hhby5nYW9AaW50ZWwuY29tPgo+IAo+IElmIGEgdklPTU1V IGlzIGV4cG9zZWQgdG8gZ3Vlc3QsIGd1ZXN0IHdpbGwgY29uZmlndXJlIHRoZSBtc2kgdG8gcmVt YXBwaW5nCj4gZm9ybWF0LiBUaGUgb3JpZ2luYWwgY29kZSBpc24ndCBzdWl0YWJsZSB0byB0aGUg bmV3IGZvcm1hdC4gQSBuZXcgcGFpcgo+IGJpbmQvdW5iaW5kIGludGVyZmFjZXMgYXJlIGFkZGVk IGZvciB0aGlzIHVzYWdlLiBUaGlzIHBhdGNoIHJlY29nbml6ZXMKPiB0aGlzIGNhc2UgYW5kIHVz ZSBuZXcgaW50ZXJmYWNlcyB0byBiaW5kL3VuYmluZCBtc2kuCj4gCj4gU2lnbmVkLW9mZi1ieTog Q2hhbyBHYW8gPGNoYW8uZ2FvQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMYW4gVGlhbnl1 IDx0aWFueXUubGFuQGludGVsLmNvbT4KPiAtLS0KPiAgaHcveGVuL3hlbl9wdF9tc2kuYyAgICAg ICAgICAgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgaW5jbHVk ZS9ody9pMzg2L2FwaWMtbXNpZGVmLmggfCAgMSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5z ZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaHcveGVuL3hlbl9w dF9tc2kuYyBiL2h3L3hlbi94ZW5fcHRfbXNpLmMKPiBpbmRleCA2MmFkZDA2Li44YjBkN2ZjIDEw MDY0NAo+IC0tLSBhL2h3L3hlbi94ZW5fcHRfbXNpLmMKPiArKysgYi9ody94ZW4veGVuX3B0X21z aS5jCj4gQEAgLTE2MSw2ICsxNjEsNyBAQCBzdGF0aWMgaW50IG1zaV9tc2l4X3VwZGF0ZShYZW5Q Q0lQYXNzdGhyb3VnaFN0YXRlICpzLAo+ICAgICAgdWludDhfdCBndmVjID0gbXNpX3ZlY3Rvcihk YXRhKTsKPiAgICAgIHVpbnQzMl90IGdmbGFncyA9IG1zaV9nZmxhZ3MoZGF0YSwgYWRkcik7Cj4g ICAgICBpbnQgcmMgPSAwOwo+ICsgICAgYm9vbCBpciA9ICEhKGFkZHIgJiBNU0lfQUREUl9JTV9N QVNLKTsKPiAgICAgIHVpbnQ2NF90IHRhYmxlX2FkZHIgPSAwOwo+ICAKPiAgICAgIFhFTl9QVF9M T0coZCwgIlVwZGF0aW5nIE1TSSVzIHdpdGggcGlycSAlZCBndmVjICUjeCBnZmxhZ3MgJSN4Igo+ IEBAIC0xNzEsOCArMTcyLDE0IEBAIHN0YXRpYyBpbnQgbXNpX21zaXhfdXBkYXRlKFhlblBDSVBh c3N0aHJvdWdoU3RhdGUgKnMsCj4gICAgICAgICAgdGFibGVfYWRkciA9IHMtPm1zaXgtPm1taW9f YmFzZV9hZGRyOwo+ICAgICAgfQo+ICAKPiAtICAgIHJjID0geGNfZG9tYWluX3VwZGF0ZV9tc2lf aXJxKHhlbl94YywgeGVuX2RvbWlkLCBndmVjLAo+ICsgICAgaWYgKGlyKSB7CgpZb3UgY291bGQg bWF5YmUgdXNlIGFkZCZNU0lfQUREUl9JTV9NQVNLIGluc3RlYWQgb2YgZ29pbmcgdGhyb3VnaCBh CnZhcmlhYmxlLgoKPiArICAgICAgICByYyA9IHhjX2RvbWFpbl91cGRhdGVfbXNpX2lycV9yZW1h cHBpbmcoeGVuX3hjLCB4ZW5fZG9taWQsIHBpcnEsCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGQtPmRldmZuLCBkYXRhLCBhZGRyLCB0YWJsZV9hZGRyKTsKCkRvIHlvdSBh bHNvIHdhbnQgdG8gdXBkYXRlIHRoZSBYRU5fUFRfTE9HIGFib3ZlPyBTaW5jZSBpdCBkb2VzIG5v dAphbHdheXMgcmVmbGVjdCB0aGUgdXBkYXRlX21zaSBjYWxsIGFueW1vcmUuCgo+ICsgICAgfQo+ ICsgICAgZWxzZSB7Cj4gKyAgICAgICAgcmMgPSB4Y19kb21haW5fdXBkYXRlX21zaV9pcnEoeGVu X3hjLCB4ZW5fZG9taWQsIGd2ZWMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBwaXJxLCBnZmxhZ3MsIHRhYmxlX2FkZHIpOwo+ICsgICAgfQo+ICAKPiAgICAgIGlmIChyYykg ewo+ICAgICAgICAgIFhFTl9QVF9FUlIoZCwgIlVwZGF0aW5nIG9mIE1TSSVzIGZhaWxlZC4gKGVy cjogJWQpXG4iLAo+IEBAIC0yMDQsMTMgKzIxMSwyNiBAQCBzdGF0aWMgaW50IG1zaV9tc2l4X2Rp c2FibGUoWGVuUENJUGFzc3Rocm91Z2hTdGF0ZSAqcywKPiAgICAgIH0KPiAgCj4gICAgICBpZiAo aXNfYmluZGVkKSB7Cj4gLSAgICAgICAgWEVOX1BUX0xPRyhkLCAiVW5iaW5kIE1TSSVzIHdpdGgg cGlycSAlZCwgZ3ZlYyAlI3hcbiIsCj4gLSAgICAgICAgICAgICAgICAgICBpc19tc2l4ID8gIi1Y IiA6ICIiLCBwaXJxLCBndmVjKTsKPiAtICAgICAgICByYyA9IHhjX2RvbWFpbl91bmJpbmRfbXNp X2lycSh4ZW5feGMsIHhlbl9kb21pZCwgZ3ZlYywgcGlycSwgZ2ZsYWdzKTsKPiAtICAgICAgICBp ZiAocmMpIHsKPiAtICAgICAgICAgICAgWEVOX1BUX0VSUihkLCAiVW5iaW5kaW5nIG9mIE1TSSVz IGZhaWxlZC4gKGVycjogJWQsIHBpcnE6ICVkLCBndmVjOiAlI3gpXG4iLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgIGlzX21zaXggPyAiLVgiIDogIiIsIGVycm5vLCBwaXJxLCBndmVjKTsKPiAt ICAgICAgICAgICAgcmV0dXJuIHJjOwo+ICsgICAgICAgIGlmICggYWRkciAmIE1TSV9BRERSX0lN X01BU0sgKSB7Cj4gKyAgICAgICAgICAgIFhFTl9QVF9MT0coZCwgIlVuYmluZGluZyBvZiBNU0kl cyAuICggcGlycTogJWQsIGRhdGE6ICV4LCBhZGRyOiAlbHgpXG4iLAoKRm9yIGFkZHIsIGl0IHNo b3VsZCBiZSBQUkl4NjQgaW5zdGVhZCBvZiAlbHguCgo+ICsgICAgICAgICAgICAgICAgICAgICAg IGlzX21zaXggPyAiLVgiIDogIiIsIHBpcnEsIGRhdGEsIGFkZHIpOwo+ICsgICAgICAgICAgICBy YyA9IHhjX2RvbWFpbl91bmJpbmRfbXNpX2lycV9yZW1hcHBpbmcoeGVuX3hjLCB4ZW5fZG9taWQs IHBpcnEsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBkLT5kZXZmbiwgZGF0YSwgYWRkcik7Cj4gKyAgICAgICAgICAgIGlmIChyYykgewo+ICsg ICAgICAgICAgICAgICAgWEVOX1BUX0VSUihkLCAiVW5iaW5kaW5nIG9mIE1TSSVzIC4gKGVycm9y OiAlZCwgcGlycTogJWQsIGRhdGE6ICV4LCBhZGRyOiAlbHgpXG4iLAo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICBpc19tc2l4ID8gIi1YIiA6ICIiLCByYywgcGlycSwgZGF0YSwgYWRkcik7 Cj4gKyAgICAgICAgICAgICAgICByZXR1cm4gcmM7Cj4gKyAgICAgICAgICAgIH0KPiArCj4gKyAg ICAgICAgfSBlbHNlIHsKPiArICAgICAgICAgICAgWEVOX1BUX0xPRyhkLCAiVW5iaW5kIE1TSSVz IHdpdGggcGlycSAlZCwgZ3ZlYyAlI3hcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaXNf bXNpeCA/ICItWCIgOiAiIiwgcGlycSwgZ3ZlYyk7Cj4gKyAgICAgICAgICAgIHJjID0geGNfZG9t YWluX3VuYmluZF9tc2lfaXJxKHhlbl94YywgeGVuX2RvbWlkLCBndmVjLCBwaXJxLCBnZmxhZ3Mp Owo+ICsgICAgICAgICAgICBpZiAocmMpIHsKPiArICAgICAgICAgICAgICAgIFhFTl9QVF9FUlIo ZCwgIlVuYmluZGluZyBvZiBNU0klcyBmYWlsZWQuIChlcnI6ICVkLCBwaXJxOiAlZCwgZ3ZlYzog JSN4KVxuIiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgaXNfbXNpeCA/ICItWCIgOiAi IiwgZXJybm8sIHBpcnEsIGd2ZWMpOwo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIHJjOwo+ICsg ICAgICAgICAgICB9Cj4gICAgICAgICAgfQo+ICAgICAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9ody9pMzg2L2FwaWMtbXNpZGVmLmggYi9pbmNsdWRlL2h3L2kzODYvYXBpYy1tc2lkZWYu aAo+IGluZGV4IDhiNGQ0Y2MuLjA4YjU4NGYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9ody9pMzg2 L2FwaWMtbXNpZGVmLmgKPiArKysgYi9pbmNsdWRlL2h3L2kzODYvYXBpYy1tc2lkZWYuaAo+IEBA IC0yNyw1ICsyNyw2IEBACj4gICNkZWZpbmUgTVNJX0FERFJfREVTVF9JRF9TSElGVCAgICAgICAg ICAxMgo+ICAjZGVmaW5lIE1TSV9BRERSX0RFU1RfSURYX1NISUZUICAgICAgICAgNAo+ICAjZGVm aW5lICBNU0lfQUREUl9ERVNUX0lEX01BU0sgICAgICAgICAgMHgwMGZmZmYwCgpDb3VsZCB5b3Ug YWRkIGEgMCB0byBkZXN0X2lkIGhlcmU/IFNvIHRoZWlyIHdpbGwgYmUgOCBkaWdpdCBhbmQgaXQg dGhvc2UKbm90IGxvb2sgd2VpcmQgd2hlbiBjb21wYXJlZCB0byB0aGUgbmV4dCBkZWZpbmUuCgo+ ICsjZGVmaW5lICBNU0lfQUREUl9JTV9NQVNLICAgICAgICAgICAgICAgMHgwMDAwMDAxMAoKSXMg dGhlIGRlZmluaXRpb24gb2YgTVNJX0FERFJfSU1fTUFTSyBhdmFpbGFibGUgc29tZXdoZXJlPyBJ biB0aGUgSW50ZWwKU0RNIEkndmUgb25seSBmb3VuZCB0aGlzIGJpdCB0byBiZSByZXNlcnZlZC4K ClRoYW5rcywKCi0tIApBbnRob255IFBFUkFSRAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==