From: Seraphime Kirkovski <kirkseraph@gmail.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Seraphime Kirkovski <kirkseraph@gmail.com>
Subject: [PATCH] libxc: fix segfault on uninitialized xch->fmem
Date: Mon, 3 Apr 2017 18:02:30 +0200 [thread overview]
Message-ID: <20170403160230.23373-1-kirkseraph@gmail.com> (raw)
Currently in xc_interface_open, xch->fmem is not initialized
and in some rare case the code fails before ever assigning a value
to it.
I got this in master:
$ sudo ./xl/xl run
xencall: error: Could not obtain handle on privileged command interface: No such file or directory
Segmentation fault
This initializes xch->fmem to NULL
Signed-off-by: Seraphime Kirkovski <kirkseraph@gmail.com>
---
tools/libxc/xc_private.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c
index 72e6242417..4ed46fde5f 100644
--- a/tools/libxc/xc_private.c
+++ b/tools/libxc/xc_private.c
@@ -32,6 +32,7 @@ struct xc_interface_core *xc_interface_open(xentoollog_logger *logger,
{
struct xc_interface_core xch_buf, *xch = &xch_buf;
+ xch->fmem = NULL;
xch->flags = open_flags;
xch->dombuild_logger_file = 0;
xc_clear_last_error(xch);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-04-03 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:02 Seraphime Kirkovski [this message]
2017-04-04 10:15 ` [PATCH] libxc: fix segfault on uninitialized xch->fmem Wei Liu
2017-04-04 11:33 ` Seraphime Kirkovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403160230.23373-1-kirkseraph@gmail.com \
--to=kirkseraph@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).