From: Seraphime Kirkovski <kirkseraph@gmail.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxc: fix segfault on uninitialized xch->fmem
Date: Tue, 4 Apr 2017 13:33:11 +0200 [thread overview]
Message-ID: <20170404113311.ezrs3onsv6ecdvf4@macchiaveli> (raw)
In-Reply-To: <20170404101507.lohlu5rbx4jq5md2@citrix.com>
On Tue, Apr 04, 2017 at 11:15:07AM +0100, Wei Liu wrote:
> Since there are a few handles in xch, it would be better to initialise
> them all at once by doing:
>
> struct xc_interface_core xch_buf = { 0 }
>
> > xch->flags = open_flags;
> > xch->dombuild_logger_file = 0;
> > xc_clear_last_error(xch);
> > --
> > 2.11.0
> >
Hi, thanks for the reply.
Literally 10 minutes after sending this, I thought that a bzero would
be better. Will send a V2 shortly.
(Sorry about the resend, mailer problems...)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-04-04 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:02 [PATCH] libxc: fix segfault on uninitialized xch->fmem Seraphime Kirkovski
2017-04-04 10:15 ` Wei Liu
2017-04-04 11:33 ` Seraphime Kirkovski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404113311.ezrs3onsv6ecdvf4@macchiaveli \
--to=kirkseraph@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).