From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Richard W.M. Jones" Subject: Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts Date: Wed, 5 Apr 2017 09:24:43 +0100 Message-ID: <20170405082443.GD30620@redhat.com> References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> <87lgu7flkc.fsf@dusky.pond.sub.org> <9e16eb02-dc8b-b25f-0aba-d4a9ff3b5a02@redhat.com> <274218e6-5539-9eef-56bc-c2de4d11a593@redhat.com> <20170405081835.GB30620@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-block-bounces+gceqb-qemu-block=m.gmane.org@nongnu.org Sender: "Qemu-block" To: Julia Lawall Cc: Ronnie Sahlberg , qemu-devel@nongnu.org, Alexander Graf , Gerd Hoffmann , Stefano Stabellini , "open list:Block layer core" , Michael Roth , Anthony Perard , Fam Zheng , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Stefan Hajnoczi , Richard Henderson , Kevin Wolf , Markus Armbruster , Max Reitz , Paolo Bonzini List-Id: xen-devel@lists.xenproject.org On Wed, Apr 05, 2017 at 10:21:13AM +0200, Julia Lawall wrote: > > > On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > > > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > > > >> Eric Blake writes: > > > >> > > > >>> Quite a few users of qdict_put() were manually wrapping a > > > >>> non-QObject. We can make such call-sites shorter, by providing > > > >>> common macros to do the tedious work. Also shorten nearby > > > >>> qdict_put_obj(,,QOBJECT()) sequences. > > > >>> > > > >>> Signed-off-by: Eric Blake > > > >>> Reviewed-by: Alberto Garcia > > > >>> > > > >>> --- > > > >>> > > > >>> v2: rebase to current master > > > >>> > > > >>> I'm okay if you want me to break this patch into smaller pieces. > > > >> > > > >> I guess I'm okay with a single piece, but I'd like to know how you did > > > >> the conversion. Coccinelle? Manually? > > > > > > > > Manual, via grepping for put_obj.*QOBJECT. I'll see if I can do the same > > > > under Coccinelle (at which point, committing the script will make it > > > > easier to rerun cleanups if later code reintroduces poor usage > > > > patterns), so maybe I have a v3 coming up. > > > > > > I've got a Coccinelle patch (mostly) working now - but it has one > > > shortfall - I found places in tests/check-qdict.c that coccinelle > > > didn't, and traced it to the fact that our use of g_assert_cmpint(expr, > > > ==, expr) throws off the coccinelle parser so badly that it silently > > > ignores the entire function body containing the use of that macro. > > > > Julia ^ is this a known issue? > > Yes, it's completely standard. If there is a problem parsing a top-level > code unit, then the whole top-level code unit is ignored. Actually I meant about g_assert_cmpint, but this is also good to know too. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org