From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.9 2/4] tools/libxc: Avoid generating inappropriate zero-content records
Date: Wed, 5 Apr 2017 12:55:12 +0100 [thread overview]
Message-ID: <20170405115512.2pypgcoaevsl3l4b@citrix.com> (raw)
In-Reply-To: <1490891554-28597-3-git-send-email-andrew.cooper3@citrix.com>
On Thu, Mar 30, 2017 at 05:32:32PM +0100, Andrew Cooper wrote:
> The code as written attempted to elide zero-content records, as such records
> serve no purpose but come with a performance hit. Unfortunately, in the case
> where the hypervisor reported max size is non-zero, but the actual size is
> zero, the record is not elided.
>
> This previously tripped up the sanity checks in the restore side of migration,
> but as the underlying reasons for eliding the records in the first place are
> still valid, fix the elision logic.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-05 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 16:32 [PATCH for-4.9 0/4] Fix migration of PV guests on modern AMD hardware Andrew Cooper
2017-03-30 16:32 ` [PATCH for-4.9 1/4] tools/libxc: Tolerate specific zero-content records in migration v2 streams Andrew Cooper
2017-03-30 16:32 ` [PATCH for-4.9 2/4] tools/libxc: Avoid generating inappropriate zero-content records Andrew Cooper
2017-03-31 7:46 ` Jan Beulich
2017-04-05 11:55 ` Wei Liu [this message]
2017-03-30 16:32 ` [PATCH for-4.9 3/4] tools/python: Adjust migration v2 library to warn about " Andrew Cooper
2017-03-30 16:32 ` [PATCH for-4.9 4/4] docs: Clarify the expected behaviour of " Andrew Cooper
2017-03-31 7:51 ` Jan Beulich
2017-04-06 9:35 ` Wei Liu
2017-04-05 11:55 ` Wei Liu
2017-04-05 11:23 ` [PATCH for-4.9 0/4] Fix migration of PV guests on modern AMD hardware Julien Grall
2017-04-05 11:25 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405115512.2pypgcoaevsl3l4b@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).