xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>, boris.ostrovsky@oracle.com
Subject: [PATCH v3 03/11] x86/xen: use capabilities instead of fake cpuid values for aperf
Date: Tue, 18 Apr 2017 08:31:11 +0200	[thread overview]
Message-ID: <20170418063119.11654-4-jgross@suse.com> (raw)
In-Reply-To: <20170418063119.11654-1-jgross@suse.com>

When running as pv domain xen_cpuid() is being used instead of
native_cpuid(). In xen_cpuid() the aperf/mperf feature is indicated
as not being present by special casing the related cpuid leaf.

Instead of delivering fake cpuid values clear the cpu capability bit
for aperf/mperf instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/xen/enlighten_pv.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index bd69868909b4..4c8cd7278189 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -165,9 +165,6 @@ xen_running_on_version_or_later(unsigned int major, unsigned int minor)
 	return false;
 }
 
-#define CPUID_THERM_POWER_LEAF 6
-#define APERFMPERF_PRESENT 0
-
 static __read_mostly unsigned int cpuid_leaf1_edx_mask = ~0;
 static __read_mostly unsigned int cpuid_leaf1_ecx_mask = ~0;
 
@@ -201,11 +198,6 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
 		*dx = cpuid_leaf5_edx_val;
 		return;
 
-	case CPUID_THERM_POWER_LEAF:
-		/* Disabling APERFMPERF for kernel usage */
-		maskecx = ~(1 << APERFMPERF_PRESENT);
-		break;
-
 	case 0xb:
 		/* Suppress extended topology stuff */
 		maskebx = 0;
@@ -332,6 +324,7 @@ static void __init xen_init_capabilities(void)
 	setup_clear_cpu_cap(X86_BUG_SYSRET_SS_ATTRS);
 	setup_force_cpu_cap(X86_FEATURE_XENPV);
 	setup_clear_cpu_cap(X86_FEATURE_DCA);
+	setup_clear_cpu_cap(X86_FEATURE_APERFMPERF);
 }
 
 static void xen_set_debugreg(int reg, unsigned long val)
-- 
2.12.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-04-18  6:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170418063119.11654-1-jgross@suse.com>
2017-04-18  6:31 ` [PATCH v3 01/11] xen: set cpu capabilities from xen_start_kernel() Juergen Gross
2017-04-18  6:31 ` [PATCH v3 02/11] x86/xen: don't indicate DCA support in pv domains Juergen Gross
2017-04-18  6:31 ` Juergen Gross [this message]
2017-04-18  6:31 ` [PATCH v3 04/11] x86/xen: use capabilities instead of fake cpuid values for mtrr Juergen Gross
2017-04-18  6:31 ` [PATCH v3 05/11] x86/xen: use capabilities instead of fake cpuid values for acc Juergen Gross
2017-04-18  6:31 ` [PATCH v3 06/11] x86/xen: use capabilities instead of fake cpuid values for acpi Juergen Gross
2017-04-18  6:31 ` [PATCH v3 07/11] x86/xen: use capabilities instead of fake cpuid values for mwait Juergen Gross
2017-04-18  6:31 ` [PATCH v3 08/11] x86/xen: use capabilities instead of fake cpuid values for x2apic Juergen Gross
2017-04-18  6:31 ` [PATCH v3 09/11] x86/xen: use capabilities instead of fake cpuid values for xsave Juergen Gross
2017-04-18 10:02   ` Andrew Cooper
     [not found]   ` <2df54917-e8d1-403a-20ff-b956e568bce8@citrix.com>
2017-04-18 11:56     ` Juergen Gross
2017-04-21 14:24   ` Boris Ostrovsky
     [not found]   ` <da6c4270-2123-5203-4e76-32f4b616242f@oracle.com>
2017-04-21 14:38     ` Juergen Gross
     [not found]     ` <12028326-0f19-9430-d8b7-a376facf8749@suse.com>
2017-04-21 14:45       ` Andrew Cooper
2017-04-21 14:51         ` Boris Ostrovsky
2017-04-24  6:23           ` Juergen Gross
2017-04-18  6:31 ` [PATCH v3 10/11] vmware: set cpu capabilities during platform initialization Juergen Gross
2017-04-18  6:31 ` [PATCH v3 11/11] x86/cpu: remove hypervisor specific set_cpu_features Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418063119.11654-4-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).