From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, WeiLiu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 for-next v2 2/8] x86/mm: carve out create_grant_pv_mapping
Date: Fri, 21 Apr 2017 11:13:14 +0100 [thread overview]
Message-ID: <20170421101314.llyjs6eanm6escx7@citrix.com> (raw)
In-Reply-To: <58F79A960200007800152074@prv-mh.provo.novell.com>
On Wed, Apr 19, 2017 at 09:12:54AM -0600, Jan Beulich wrote:
> >>> On 03.04.17 at 13:22, <wei.liu2@citrix.com> wrote:
> > @@ -4300,6 +4297,15 @@ int create_grant_host_mapping(uint64_t addr, unsigned long frame,
> > return create_grant_va_mapping(addr, pte, current);
> > }
> >
> > +int create_grant_host_mapping(uint64_t addr, unsigned long frame,
> > + unsigned int flags, unsigned int cache_flags)
> > +{
> > + if ( paging_mode_external(current->domain) )
> > + return create_grant_p2m_mapping(addr, frame, flags, cache_flags);
> > +
> > + return create_grant_pv_mapping(addr, frame, flags, cache_flags);
> > +}
>
> I wonder whether this and its siblings wouldn't better become inline
> functions.
>
Do you want me to just add "inline"? That's fine by me.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-21 10:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 11:22 [PATCH v2 for-next v2 0/8] Refactor x86 mm.c Wei Liu
2017-04-03 11:22 ` [PATCH v2 for-next v2 1/8] mm: provide more grep fodders Wei Liu
2017-04-03 11:26 ` George Dunlap
2017-04-19 15:08 ` Jan Beulich
2017-04-03 11:22 ` [PATCH v2 for-next v2 2/8] x86/mm: carve out create_grant_pv_mapping Wei Liu
2017-04-19 15:12 ` Jan Beulich
2017-04-21 10:13 ` Wei Liu [this message]
2017-04-21 10:36 ` Jan Beulich
2017-04-03 11:22 ` [PATCH v2 for-next v2 3/8] x86/mm: carve out replace_grant_pv_mapping Wei Liu
2017-04-03 11:22 ` [PATCH v2 for-next v2 4/8] x86/mm: extract PAGE_CACHE_ATTRS to mm.h Wei Liu
2017-04-19 15:15 ` Jan Beulich
2017-04-03 11:22 ` [PATCH v2 for-next v2 5/8] x86/mm: split PV guest supporting code to pv/mm.c Wei Liu
2017-04-19 15:31 ` Jan Beulich
2017-04-21 10:34 ` Wei Liu
2017-04-03 11:22 ` [PATCH v2 for-next v2 6/8] x86/mm: move two PV hypercalls from x86_64/mm.c " Wei Liu
2017-04-19 15:33 ` Jan Beulich
2017-04-21 10:37 ` Wei Liu
2017-04-21 10:43 ` Jan Beulich
2017-04-03 11:22 ` [PATCH v2 for-next v2 7/8] x86/mm: move check_descriptor " Wei Liu
2017-04-03 11:22 ` [PATCH v2 for-next v2 8/8] x86/mm: split HVM grant table code to hvm/mm.c Wei Liu
2017-04-19 15:35 ` Jan Beulich
2017-04-21 10:41 ` Wei Liu
2017-04-21 10:45 ` Jan Beulich
2017-04-21 10:52 ` Wei Liu
2017-04-21 11:30 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421101314.llyjs6eanm6escx7@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).