[OSSTEST PATCH] ts-openstack-deploy: Set http proxy

[OSSTEST PATCH] ts-openstack-deploy: Set http proxy

[Ian Jackson]

This allows ./stack.sh to access the global internet.

CC: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-openstack-deploy | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ts-openstack-deploy b/ts-openstack-deploy
index a1c974f..d4c041d 100755
--- a/ts-openstack-deploy
+++ b/ts-openstack-deploy
@@ -137,8 +137,11 @@ END
 }
 
 sub deploy() {
+    my $httpproxy = http_proxy_envsettings($ho);
+
     target_cmd($ho, <<END, 1800);
         set -e
+        $httpproxy
         cd $builddir/devstack
         ./stack.sh
 END
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy

[Anthony PERARD]

On Tue, Apr 25, 2017 at 04:14:32PM +0100, Ian Jackson wrote:
> This allows ./stack.sh to access the global internet.
> 
> CC: Anthony PERARD <anthony.perard@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  ts-openstack-deploy | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ts-openstack-deploy b/ts-openstack-deploy
> index a1c974f..d4c041d 100755
> --- a/ts-openstack-deploy
> +++ b/ts-openstack-deploy
> @@ -137,8 +137,11 @@ END
>  }
>  
>  sub deploy() {
> +    my $httpproxy = http_proxy_envsettings($ho);
> +
>      target_cmd($ho, <<END, 1800);
>          set -e
> +        $httpproxy
>          cd $builddir/devstack
>          ./stack.sh
>  END

The patch itself looks good, but I think http_proxy_envsettings only set
http_proxy, twice, but does not set https_proxy.

For this patch:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy

[Ian Jackson]

Anthony PERARD writes ("Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy"):
> The patch itself looks good, but I think http_proxy_envsettings only set
> http_proxy, twice, but does not set https_proxy.

Indeed.  See my patch "proxy config: Actually set https_proxy too"
posted today, when I tripped over this too.

> For this patch:
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks.  I'm running more tests with the https mitm cert env setting
you suggested.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel