* [PATCH for-4.9] xen/arm: efi: Avoid out-of-bounds write in meminfo_add_bank
@ 2017-05-04 19:36 Julien Grall
2017-05-04 21:59 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2017-05-04 19:36 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, sstabellini
Commit 2c77db77 "xen/arm: efi: Avoid duplicating the addition of a new
bank", introduced a new function meminfo_add_bank that add a new bank.
This new code fails to check correctly the size of the array which may
result to an out-of-bounds write.
Coverity-ID: 1433183
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
The new function was introduced during the development of Xen 4.9
and should be fixed before the release.
---
xen/arch/arm/efi/efi-boot.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index e1e447ac8e..2986c83447 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -128,7 +128,7 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
{
struct membank *bank;
- if ( mem->nr_banks > NR_MEM_BANKS )
+ if ( mem->nr_banks >= NR_MEM_BANKS )
return false;
bank = &mem->bank[mem->nr_banks];
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-4.9] xen/arm: efi: Avoid out-of-bounds write in meminfo_add_bank
2017-05-04 19:36 [PATCH for-4.9] xen/arm: efi: Avoid out-of-bounds write in meminfo_add_bank Julien Grall
@ 2017-05-04 21:59 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2017-05-04 21:59 UTC (permalink / raw)
To: Julien Grall; +Cc: sstabellini, xen-devel
On Thu, 4 May 2017, Julien Grall wrote:
> Commit 2c77db77 "xen/arm: efi: Avoid duplicating the addition of a new
> bank", introduced a new function meminfo_add_bank that add a new bank.
> This new code fails to check correctly the size of the array which may
> result to an out-of-bounds write.
>
> Coverity-ID: 1433183
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> The new function was introduced during the development of Xen 4.9
> and should be fixed before the release.
> ---
> xen/arch/arm/efi/efi-boot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index e1e447ac8e..2986c83447 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -128,7 +128,7 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
> {
> struct membank *bank;
>
> - if ( mem->nr_banks > NR_MEM_BANKS )
> + if ( mem->nr_banks >= NR_MEM_BANKS )
> return false;
>
> bank = &mem->bank[mem->nr_banks];
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-04 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-04 19:36 [PATCH for-4.9] xen/arm: efi: Avoid out-of-bounds write in meminfo_add_bank Julien Grall
2017-05-04 21:59 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).