From: Wei Liu <wei.liu2@citrix.com>
To: Andrii Anisov <andrii_anisov@epam.com>
Cc: xen-devel@lists.xenproject.org,
Julien Grall <julien.grall@arm.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Andrii Anisov <andrii.anisov@gmail.com>
Subject: Re: [[PATCH]] libxl/arm: Fix ARM build.
Date: Tue, 16 May 2017 16:27:53 +0100 [thread overview]
Message-ID: <20170516152753.26eovsnoyimmcpqx@citrix.com> (raw)
In-Reply-To: <4b55873d-5dbb-fc0c-89e2-f540023b949e@epam.com>
On Tue, May 16, 2017 at 06:14:43PM +0300, Andrii Anisov wrote:
> Dear Wei,
>
>
> On 16.05.17 14:03, Wei Liu wrote:
> > I'm confused by the commit message.
>
> My bad, I did not pay enough attention to write the message. Would following
> be better?
>
> Implicitly initialize a referenced ouput parameter for all code branches
> in order to not face a "variable may be used uninitialized" compilation
> error in a caller function, fired by some compilers under circumstances.
>
> > If I'm right, would it be better to set *size to 0 in the default
> > branch?
>
> Agree.
>
I suspect if you take this approach the commit message you proposed
doesn't quite match either.
Just say:
Initialise *size in default branch to prevent certain compilers (which
ones?) from reporting "variable may be used uninitialized" errors in
caller function.
> --
>
> *Andrii Anisov*
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-16 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 10:23 [[PATCH]] libxl/arm: Fix ARM build Andrii Anisov
2017-05-16 10:59 ` Andrii Anisov
2017-05-16 11:03 ` Wei Liu
2017-05-16 11:06 ` Wei Liu
2017-05-16 15:14 ` Andrii Anisov
2017-05-16 15:27 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516152753.26eovsnoyimmcpqx@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrii.anisov@gmail.com \
--cc=andrii_anisov@epam.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).