* [[PATCH v2]] libxl/arm: Fix ARM build.
@ 2017-05-16 15:57 Andrii Anisov
2017-05-16 16:02 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Anisov @ 2017-05-16 15:57 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, Julien Grall, wei.liu2, Andrii Anisov
From: Andrii Anisov <andrii_anisov@epam.com>
Initialise *size in default branch to prevent certain compilers (i.e.
Linaro GCC 5.2-2015.11-2) from reporting "variable may be used uninitialized"
errors in caller function.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
tools/libxl/libxl_arm_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c
index db113db..a6456be 100644
--- a/tools/libxl/libxl_arm_acpi.c
+++ b/tools/libxl/libxl_arm_acpi.c
@@ -87,6 +87,7 @@ static int libxl__estimate_madt_size(libxl__gc *gc,
break;
default:
LOG(ERROR, "Unknown GIC version");
+ *size = 0;
rc = ERROR_FAIL;
break;
}
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [[PATCH v2]] libxl/arm: Fix ARM build.
2017-05-16 15:57 [[PATCH v2]] libxl/arm: Fix ARM build Andrii Anisov
@ 2017-05-16 16:02 ` Wei Liu
2017-05-17 14:36 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2017-05-16 16:02 UTC (permalink / raw)
To: Andrii Anisov
Cc: xen-devel, Julien Grall, Andrii Anisov, ian.jackson, wei.liu2
On Tue, May 16, 2017 at 06:57:53PM +0300, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@epam.com>
>
> Initialise *size in default branch to prevent certain compilers (i.e.
> Linaro GCC 5.2-2015.11-2) from reporting "variable may be used uninitialized"
> errors in caller function.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [[PATCH v2]] libxl/arm: Fix ARM build.
2017-05-16 16:02 ` Wei Liu
@ 2017-05-17 14:36 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2017-05-17 14:36 UTC (permalink / raw)
To: Wei Liu, Andrii Anisov; +Cc: xen-devel, ian.jackson, Andrii Anisov
Hi,
On 16/05/17 17:02, Wei Liu wrote:
> On Tue, May 16, 2017 at 06:57:53PM +0300, Andrii Anisov wrote:
>> From: Andrii Anisov <andrii_anisov@epam.com>
>>
>> Initialise *size in default branch to prevent certain compilers (i.e.
>> Linaro GCC 5.2-2015.11-2) from reporting "variable may be used uninitialized"
>> errors in caller function.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Julien Grall <julien.grall@arm.com>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-17 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-16 15:57 [[PATCH v2]] libxl/arm: Fix ARM build Andrii Anisov
2017-05-16 16:02 ` Wei Liu
2017-05-17 14:36 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).