From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH for-next v3 06/12] x86/domain: push some code down to hvm_domain_initialise Date: Thu, 1 Jun 2017 12:10:10 +0100 Message-ID: <20170601111010.b7ht32us5ups6vwo@citrix.com> References: <20170426155457.10799-1-wei.liu2@citrix.com> <20170426155457.10799-7-wei.liu2@citrix.com> <20170531180608.6yun23wv6sgmwbdc@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGNzb-00021M-DI for xen-devel@lists.xenproject.org; Thu, 01 Jun 2017 11:10:15 +0000 Content-Disposition: inline In-Reply-To: <20170531180608.6yun23wv6sgmwbdc@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Wei Liu , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXkgMzEsIDIwMTcgYXQgMDc6MDY6MDhQTSArMDEwMCwgV2VpIExpdSB3cm90ZToK PiBPbiBXZWQsIEFwciAyNiwgMjAxNyBhdCAwNDo1NDo1MVBNICswMTAwLCBXZWkgTGl1IHdyb3Rl Ogo+ID4gV2Ugd2FudCB0byBoYXZlIGEgc2luZ2xlIGVudHJ5IHBvaW50IHRvIGluaXRpYWxpc2Ug aHZtIGd1ZXN0LiAgVG8gZG8KPiA+IHRoaXMsIHRoZSBzZXR0aW5nIG9mIGhhcF9lbmFibGVkIGFu ZCBjcmVhdGlvbiBvZiB0aGUgcGVyIGRvbWFpbiBtYXBwaW5ncwo+ID4gaXMgZGVmZXJyZWQsIGJ1 dCB0aGF0J3Mgbm90IGEgcHJvYmxlbS4KPiA+IAo+ID4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gPiBS ZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiA+ IC0tLQo+ID4gdjM6IHVwZGF0ZSBjb21taXQgbWVzc2FnZQo+ID4gCj4gPiB2MjoKPiA+IDEuIHJl b3JkZXIgdGhpbmdzIHRvIGF2b2lkIHJlbmFtZSBsYWJlbHMKPiA+IDIuIGFkZCBjb25maWcgdG8g aHZtX2RvbWFpbl9pbml0aWFsaXNlCj4gPiAKPiA+IENjOiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+Cj4gPiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KPiA+IC0tLQo+ID4gIHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAgICAgIHwgMTQgKysrLS0t LS0tLS0tLS0KPiA+ICB4ZW4vYXJjaC94ODYvaHZtL2h2bS5jICAgICAgICB8IDExICsrKysrKysr KystCj4gPiAgeGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vaHZtLmggfCAgMyArKy0KPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2RvbWFpbi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5j Cj4gPiBpbmRleCBjZWE4MDgwM2E1Li44MDc3NWEwMzYyIDEwMDY0NAo+ID4gLS0tIGEveGVuL2Fy Y2gveDg2L2RvbWFpbi5jCj4gPiArKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKPiA+IEBAIC01 OTgsMTYgKzU5OCw4IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwg dW5zaWduZWQgaW50IGRvbWNyX2ZsYWdzLAo+ID4gICAgICAgICAgZC0+YXJjaC5lbXVsYXRpb25f ZmxhZ3MgPSBlbWZsYWdzOwo+ID4gICAgICB9Cj4gPiAgCj4gPiAtICAgIGlmICggaXNfaHZtX2Rv bWFpbihkKSApCj4gPiAtICAgIHsKPiA+IC0gICAgICAgIGQtPmFyY2guaHZtX2RvbWFpbi5oYXBf ZW5hYmxlZCA9Cj4gPiAtICAgICAgICAgICAgaHZtX2Z1bmNzLmhhcF9zdXBwb3J0ZWQgJiYgKGRv bWNyX2ZsYWdzICYgRE9NQ1JGX2hhcCk7Cj4gCj4gcGFnaW5nX2RvbWFpbl9pbml0IGNhbGxzIGhh cF9lbmFibGVkLiBoYXBfZW5hYmxlZCB1c2VzCj4gZC0+YXJjaC5odm1fZG9tYWluLmhhcF9lbmFi bGVkIHRvIGRldGVybWluZSBpZiBpdCBzaG91bGQgY2FsbCBoYXBfaW5pdC4KPiAKPiBXZSBjYW4n dCBjYWxsIGh2bV9kb21haW5faW5pdGlhbGlzZSBiZWZvcmUgcGFnaW5nX2RvbWFpbl9pbml0IGJl Y2F1c2UKPiBpdCBuZWVkcyBwYWdpbmcgdG8gYmUgaW5pdGlhbGlzZWQuCj4gCj4gU28gSSBjYW4n dCBwdXNoIHNldHRpbmcgdGhpcyBmaWVsZCB0byBodm1fZG9tYWluX2luaXRpYWxpc2UuCj4gCj4g SWYgeW91IHRoaW5rIHRoZXJlIGlzIGEgYmV0dGVyIHdheSB0byBjbGVhbiB0aGlzIHVwIHBsZWFz ZSBsZXQgbWUga25vdy4KCkFuZCB0aGUgbmV3IHBhdGNoLgoKLS0tODwtLS0KRnJvbSA2M2E0NTk1 MDA0NTUwZTQ4NTc5M2MxMWZlZDM2M2U2Zjc0MTdhM2JiIE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAw MQpGcm9tOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgpEYXRlOiBNb24sIDI0IEFwciAy MDE3IDE5OjAwOjM1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0geDg2L2RvbWFpbjogcHVzaCBwZXIt ZG9tYWluIG1hcHBpbmcgY3JlYXRpb24gZG93biB0bwogaHZtX2RvbWFpbl9pbml0aWFsaXNlCgpX ZSB3YW50IHRvIGhhdmUgYSBzaW5nbGUgZW50cnkgcG9pbnQgdG8gaW5pdGlhbGlzZSBodm0gZ3Vl c3QuICBQdXNoCnRoZSBwZXItZG9tYWluIG1hcHBpbmcgY3JlYXRpb24gZG93biB0byBodm1fZG9t YWluX2luaXRpYWxpc2UuCgpXZSBjYW4ndCBtb3ZlIHNldHRpbmcgaGFwX2VuYWJsZWQgeWV0IGJl Y2F1c2UgdGhhdCBmaWVsZCBuZWVkcyB0byBiZQpzZXQgYmVmb3JlIHBhZ2luZyBpbml0aWFsaXNh dGlvbi4gRG9jdW1lbnQgdGhhdC4KCldoaWxlIGF0IGl0LCBzdXBwbHkgaHZtX2RvbWFpbl9pbml0 aWFsaXNlIHdpdGggbW9yZSBhcmd1bWVudHMuIFRob3VnaAp0aGV5IGFyZW4ndCB1c2VkIHlldCwg dGhleSBtaWdodCBiZSByZXF1aXJlZCBpbiB0aGUgZnV0dXJlLgoKU2lnbmVkLW9mZi1ieTogV2Vp IExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4KLS0tCiB4ZW4vYXJjaC94ODYvZG9tYWluLmMgICAg ICAgICB8IDE5ICsrKysrKysrLS0tLS0tLS0tLS0KIHhlbi9hcmNoL3g4Ni9odm0vaHZtLmMgICAg ICAgIHwgIDkgKysrKysrKystCiB4ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9odm0uaCB8ICAzICsr LQogMyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWluLmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMK aW5kZXggMDZjNDZmOWM0OS4uMWM1NzJiYWZiMCAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2Rv bWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtNTk4LDE2ICs1OTgsOCBAQCBp bnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCBkb21j cl9mbGFncywKICAgICAgICAgZC0+YXJjaC5lbXVsYXRpb25fZmxhZ3MgPSBlbWZsYWdzOwogICAg IH0KIAotICAgIGlmICggaXNfaHZtX2RvbWFpbihkKSApCi0gICAgewotICAgICAgICBkLT5hcmNo Lmh2bV9kb21haW4uaGFwX2VuYWJsZWQgPQotICAgICAgICAgICAgaHZtX2Z1bmNzLmhhcF9zdXBw b3J0ZWQgJiYgKGRvbWNyX2ZsYWdzICYgRE9NQ1JGX2hhcCk7Ci0KLSAgICAgICAgcmMgPSBjcmVh dGVfcGVyZG9tYWluX21hcHBpbmcoZCwgUEVSRE9NQUlOX1ZJUlRfU1RBUlQsIDAsIE5VTEwsIE5V TEwpOwotICAgIH0KLSAgICBlbHNlIGlmICggaXNfaWRsZV9kb21haW4oZCkgKQotICAgICAgICBy YyA9IDA7Ci0gICAgZWxzZQorICAgIHJjID0gMDsgLyogSFZNIGFuZCBpZGxlIGRvbWFpbiAqLwor ICAgIGlmICggaXNfcHZfZG9tYWluKGQpICkKICAgICB7CiAgICAgICAgIGQtPmFyY2gucHZfZG9t YWluLmdkdF9sZHRfbDF0YWIgPQogICAgICAgICAgICAgYWxsb2NfeGVuaGVhcF9wYWdlcygwLCBN RU1GX25vZGUoZG9tYWluX3RvX25vZGUoZCkpKTsKQEAgLTYzNSw2ICs2MjcsMTEgQEAgaW50IGFy Y2hfZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgZG9tY3JfZmxh Z3MsCiAgICAgSFlQRVJWSVNPUl9DT01QQVRfVklSVF9TVEFSVChkKSA9CiAgICAgICAgIGlzX3B2 X2RvbWFpbihkKSA/IF9fSFlQRVJWSVNPUl9DT01QQVRfVklSVF9TVEFSVCA6IH4wdTsKIAorICAg IC8qIE5lZWQgdG8gZGV0ZXJtaW5lIGlmIEhBUCBpcyBlbmFibGVkIGJlZm9yZSBpbml0aWFsaXNp bmcgcGFnaW5nICovCisgICAgaWYgKCBpc19odm1fZG9tYWluKGQpICkKKyAgICAgICAgZC0+YXJj aC5odm1fZG9tYWluLmhhcF9lbmFibGVkID0KKyAgICAgICAgICAgIGh2bV9mdW5jcy5oYXBfc3Vw cG9ydGVkICYmIChkb21jcl9mbGFncyAmIERPTUNSRl9oYXApOworCiAgICAgaWYgKCAhaXNfaWRs ZV9kb21haW4oZCkgKQogICAgIHsKICAgICAgICAgaWYgKCAocmMgPSBwYWdpbmdfZG9tYWluX2lu aXQoZCwgZG9tY3JfZmxhZ3MpKSAhPSAwICkKQEAgLTY3NCw3ICs2NzEsNyBAQCBpbnQgYXJjaF9k b21haW5fY3JlYXRlKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCBkb21jcl9mbGFncywK IAogICAgIGlmICggaXNfaHZtX2RvbWFpbihkKSApCiAgICAgewotICAgICAgICBpZiAoIChyYyA9 IGh2bV9kb21haW5faW5pdGlhbGlzZShkKSkgIT0gMCApCisgICAgICAgIGlmICggKHJjID0gaHZt X2RvbWFpbl9pbml0aWFsaXNlKGQsIGRvbWNyX2ZsYWdzLCBjb25maWcpKSAhPSAwICkKICAgICAg ICAgICAgIGdvdG8gZmFpbDsKICAgICB9CiAgICAgZWxzZQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2h2bS9odm0uYyBiL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMKaW5kZXggMjczYmNmZjliYS4u ZjNjMjVhZGVkNiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2h2bS9odm0uYworKysgYi94ZW4v YXJjaC94ODYvaHZtL2h2bS5jCkBAIC01MzYsNyArNTM2LDggQEAgc3RhdGljIGludCBodm1fcHJp bnRfbGluZSgKICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOwogfQogCi1pbnQgaHZtX2RvbWFpbl9p bml0aWFsaXNlKHN0cnVjdCBkb21haW4gKmQpCitpbnQgaHZtX2RvbWFpbl9pbml0aWFsaXNlKHN0 cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZG9tY3JfZmxhZ3MsCisgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0cnVjdCB4ZW5fYXJjaF9kb21haW5jb25maWcgKmNvbmZpZykKIHsKICAg ICB1bnNpZ25lZCBpbnQgbnJfZ3NpczsKICAgICBpbnQgcmM7CkBAIC01NTQsNiArNTU1LDEwIEBA IGludCBodm1fZG9tYWluX2luaXRpYWxpc2Uoc3RydWN0IGRvbWFpbiAqZCkKICAgICBJTklUX0xJ U1RfSEVBRCgmZC0+YXJjaC5odm1fZG9tYWluLndyaXRlX21hcC5saXN0KTsKICAgICBJTklUX0xJ U1RfSEVBRCgmZC0+YXJjaC5odm1fZG9tYWluLmcybV9pb3BvcnRfbGlzdCk7CiAKKyAgICByYyA9 IGNyZWF0ZV9wZXJkb21haW5fbWFwcGluZyhkLCBQRVJET01BSU5fVklSVF9TVEFSVCwgMCwgTlVM TCwgTlVMTCk7CisgICAgaWYgKCByYyApCisgICAgICAgIGdvdG8gZmFpbDsKKwogICAgIGh2bV9p bml0X2NhY2hlYXR0cl9yZWdpb25fbGlzdChkKTsKIAogICAgIHJjID0gcGFnaW5nX2VuYWJsZShk LCBQR19yZWZjb3VudHN8UEdfdHJhbnNsYXRlfFBHX2V4dGVybmFsKTsKQEAgLTYzNyw2ICs2NDIs OCBAQCBpbnQgaHZtX2RvbWFpbl9pbml0aWFsaXNlKHN0cnVjdCBkb21haW4gKmQpCiAgICAgeGZy ZWUoZC0+YXJjaC5odm1fZG9tYWluLmlycSk7CiAgZmFpbDA6CiAgICAgaHZtX2Rlc3Ryb3lfY2Fj aGVhdHRyX3JlZ2lvbl9saXN0KGQpOworICAgIGRlc3Ryb3lfcGVyZG9tYWluX21hcHBpbmcoZCwg UEVSRE9NQUlOX1ZJUlRfU1RBUlQsIDApOworIGZhaWw6CiAgICAgcmV0dXJuIHJjOwogfQogCmRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9odm0uaCBiL3hlbi9pbmNsdWRlL2Fz bS14ODYvaHZtL2h2bS5oCmluZGV4IDdhODViMmUzYjUuLmI2ODdlMDNkY2UgMTAwNjQ0Ci0tLSBh L3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYv aHZtL2h2bS5oCkBAIC0yMzYsNyArMjM2LDggQEAgZXh0ZXJuIHM4IGh2bV9wb3J0ODBfYWxsb3dl ZDsKIGV4dGVybiBjb25zdCBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlICpzdGFydF9zdm0odm9p ZCk7CiBleHRlcm4gY29uc3Qgc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSAqc3RhcnRfdm14KHZv aWQpOwogCi1pbnQgaHZtX2RvbWFpbl9pbml0aWFsaXNlKHN0cnVjdCBkb21haW4gKmQpOworaW50 IGh2bV9kb21haW5faW5pdGlhbGlzZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGRv bWNyX2ZsYWdzLAorICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGVuX2FyY2hfZG9t YWluY29uZmlnICpjb25maWcpOwogdm9pZCBodm1fZG9tYWluX3JlbGlucXVpc2hfcmVzb3VyY2Vz KHN0cnVjdCBkb21haW4gKmQpOwogdm9pZCBodm1fZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRvbWFp biAqZCk7CiB2b2lkIGh2bV9kb21haW5fc29mdF9yZXNldChzdHJ1Y3QgZG9tYWluICpkKTsKLS0g CjIuMTEuMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9s aXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=