xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: Sarah Newman <srn@prgmr.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Ignore .discard sections
Date: Fri, 9 Jun 2017 12:35:09 -0400	[thread overview]
Message-ID: <20170609163509.GQ8707@char.us.oracle.com> (raw)
In-Reply-To: <20170609160336.13351-1-ross.lagerwall@citrix.com>

On Fri, Jun 09, 2017 at 05:03:35PM +0100, Ross Lagerwall wrote:
> Ignore differences in discard sections. They are not included in the final xen
> binary so there is no need to include them in the live patch.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

(And CC-ing Sarah)
> ---
>  create-diff-object.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/create-diff-object.c b/create-diff-object.c
> index 217e58f..ba19daf 100644
> --- a/create-diff-object.c
> +++ b/create-diff-object.c
> @@ -888,6 +888,14 @@ static void kpatch_mark_ignored_sections(struct kpatch_elf *kelf)
>  	struct rela *rela;
>  	char *name;
>  
> +	/* Always ignore .discard sections */
> +	sec = find_section_by_name(&kelf->sections, ".discard");
> +	if (sec) {
> +		sec->ignore = 1;
> +		if (sec->twin)
> +			sec->twin->ignore = 1;
> +	}
> +
>  	sec = find_section_by_name(&kelf->sections, ".livepatch.ignore.sections");
>  	if (!sec)
>  		return;
> -- 
> 2.9.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      parent reply	other threads:[~2017-06-09 16:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 16:03 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Ignore .discard sections Ross Lagerwall
2017-06-09 16:03 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Remove section alignment requirement Ross Lagerwall
2017-06-09 16:25   ` Andrew Cooper
2017-06-09 16:38   ` Konrad Rzeszutek Wilk
2017-06-09 17:00     ` Andrew Cooper
2017-06-09 17:08       ` Konrad Rzeszutek Wilk
2017-06-12  7:30         ` Ross Lagerwall
2017-06-09 16:25 ` [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Ignore .discard sections Andrew Cooper
2017-06-09 16:35 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609163509.GQ8707@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=srn@prgmr.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).