[BUB REPORT] compiler warnings when building tools/firmware/etherboot/ipxe

[BUB REPORT] compiler warnings when building tools/firmware/etherboot/ipxe

[Zhongze Liu]

Hi Xen developers,

Several -Wimplicit-fallthrough were found under
tools/firmware/etherboot/ipxe with GCCv7.1.1.
I'm not sure whether this is the right place to report this since it's
not part of the xen source tree,
But I think I'd better let you know.

Cheers,

Zhongze Liu

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [BUB REPORT] compiler warnings when building tools/firmware/etherboot/ipxe

[Wei Liu]

On Mon, Jun 12, 2017 at 06:40:33PM +0800, Zhongze Liu wrote:
> Hi Xen developers,
> 
> Several -Wimplicit-fallthrough were found under
> tools/firmware/etherboot/ipxe with GCCv7.1.1.
> I'm not sure whether this is the right place to report this since it's
> not part of the xen source tree,
> But I think I'd better let you know.
> 
> Cheers,
> 

Thanks for the report. I need to see if that's fixed in upstream.

If it is fixed in upstream, I might just update the in-tree version;
otherwise I will just report it to them.

For now you can probably append -Wno-implicit-fallthrough to
EXTRA_CFLAGS_XEN_TOOLS to work around the issue. I don't think that
warning is very important.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [BUB REPORT] compiler warnings when building tools/firmware/etherboot/ipxe

[Wei Liu]

On Mon, Jun 12, 2017 at 12:19:42PM +0100, Wei Liu wrote:
> On Mon, Jun 12, 2017 at 06:40:33PM +0800, Zhongze Liu wrote:
> > Hi Xen developers,
> > 
> > Several -Wimplicit-fallthrough were found under
> > tools/firmware/etherboot/ipxe with GCCv7.1.1.
> > I'm not sure whether this is the right place to report this since it's
> > not part of the xen source tree,
> > But I think I'd better let you know.
> > 
> > Cheers,
> > 
> 
> Thanks for the report. I need to see if that's fixed in upstream.

And indeed it is already fixed:

commit 5f85cbb9ee1c00cec81a848a9e871ad5d1e7f53f
Author:     Michael Brown <mcb30@ipxe.org>
AuthorDate: Wed Mar 29 10:36:03 2017 +0300
Commit:     Michael Brown <mcb30@ipxe.org>
CommitDate: Wed Mar 29 10:36:45 2017 +0300

    [build] Avoid implicit-fallthrough warnings on GCC 7

    Reported-by: Vinson Lee <vlee@freedesktop.org>
    Reported-by: Liang Yan <lyan@suse.com>
    Signed-off-by: Michael Brown <mcb30@ipxe.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [BUB REPORT] compiler warnings when building tools/firmware/etherboot/ipxe

[Zhongze Liu]

Hi Wei Liu,

2017-06-12 19:21 GMT+08:00 Wei Liu <wei.liu2@citrix.com>:
> On Mon, Jun 12, 2017 at 12:19:42PM +0100, Wei Liu wrote:
>> On Mon, Jun 12, 2017 at 06:40:33PM +0800, Zhongze Liu wrote:
>> > Hi Xen developers,
>> >
>> > Several -Wimplicit-fallthrough were found under
>> > tools/firmware/etherboot/ipxe with GCCv7.1.1.
>> > I'm not sure whether this is the right place to report this since it's
>> > not part of the xen source tree,
>> > But I think I'd better let you know.
>> >
>> > Cheers,
>> >
>>
>> Thanks for the report. I need to see if that's fixed in upstream.
>
> And indeed it is already fixed:
>
> commit 5f85cbb9ee1c00cec81a848a9e871ad5d1e7f53f
> Author:     Michael Brown <mcb30@ipxe.org>
> AuthorDate: Wed Mar 29 10:36:03 2017 +0300
> Commit:     Michael Brown <mcb30@ipxe.org>
> CommitDate: Wed Mar 29 10:36:45 2017 +0300
>
>     [build] Avoid implicit-fallthrough warnings on GCC 7
>
>     Reported-by: Vinson Lee <vlee@freedesktop.org>
>     Reported-by: Liang Yan <lyan@suse.com>
>     Signed-off-by: Michael Brown <mcb30@ipxe.org>

Got it, thanks.

Cheers,

Zhongze LIu

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel