From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Zhongze Liu <blackskygg@gmail.com>, David Scott <dave@recoil.org>
Subject: Re: [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7
Date: Tue, 13 Jun 2017 11:52:13 +0100 [thread overview]
Message-ID: <20170613105213.pyvxi52bfhuiivew@citrix.com> (raw)
In-Reply-To: <22847.48206.450061.6668@mariner.uk.xensource.com>
On Tue, Jun 13, 2017 at 11:19:58AM +0100, Ian Jackson wrote:
> Zhongze Liu writes ("[PATCH v2] tools: fix several "format-truncation" warnings with GCC 7"):
> > GCC 7.1.1 complains that several buffers passed to snprintf() in
> > xenpmd and tools/ocmal/xc are too small to hold the largest possible
> > resulting string.
> >
> > enlarge the size of these buffers to fix the warnings.
>
> This is probably a reasonable approach. But, I can't see where you
> got the new maximum sizes. Forgive me if I missed a mail, but I think
> at least the commit message should explain how each of the new sizes
> is calculated.
Zhongze, please summarise what we discussed on IRC, especially the part
we figured out the various buffer sizes, in the commit message.
Ideally you should include the exact error messages in the commit
message, too.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-13 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 17:51 [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7 Zhongze Liu
2017-06-13 10:07 ` Wei Liu
2017-06-13 10:19 ` Ian Jackson
2017-06-13 10:52 ` Wei Liu [this message]
2017-06-13 16:03 ` Zhongze Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613105213.pyvxi52bfhuiivew@citrix.com \
--to=wei.liu2@citrix.com \
--cc=blackskygg@gmail.com \
--cc=dave@recoil.org \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).