From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/2] xen/livepatch: Clean up arch relocation handling Date: Wed, 14 Jun 2017 09:44:07 -0400 Message-ID: <20170614134407.GA15061@char.us.oracle.com> References: <1497387096-19058-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1497387096-19058-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Ross Lagerwall , Julien Grall , Stefano Stabellini , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBKdW4gMTMsIDIwMTcgYXQgMDk6NTE6MzVQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiAgKiBSZWR1Y2Ugc3ltYm9sIHNjb3BlIGFuZCBpbml0YWxpc2F0aW9uIGFzIG11Y2gg YXMgcG9zc2libGUKPiAgKiBBbm5vdGF0ZSBhIGZhbGx0aHJvdWdoIGNhc2UgaW4gYXJtNjQKPiAg KiBGaXggc3dpdGNoIHN0YXRlbWVudCBzdHlsZSBpbiBhcm0zMgo+IAo+IE5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+Cj4gLS0tCj4gQ0M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndp bGtAb3JhY2xlLmNvbT4KPiBDQzogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJp eC5jb20+Cj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogU3RlZmFu byBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENDOiBKdWxpZW4gR3JhbGwg PGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IAo+IFRoZSBwdXJwb3NlIG9mIHRoaXMgcGF0Y2ggaXMg c2ltcGx5IHRvIG1ha2UgdGhlIGZvbGxvd2luZyBwYXRjaCBlYXNpZXIgdG8KPiByZXZpZXcuCj4g LS0tCj4gIHhlbi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2guYyB8IDI3ICsrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLQo+ICB4ZW4vYXJjaC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMgfCAxOSArKysr KysrLS0tLS0tLS0tLS0tCj4gIHhlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYyAgICAgICB8IDEzICsr KysrLS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAzNSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTMyL2xpdmVwYXRjaC5j IGIveGVuL2FyY2gvYXJtL2FybTMyL2xpdmVwYXRjaC5jCj4gaW5kZXggYTdmZDVlMi4uYTMyODE3 OSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMKPiArKysgYi94 ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMKPiBAQCAtMjI0LDIxICsyMjQsMjEgQEAgaW50 IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm0oc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9lbGZfc2VjICpy ZWxhLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIHVzZV9yZWxhKQo+ICB7Cj4g LSAgICBjb25zdCBFbGZfUmVsQSAqcl9hOwo+IC0gICAgY29uc3QgRWxmX1JlbCAqcjsKPiAtICAg IHVuc2lnbmVkIGludCBzeW1uZHgsIGk7Cj4gLSAgICB1aW50MzJfdCB2YWw7Cj4gLSAgICB2b2lk ICpkZXN0Owo+ICsgICAgdW5zaWduZWQgaW50IGk7Cj4gICAgICBpbnQgcmMgPSAwOwo+ICAKPiAg ICAgIGZvciAoIGkgPSAwOyBpIDwgKHJlbGEtPnNlYy0+c2hfc2l6ZSAvIHJlbGEtPnNlYy0+c2hf ZW50c2l6ZSk7IGkrKyApCj4gICAgICB7Cj4gKyAgICAgICAgdW5zaWduZWQgaW50IHN5bW5keDsK PiArICAgICAgICB1aW50MzJfdCB2YWw7Cj4gKyAgICAgICAgdm9pZCAqZGVzdDsKPiAgICAgICAg ICB1bnNpZ25lZCBjaGFyIHR5cGU7Cj4gLSAgICAgICAgczMyIGFkZGVuZCA9IDA7Cj4gKyAgICAg ICAgczMyIGFkZGVuZDsKPiAgCj4gICAgICAgICAgaWYgKCB1c2VfcmVsYSApCj4gICAgICAgICAg ewo+IC0gICAgICAgICAgICByX2EgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEtPnNlYy0+c2hfZW50 c2l6ZTsKPiArICAgICAgICAgICAgY29uc3QgRWxmX1JlbEEgKnJfYSA9IHJlbGEtPmRhdGEgKyBp ICogcmVsYS0+c2VjLT5zaF9lbnRzaXplOwo+ICsKPiAgICAgICAgICAgICAgc3ltbmR4ID0gRUxG MzJfUl9TWU0ocl9hLT5yX2luZm8pOwo+ICAgICAgICAgICAgICB0eXBlID0gRUxGMzJfUl9UWVBF KHJfYS0+cl9pbmZvKTsKPiAgICAgICAgICAgICAgZGVzdCA9IGJhc2UtPmxvYWRfYWRkciArIHJf YS0+cl9vZmZzZXQ7IC8qIFAgKi8KPiBAQCAtMjQ2LDEwICsyNDYsMTIgQEAgaW50IGFyY2hfbGl2 ZXBhdGNoX3BlcmZvcm0oc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiAgICAgICAgICB9Cj4g ICAgICAgICAgZWxzZQo+ICAgICAgICAgIHsKPiAtICAgICAgICAgICAgciA9IHJlbGEtPmRhdGEg KyBpICogcmVsYS0+c2VjLT5zaF9lbnRzaXplOwo+ICsgICAgICAgICAgICBjb25zdCBFbGZfUmVs ICpyID0gcmVsYS0+ZGF0YSArIGkgKiByZWxhLT5zZWMtPnNoX2VudHNpemU7Cj4gKwo+ICAgICAg ICAgICAgICBzeW1uZHggPSBFTEYzMl9SX1NZTShyLT5yX2luZm8pOwo+ICAgICAgICAgICAgICB0 eXBlID0gRUxGMzJfUl9UWVBFKHItPnJfaW5mbyk7Cj4gICAgICAgICAgICAgIGRlc3QgPSBiYXNl LT5sb2FkX2FkZHIgKyByLT5yX29mZnNldDsgLyogUCAqLwo+ICsgICAgICAgICAgICBhZGRlbmQg PSBnZXRfYWRkZW5kKHR5cGUsIGRlc3QpOwo+ICAgICAgICAgIH0KPiAgCj4gICAgICAgICAgaWYg KCBzeW1uZHggPiBlbGYtPm5zeW0gKQo+IEBAIC0yNTksMTMgKzI2MSwxMSBAQCBpbnQgYXJjaF9s aXZlcGF0Y2hfcGVyZm9ybShzdHJ1Y3QgbGl2ZXBhdGNoX2VsZiAqZWxmLAo+ICAgICAgICAgICAg ICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgICB9Cj4gIAo+IC0gICAgICAgIGlmICggIXVzZV9y ZWxhICkKPiAtICAgICAgICAgICAgYWRkZW5kID0gZ2V0X2FkZGVuZCh0eXBlLCBkZXN0KTsKClRo aXMgd2FzIGFkZGVkIHJpZ2h0IGFmdGVyIHRoZSBzeW1uZHggPiBlbGYtPm5zeW0gY2hlY2sgYXMK d2F5IHRvIG1ha2Ugc3VyZSB3ZSB3b24ndCBkZXJlZmVyZW5jZSB0aGUgZGVzdCAoYi9jIHRoZSBz eW1ib2wKbWF5IGJlIG91dHNpZGUgdGhlIGJvdW5kcykuCgoKPiAtCj4gICAgICAgICAgdmFsID0g ZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOyAvKiBTICovCj4gIAo+ICAgICAgICAgIHJj ID0gcGVyZm9ybV9yZWwodHlwZSwgZGVzdCwgdmFsLCBhZGRlbmQpOwo+IC0gICAgICAgIHN3aXRj aCAoIHJjICkgewo+ICsgICAgICAgIHN3aXRjaCAoIHJjICkKPiArICAgICAgICB7Cj4gICAgICAg ICAgY2FzZSAtRU9WRVJGTE9XOgo+ICAgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJ VkVQQVRDSCAiJXM6IE92ZXJmbG93IGluIHJlbG9jYXRpb24gJXUgaW4gJXMgZm9yICVzIVxuIiwK PiAgICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIGksIHJlbGEtPm5hbWUsIGJhc2UtPm5h bWUpOwo+IEBAIC0yNzUsOSArMjc1LDYgQEAgaW50IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm0oc3Ry dWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJS LCBMSVZFUEFUQ0ggIiVzOiBVbmhhbmRsZWQgcmVsb2NhdGlvbiAjJXhcbiIsCj4gICAgICAgICAg ICAgICAgICAgICAgZWxmLT5uYW1lLCB0eXBlKTsKPiAgICAgICAgICAgICAgYnJlYWs7Cj4gLQo+ IC0gICAgICAgIGRlZmF1bHQ6Cj4gLSAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgIH0KPiAg Cj4gICAgICAgICAgaWYgKCByYyApCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9hcm02NC9s aXZlcGF0Y2guYyBiL3hlbi9hcmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+IGluZGV4IGRhZTY0 ZjUuLjYzOTI5YjEgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2FybTY0L2xpdmVwYXRjaC5j Cj4gKysrIGIveGVuL2FyY2gvYXJtL2FybTY0L2xpdmVwYXRjaC5jCj4gQEAgLTI0MSwxOSArMjQx LDE2IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg bGl2ZXBhdGNoX2VsZl9zZWMgKmJhc2UsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9lbGZfc2VjICpyZWxhKQo+ICB7Cj4gLSAgICBjb25z dCBFbGZfUmVsQSAqcjsKPiAtICAgIHVuc2lnbmVkIGludCBzeW1uZHgsIGk7Cj4gLSAgICB1aW50 NjRfdCB2YWw7Cj4gLSAgICB2b2lkICpkZXN0Owo+IC0gICAgYm9vbF90IG92ZXJmbG93X2NoZWNr Owo+ICsgICAgdW5zaWduZWQgaW50IGk7Cj4gIAo+ICAgICAgZm9yICggaSA9IDA7IGkgPCAocmVs YS0+c2VjLT5zaF9zaXplIC8gcmVsYS0+c2VjLT5zaF9lbnRzaXplKTsgaSsrICkKPiAgICAgIHsK PiArICAgICAgICBjb25zdCBFbGZfUmVsQSAqciA9IHJlbGEtPmRhdGEgKyBpICogcmVsYS0+c2Vj LT5zaF9lbnRzaXplOwo+ICsgICAgICAgIHVuc2lnbmVkIGludCBzeW1uZHggPSBFTEY2NF9SX1NZ TShyLT5yX2luZm8pOwo+ICsgICAgICAgIHZvaWQgKmRlc3QgPSBiYXNlLT5sb2FkX2FkZHIgKyBy LT5yX29mZnNldDsgLyogUCAqLwo+ICsgICAgICAgIGJvb2wgb3ZlcmZsb3dfY2hlY2sgPSB0cnVl Owo+ICAgICAgICAgIGludCBvdmYgPSAwOwo+IC0KPiAtICAgICAgICByID0gcmVsYS0+ZGF0YSAr IGkgKiByZWxhLT5zZWMtPnNoX2VudHNpemU7Cj4gLQo+IC0gICAgICAgIHN5bW5keCA9IEVMRjY0 X1JfU1lNKHItPnJfaW5mbyk7Cj4gKyAgICAgICAgdWludDY0X3QgdmFsOwo+ICAKPiAgICAgICAg ICBpZiAoIHN5bW5keCA+IGVsZi0+bnN5bSApCj4gICAgICAgICAgewo+IEBAIC0yNjIsMTEgKzI1 OSw4IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gICAgICAgICAgfQo+ICAK PiAtICAgICAgICBkZXN0ID0gYmFzZS0+bG9hZF9hZGRyICsgci0+cl9vZmZzZXQ7IC8qIFAgKi8K PiAgICAgICAgICB2YWwgPSBlbGYtPnN5bVtzeW1uZHhdLnN5bS0+c3RfdmFsdWUgKyAgci0+cl9h ZGRlbmQ7IC8qIFMrQSAqLwo+ICAKPiAtICAgICAgICBvdmVyZmxvd19jaGVjayA9IHRydWU7Cj4g LQo+ICAgICAgICAgIC8qIEFSTTY0IG9wZXJhdGlvbnMgYXQgbWluaW11bSBhcmUgYWx3YXlzIDMy LWJpdC4gKi8KPiAgICAgICAgICBpZiAoIHItPnJfb2Zmc2V0ID49IGJhc2UtPnNlYy0+c2hfc2l6 ZSB8fAo+ICAgICAgICAgICAgICAoci0+cl9vZmZzZXQgKyBzaXplb2YodWludDMyX3QpKSA+IGJh c2UtPnNlYy0+c2hfc2l6ZSApCj4gQEAgLTQwMyw2ICszOTcsNyBAQCBpbnQgYXJjaF9saXZlcGF0 Y2hfcGVyZm9ybV9yZWxhKHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gIAo+ICAgICAgICAg IGNhc2UgUl9BQVJDSDY0X0FEUl9QUkVMX1BHX0hJMjFfTkM6Cj4gICAgICAgICAgICAgIG92ZXJm bG93X2NoZWNrID0gZmFsc2U7Cj4gKyAgICAgICAgICAgIC8qIEZhbGx0aHJvdWdoLiAqLwo+ICAg ICAgICAgIGNhc2UgUl9BQVJDSDY0X0FEUl9QUkVMX1BHX0hJMjE6Cj4gICAgICAgICAgICAgIG92 ZiA9IHJlbG9jX2luc25faW1tKFJFTE9DX09QX1BBR0UsIGRlc3QsIHZhbCwgMTIsIDIxLAo+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBQVJDSDY0X0lOU05fSU1NX0FEUik7CgpP SywgdGhhdCBwYXJ0IGlzIGZpbmUuCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9saXZlcGF0 Y2guYyBiL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYwo+IGluZGV4IGRkNTBkZDEuLjc5MTc2MTAg MTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jCj4gKysrIGIveGVuL2FyY2gv eDg2L2xpdmVwYXRjaC5jCj4gQEAgLTE2MSwxNiArMTYxLDE0IEBAIGludCBhcmNoX2xpdmVwYXRj aF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNoX2VsZl9zZWMgKmJhc2Us Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGxpdmVwYXRj aF9lbGZfc2VjICpyZWxhKQo+ICB7Cj4gLSAgICBjb25zdCBFbGZfUmVsQSAqcjsKPiAtICAgIHVu c2lnbmVkIGludCBzeW1uZHgsIGk7Cj4gLSAgICB1aW50NjRfdCB2YWw7Cj4gLSAgICB1aW50OF90 ICpkZXN0Owo+ICsgICAgdW5zaWduZWQgaW50IGk7Cj4gIAo+ICAgICAgZm9yICggaSA9IDA7IGkg PCAocmVsYS0+c2VjLT5zaF9zaXplIC8gcmVsYS0+c2VjLT5zaF9lbnRzaXplKTsgaSsrICkKPiAg ICAgIHsKPiAtICAgICAgICByID0gcmVsYS0+ZGF0YSArIGkgKiByZWxhLT5zZWMtPnNoX2VudHNp emU7Cj4gLQo+IC0gICAgICAgIHN5bW5keCA9IEVMRjY0X1JfU1lNKHItPnJfaW5mbyk7Cj4gKyAg ICAgICAgY29uc3QgRWxmX1JlbEEgKnIgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEtPnNlYy0+c2hf ZW50c2l6ZTsKPiArICAgICAgICB1bnNpZ25lZCBpbnQgc3ltbmR4ID0gRUxGNjRfUl9TWU0oci0+ cl9pbmZvKTsKPiArICAgICAgICB1aW50OF90ICpkZXN0ID0gYmFzZS0+bG9hZF9hZGRyICsgci0+ cl9vZmZzZXQ7Cj4gKyAgICAgICAgdWludDY0X3QgdmFsOwo+ICAKPiAgICAgICAgICBpZiAoIHN5 bW5keCA+IGVsZi0+bnN5bSApCj4gICAgICAgICAgewo+IEBAIC0xNzksNyArMTc3LDYgQEAgaW50 IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVsYShzdHJ1Y3QgbGl2ZXBhdGNoX2VsZiAqZWxmLAo+ ICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgICB9Cj4gIAo+IC0gICAgICAg IGRlc3QgPSBiYXNlLT5sb2FkX2FkZHIgKyByLT5yX29mZnNldDsKPiAgICAgICAgICB2YWwgPSBy LT5yX2FkZGVuZCArIGVsZi0+c3ltW3N5bW5keF0uc3ltLT5zdF92YWx1ZTsKPiAgCj4gICAgICAg ICAgc3dpdGNoICggRUxGNjRfUl9UWVBFKHItPnJfaW5mbykgKQoKQW5kIHRoaXMgaXMgZmluZSB0 b28uCgo+IC0tIAo+IDIuMS40Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK