From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Date: Wed, 14 Jun 2017 10:18:03 -0400 Message-ID: <20170614141803.GB15061@char.us.oracle.com> References: <1497387096-19058-1-git-send-email-andrew.cooper3@citrix.com> <1497387096-19058-2-git-send-email-andrew.cooper3@citrix.com> <594127F50200007800162D2B@prv-mh.provo.novell.com> <59412AE00200007800162D60@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <59412AE00200007800162D60@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Xen-devel , Ross Lagerwall List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMDQ6MjQ6MDBBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDE0LjA2LjE3IGF0IDEyOjEzLCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4gd3JvdGU6Cj4gPiBPbiAxNC8wNi8xNyAxMToxMSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPj4+ Pj4gT24gMTMuMDYuMTcgYXQgMjI6NTEsIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiB3cm90 ZToKPiA+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jCj4gPj4+ICsrKyBiL3hlbi9h cmNoL3g4Ni9saXZlcGF0Y2guYwo+ID4+PiBAQCAtMTcwLDE0ICsxNzAsMjIgQEAgaW50IGFyY2hf bGl2ZXBhdGNoX3BlcmZvcm1fcmVsYShzdHJ1Y3QgbGl2ZXBhdGNoX2VsZiAKPiA+ICplbGYsCj4g Pj4+ICAgICAgICAgIHVpbnQ4X3QgKmRlc3QgPSBiYXNlLT5sb2FkX2FkZHIgKyByLT5yX29mZnNl dDsKPiA+Pj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+ID4+PiAgCj4gPj4+IC0gICAgICAgIGlm ICggc3ltbmR4ID4gZWxmLT5uc3ltICkKPiA+Pj4gKyAgICAgICAgaWYgKCBzeW1uZHggPT0gU1RO X1VOREVGICkKPiA+Pj4gKyAgICAgICAgICAgIHZhbCA9IDA7Cj4gPj4+ICsgICAgICAgIGVsc2Ug aWYgKCBzeW1uZHggPiBlbGYtPm5zeW0gKQo+ID4+PiAgICAgICAgICB7Cj4gPj4+ICAgICAgICAg ICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IFJlbGF0aXZlIHJlbG9jYXRp b24gd2FudHMgCj4gPiBzeW1ib2xAJXUgd2hpY2ggaXMgcGFzdCBlbmQhXG4iLAo+ID4+PiAgICAg ICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gPj4+ICAgICAgICAgICAgICBy ZXR1cm4gLUVJTlZBTDsKPiA+Pj4gICAgICAgICAgfQo+ID4+PiAtCj4gPj4+IC0gICAgICAgIHZh bCA9IHItPnJfYWRkZW5kICsgZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOwo+ID4+PiAr ICAgICAgICBlbHNlIGlmICggIWVsZi0+c3ltW3N5bW5keF0uc3ltICkKPiA+Pj4gKyAgICAgICAg ewo+ID4+PiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBO byBzeW1ib2xAJXVcbiIsCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgIGVsZi0+bmFtZSwgc3lt bmR4KTsKPiA+Pj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4+PiArICAgICAgICB9 Cj4gPj4+ICsgICAgICAgIGVsc2UKPiA+Pj4gKyAgICAgICAgICAgIHZhbCA9IHItPnJfYWRkZW5k ICsgZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOwo+ID4+IEkgZG9uJ3QgdW5kZXJzdGFu ZCB0aGlzOiBzdF92YWx1ZSBmb3IgU1ROX1VOREVGIGlzIGdvaW5nIHRvIGJlIHplcm8KPiA+PiAo c28gZmFyIHRoZXJlJ3MgYWxzbyBubyBleHRlbnNpb24gZGVmaW5lZCBmb3IgdGhlIGZpcnN0IGVu dHJ5LCBhZmFpY3QpLAo+ID4+IHNvIHRoZXJlIHNob3VsZCBiZSBubyBkaWZmZXJlbmNlIGJldHdl ZW4gaGFyZC1jb2RpbmcgdGhlIHplcm8gYW5kCj4gPj4gcmVhZGluZyB0aGUgc3ltYm9sIHRhYmxl IGVudHJ5LiBGdXJ0aGVybW9yZSByX2FkZGVuZCB3b3VsZCBzdGlsbAo+ID4+IG5lZWQgYXBwbHlp bmcuIEFuZCBmaW5hbGx5ICJ2YWwiIGlzIG5ldmVyIGJlaW5nIGNhc3QgdG8gYSBwb2ludGVyLCBh bmQKPiA+PiBoZW5jZSBJIG1pc3MgdGhlIGNvbm5lY3Rpb24gdG8gd2hhdGV2ZXIgY3Jhc2ggeW91 J3ZlIGJlZW4KPiA+PiBvYnNlcnZpbmcuCj4gPiAKPiA+IGVsZi0+c3ltWzBdLnN5bSBpcyB0aGUg TlVMTCBwb2ludGVyLgo+ID4gCj4gPiAtPnN0X3ZhbHVlIGRlcmVmZXJlbmNlcyBpdC4KPiAKPiBB aCwgYnV0IHRoYXQgaXMgdGhlbiB3aGF0IHlvdSB3YW50IHRvIGNoYW5nZSAodW5sZXNzIHdlIGRl Y2lkZQo+IHRvIG91dHJpZ2h0IHJlZnVzZSBTVE5fVU5ERUYsIHdoaWNoIHN0aWxsIGRlcGVuZHMg b24gd2h5IGl0J3MKPiB0aGVyZSBpbiB0aGUgZmlyc3QgcGxhY2UpLgoKVGhhdCB0aGUgIWVsZi0+ c3ltWzBdLnN5bSBpcyB2ZXJ5IHZhbGlkIGNhc2UuCkFuZCBpbiB0aGF0IGNvbnRleHQgdGhlICd2 YWw9ci0+cl9hZGRlbmQnIG1ha2VzIHNlbnNlLgoKQW5kIGZyb20gYW4gRUZJIHNwZWMsIHRoZSBy ZWxvY2F0aW9ucyBjYW4gcG9pbnQgdG8gdGhlIFNITl9VTkRFRiBhcmVhICh3aHkKd291bGQgaXQg SSBoYXZlIG5vIGNsdWUpIC0gYnV0IG5hdHVyYWxseSB3ZSBjYW4ndCBtZXNzIHdpdGggdGhhdC4K CkJ1dCBJIGFtIGN1cmlvdXMgYXMgSmFuIGFib3V0IHRoaXMgLSBhbmQgd2hldGhlciB0aGlzIGlz IHNvbWV0aGluZyB0aGF0CmNvdWxkIGJlIGNvbnN0cnVjdGVkIHdpdGggYSB0ZXN0LWNhc2U/CgpU aGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK