From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Date: Wed, 14 Jun 2017 15:08:47 -0400 Message-ID: <20170614190847.GX15061@char.us.oracle.com> References: <1497387096-19058-1-git-send-email-andrew.cooper3@citrix.com> <1497387096-19058-2-git-send-email-andrew.cooper3@citrix.com> <594127F50200007800162D2B@prv-mh.provo.novell.com> <59412AE00200007800162D60@prv-mh.provo.novell.com> <20170614141803.GB15061@char.us.oracle.com> <6d055740-eb51-cb9a-7fc9-ff70da5d3a0b@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <6d055740-eb51-cb9a-7fc9-ff70da5d3a0b@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , jamie.iles@oracle.com Cc: Ross Lagerwall , Julien Grall , Stefano Stabellini , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMDc6MzM6NTdQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAxNC8wNi8xNyAxNToxOCwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+ ID4gT24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMDQ6MjQ6MDBBTSAtMDYwMCwgSmFuIEJldWxpY2gg d3JvdGU6Cj4gPj4+Pj4gT24gMTQuMDYuMTcgYXQgMTI6MTMsIDxhbmRyZXcuY29vcGVyM0BjaXRy aXguY29tPiB3cm90ZToKPiA+Pj4gT24gMTQvMDYvMTcgMTE6MTEsIEphbiBCZXVsaWNoIHdyb3Rl Ogo+ID4+Pj4+Pj4gT24gMTMuMDYuMTcgYXQgMjI6NTEsIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu Y29tPiB3cm90ZToKPiA+Pj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMKPiA+Pj4+ PiArKysgYi94ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMKPiA+Pj4+PiBAQCAtMTcwLDE0ICsxNzAs MjIgQEAgaW50IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVsYShzdHJ1Y3QgbGl2ZXBhdGNoX2Vs ZiAKPiA+Pj4gKmVsZiwKPiA+Pj4+PiAgICAgICAgICB1aW50OF90ICpkZXN0ID0gYmFzZS0+bG9h ZF9hZGRyICsgci0+cl9vZmZzZXQ7Cj4gPj4+Pj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+ID4+ Pj4+ICAKPiA+Pj4+PiAtICAgICAgICBpZiAoIHN5bW5keCA+IGVsZi0+bnN5bSApCj4gPj4+Pj4g KyAgICAgICAgaWYgKCBzeW1uZHggPT0gU1ROX1VOREVGICkKPiA+Pj4+PiArICAgICAgICAgICAg dmFsID0gMDsKPiA+Pj4+PiArICAgICAgICBlbHNlIGlmICggc3ltbmR4ID4gZWxmLT5uc3ltICkK PiA+Pj4+PiAgICAgICAgICB7Cj4gPj4+Pj4gICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VS UiwgTElWRVBBVENIICIlczogUmVsYXRpdmUgcmVsb2NhdGlvbiB3YW50cyAKPiA+Pj4gc3ltYm9s QCV1IHdoaWNoIGlzIHBhc3QgZW5kIVxuIiwKPiA+Pj4+PiAgICAgICAgICAgICAgICAgICAgICBl bGYtPm5hbWUsIHN5bW5keCk7Cj4gPj4+Pj4gICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ ID4+Pj4+ICAgICAgICAgIH0KPiA+Pj4+PiAtCj4gPj4+Pj4gLSAgICAgICAgdmFsID0gci0+cl9h ZGRlbmQgKyBlbGYtPnN5bVtzeW1uZHhdLnN5bS0+c3RfdmFsdWU7Cj4gPj4+Pj4gKyAgICAgICAg ZWxzZSBpZiAoICFlbGYtPnN5bVtzeW1uZHhdLnN5bSApCj4gPj4+Pj4gKyAgICAgICAgewo+ID4+ Pj4+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IE5vIHN5 bWJvbEAldVxuIiwKPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5bW5k eCk7Cj4gPj4+Pj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4+Pj4+ICsgICAgICAg IH0KPiA+Pj4+PiArICAgICAgICBlbHNlCj4gPj4+Pj4gKyAgICAgICAgICAgIHZhbCA9IHItPnJf YWRkZW5kICsgZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOwo+ID4+Pj4gSSBkb24ndCB1 bmRlcnN0YW5kIHRoaXM6IHN0X3ZhbHVlIGZvciBTVE5fVU5ERUYgaXMgZ29pbmcgdG8gYmUgemVy bwo+ID4+Pj4gKHNvIGZhciB0aGVyZSdzIGFsc28gbm8gZXh0ZW5zaW9uIGRlZmluZWQgZm9yIHRo ZSBmaXJzdCBlbnRyeSwgYWZhaWN0KSwKPiA+Pj4+IHNvIHRoZXJlIHNob3VsZCBiZSBubyBkaWZm ZXJlbmNlIGJldHdlZW4gaGFyZC1jb2RpbmcgdGhlIHplcm8gYW5kCj4gPj4+PiByZWFkaW5nIHRo ZSBzeW1ib2wgdGFibGUgZW50cnkuIEZ1cnRoZXJtb3JlIHJfYWRkZW5kIHdvdWxkIHN0aWxsCj4g Pj4+PiBuZWVkIGFwcGx5aW5nLiBBbmQgZmluYWxseSAidmFsIiBpcyBuZXZlciBiZWluZyBjYXN0 IHRvIGEgcG9pbnRlciwgYW5kCj4gPj4+PiBoZW5jZSBJIG1pc3MgdGhlIGNvbm5lY3Rpb24gdG8g d2hhdGV2ZXIgY3Jhc2ggeW91J3ZlIGJlZW4KPiA+Pj4+IG9ic2VydmluZy4KPiA+Pj4gZWxmLT5z eW1bMF0uc3ltIGlzIHRoZSBOVUxMIHBvaW50ZXIuCj4gPj4+Cj4gPj4+IC0+c3RfdmFsdWUgZGVy ZWZlcmVuY2VzIGl0Lgo+ID4+IEFoLCBidXQgdGhhdCBpcyB0aGVuIHdoYXQgeW91IHdhbnQgdG8g Y2hhbmdlICh1bmxlc3Mgd2UgZGVjaWRlCj4gPj4gdG8gb3V0cmlnaHQgcmVmdXNlIFNUTl9VTkRF Riwgd2hpY2ggc3RpbGwgZGVwZW5kcyBvbiB3aHkgaXQncwo+ID4+IHRoZXJlIGluIHRoZSBmaXJz dCBwbGFjZSkuCj4gPiBUaGF0IHRoZSAhZWxmLT5zeW1bMF0uc3ltIGlzIHZlcnkgdmFsaWQgY2Fz ZS4KPiA+IEFuZCBpbiB0aGF0IGNvbnRleHQgdGhlICd2YWw9ci0+cl9hZGRlbmQnIG1ha2VzIHNl bnNlLgo+ID4KPiA+IEFuZCBmcm9tIGFuIEVGSSBzcGVjLCB0aGUgcmVsb2NhdGlvbnMgY2FuIHBv aW50IHRvIHRoZSBTSE5fVU5ERUYgYXJlYSAod2h5Cj4gPiB3b3VsZCBpdCBJIGhhdmUgbm8gY2x1 ZSkgLSBidXQgbmF0dXJhbGx5IHdlIGNhbid0IG1lc3Mgd2l0aCB0aGF0Lgo+ID4KPiA+IEJ1dCBJ IGFtIGN1cmlvdXMgYXMgSmFuIGFib3V0IHRoaXMgLSBhbmQgd2hldGhlciB0aGlzIGlzIHNvbWV0 aGluZyB0aGF0Cj4gPiBjb3VsZCBiZSBjb25zdHJ1Y3RlZCB3aXRoIGEgdGVzdC1jYXNlPwo+IAo+ IFdlbGwgLSBJJ3ZlIGdvdCBhIGxpdmVwYXRjaCB3aXRoIHN1Y2ggYSByZWxvY2F0aW9uLiAgSXQg aXMgcHJvYmFibHkgYQo+IGxpdmVwYXRjaCBidWlsZCB0b29scyBpc3N1ZSwgYnV0IHRoZSBxdWVz dGlvbiBpcyB3aGV0aGVyIFhlbiBzaG91bGQgZXZlcgo+IGFjY2VwdCBzdWNoIGEgbGl2ZXBhdGNo IG9yIG5vdCAoaXJyZXNwZWN0aXZlIG9mIHdoZXRoZXIgdGhpcyBleGFjdAo+IHJlbG9jYXRpb24g aXMgcGVybWl0dGVkIHdpdGhpbiB0aGUgRUxGIHNwZWMpLgoKQ0MtaW5nIEphbWllCgpJIHdvdWxk IHNheSBubywgYXMgSSBjYW4ndCBmaW5kIGEgZ29vZCB1c2UtY2FzZSBmb3IgYSByZWxvY2F0aW9u IAp0byBwb2ludCB0byB0aGUgU0hOX1VOREVGIHN5bWJvbCBbMF0uIEl0IGZlZWxzIHRvIG1lIGFz IGlmIHNvbWVib2R5CndvdWxkIGJlIG11Y2tpbmcgd2l0aCBhIE5VTEwgcG9pbnRlci4KCkJ1dCBw ZXJoYXBzIGlmIHRoZSBhZGRlbmR1bSBoYWQgYSB2YWx1ZSBpdCB3b3VsZCBtYWtlIHNlbnNlPwoK QXMgaW4gTlVMTCArIDxvZmZzZXQ+PwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=