From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/2] xen/livepatch: Clean up arch relocation handling Date: Mon, 19 Jun 2017 14:18:25 -0400 Message-ID: <20170619181825.GA21025@char.us.oracle.com> References: <1497387096-19058-1-git-send-email-andrew.cooper3@citrix.com> <20170614134407.GA15061@char.us.oracle.com> <59415E150200007800162EAC@prv-mh.provo.novell.com> <26463217-0fb5-efe3-bb72-cf39dc8a3554@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <26463217-0fb5-efe3-bb72-cf39dc8a3554@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Ross Lagerwall , Julien Grall , Stefano Stabellini , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMDc6Mjg6MzlQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBPbiAxNC8wNi8xNyAxNTowMiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPj4+PiBPbiAx NC4wNi4xNyBhdCAxNTo0NCwgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+IHdyb3RlOgo+ID4+IE9u IFR1ZSwgSnVuIDEzLCAyMDE3IGF0IDA5OjUxOjM1UE0gKzAxMDAsIEFuZHJldyBDb29wZXIgd3Jv dGU6Cj4gPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2guYwo+ID4+PiArKysg Yi94ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMKPiA+Pj4gQEAgLTIyNCwyMSArMjI0LDIx IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtKHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYs Cj4gPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNo X2VsZl9zZWMgKnJlbGEsCj4gPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIHVz ZV9yZWxhKQo+ID4+PiAgewo+ID4+PiAtICAgIGNvbnN0IEVsZl9SZWxBICpyX2E7Cj4gPj4+IC0g ICAgY29uc3QgRWxmX1JlbCAqcjsKPiA+Pj4gLSAgICB1bnNpZ25lZCBpbnQgc3ltbmR4LCBpOwo+ ID4+PiAtICAgIHVpbnQzMl90IHZhbDsKPiA+Pj4gLSAgICB2b2lkICpkZXN0Owo+ID4+PiArICAg IHVuc2lnbmVkIGludCBpOwo+ID4+PiAgICAgIGludCByYyA9IDA7Cj4gPj4+ICAKPiA+Pj4gICAg ICBmb3IgKCBpID0gMDsgaSA8IChyZWxhLT5zZWMtPnNoX3NpemUgLyByZWxhLT5zZWMtPnNoX2Vu dHNpemUpOyBpKysgKQo+ID4+PiAgICAgIHsKPiA+Pj4gKyAgICAgICAgdW5zaWduZWQgaW50IHN5 bW5keDsKPiA+Pj4gKyAgICAgICAgdWludDMyX3QgdmFsOwo+ID4+PiArICAgICAgICB2b2lkICpk ZXN0Owo+ID4+PiAgICAgICAgICB1bnNpZ25lZCBjaGFyIHR5cGU7Cj4gPj4+IC0gICAgICAgIHMz MiBhZGRlbmQgPSAwOwo+ID4+PiArICAgICAgICBzMzIgYWRkZW5kOwo+ID4+PiAgCj4gPj4+ICAg ICAgICAgIGlmICggdXNlX3JlbGEgKQo+ID4+PiAgICAgICAgICB7Cj4gPj4+IC0gICAgICAgICAg ICByX2EgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEtPnNlYy0+c2hfZW50c2l6ZTsKPiA+Pj4gKyAg ICAgICAgICAgIGNvbnN0IEVsZl9SZWxBICpyX2EgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEtPnNl Yy0+c2hfZW50c2l6ZTsKPiA+Pj4gKwo+ID4+PiAgICAgICAgICAgICAgc3ltbmR4ID0gRUxGMzJf Ul9TWU0ocl9hLT5yX2luZm8pOwo+ID4+PiAgICAgICAgICAgICAgdHlwZSA9IEVMRjMyX1JfVFlQ RShyX2EtPnJfaW5mbyk7Cj4gPj4+ICAgICAgICAgICAgICBkZXN0ID0gYmFzZS0+bG9hZF9hZGRy ICsgcl9hLT5yX29mZnNldDsgLyogUCAqLwo+ID4+PiBAQCAtMjQ2LDEwICsyNDYsMTIgQEAgaW50 IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm0oc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiA+Pj4g ICAgICAgICAgfQo+ID4+PiAgICAgICAgICBlbHNlCj4gPj4+ICAgICAgICAgIHsKPiA+Pj4gLSAg ICAgICAgICAgIHIgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEtPnNlYy0+c2hfZW50c2l6ZTsKPiA+ Pj4gKyAgICAgICAgICAgIGNvbnN0IEVsZl9SZWwgKnIgPSByZWxhLT5kYXRhICsgaSAqIHJlbGEt PnNlYy0+c2hfZW50c2l6ZTsKPiA+Pj4gKwo+ID4+PiAgICAgICAgICAgICAgc3ltbmR4ID0gRUxG MzJfUl9TWU0oci0+cl9pbmZvKTsKPiA+Pj4gICAgICAgICAgICAgIHR5cGUgPSBFTEYzMl9SX1RZ UEUoci0+cl9pbmZvKTsKPiA+Pj4gICAgICAgICAgICAgIGRlc3QgPSBiYXNlLT5sb2FkX2FkZHIg KyByLT5yX29mZnNldDsgLyogUCAqLwo+ID4+PiArICAgICAgICAgICAgYWRkZW5kID0gZ2V0X2Fk ZGVuZCh0eXBlLCBkZXN0KTsKPiA+Pj4gICAgICAgICAgfQo+ID4+PiAgCj4gPj4+ICAgICAgICAg IGlmICggc3ltbmR4ID4gZWxmLT5uc3ltICkKPiA+Pj4gQEAgLTI1OSwxMyArMjYxLDExIEBAIGlu dCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtKHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gPj4+ ICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+Pj4gICAgICAgICAgfQo+ID4+PiAgCj4g Pj4+IC0gICAgICAgIGlmICggIXVzZV9yZWxhICkKPiA+Pj4gLSAgICAgICAgICAgIGFkZGVuZCA9 IGdldF9hZGRlbmQodHlwZSwgZGVzdCk7Cj4gPj4gVGhpcyB3YXMgYWRkZWQgcmlnaHQgYWZ0ZXIg dGhlIHN5bW5keCA+IGVsZi0+bnN5bSBjaGVjayBhcwo+ID4+IHdheSB0byBtYWtlIHN1cmUgd2Ug d29uJ3QgZGVyZWZlcmVuY2UgdGhlIGRlc3QgKGIvYyB0aGUgc3ltYm9sCj4gPj4gbWF5IGJlIG91 dHNpZGUgdGhlIGJvdW5kcykuCj4gPiBCdXQgc3ltbmR4IGlzbid0IGJlaW5nIHVzZWQgaGVyZS4K PiAKPiBJbmRlZWQuICByLT5yX29mZnNldCAoYW5kIHRoZXJlZm9yZSBkZXN0KSBoYXMgbm8gZGly ZWN0IGJlYXJpbmcgb24gc3ltbmR4LgoKL21lIG5vZHMuCj4gCj4gSGF2aW5nIHNhaWQgdGhhdCwg dGhlcmUgaXMgbm8gc2FuaXR5IGNoZWNrIHRoYXQgci0+cl9vZmZzZXQgaXMgd2l0aGluCj4gYmFz ZS0+bG9hZF9hZGRyICsgc2VjLT5zaF9zaXplIGluIGFybTMyLCB3aGVyZWFzIGJvdGggYXJtNjQg YW5kIHg4Ngo+IGFwcGVhciB0byBkbyB0aGlzIGNoZWNrLgoKVHJ1ZS4KCkFuZCB0aGUgdHJpY2t5 IHBhcnQgKGl0IHdhcyB0byBtZSBhdCBsZWFzdCkgd2FzIHRoYXQgQVJNMzIgaXMgYWxsClJFTCBh bmQgbm90IFJFTEEgc28gdGhlIG9wY29kZSBnZXRzIG1vZGlmaWVkIGFmdGVyIHRoZSBvcGVyYXRp b24uCgpXaGljaCBtZWFucyBpdCBnZXRzIGEgYml0IGNvbXBsZXggdG8gYWRkIGEgYm91bmRhcnkg Y2hlY2sgaW4KJ2dldF9hZGRlbmQnIC4KCkhtLCBpdCB3b3VsZCBzZWVtIHRoZSBiZXN0IHdheSBp cyB0byBhZGQgYQoKaWYgKCByLT5yX29mZnNldCA+PSBiYXNlLT5zZWMtPnNoX3NpemUgfHwgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAoci0+cl9vZmZzZXQgKyBzaXplb2YodWlu dDMyX3QpKSA+IGJhc2UtPnNlYy0+c2hfc2l6ZSApICAgICAgICAgICAgIAoKdGhhdCBpcyBjb21t b24gZm9yIHVzZV9yZWxhIGFuZCBub3QuCgpBbnlob3cgSSBjYW4gZG8gdGhhdCBhcyBJIHdvdWxk IHdhbnQgdG8gY2hlY2sgdGhpcwpvbiByZWFsIGhhcmR3YXJlIDotKQoKRm9yIHlvdXIgcGF0Y2gg KGFzIGlzKQpBY2tlZC1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2lsa0BvcmFj bGUuY29tPgoKQXJlIHlvdSBPSyBjb21taXR0aW5nIGl0IGluPwo+IAo+IH5BbmRyZXcKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hl bi1kZXZlbAo=